[HOLD for payment 2023-06-28] [$1000] Web- Tread - Copy to clipboard on parent [deleted message] does not work

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Open any other platform (eg: notepad) and write anything in it, copy that text
4. Send any message eg: Hello test
5. Click on reply to thread on message
6. Delete the message
7. On [deleted message] click on copy to clipboard
8. Paste the text anywhere to observe that app displays copied text from step 3

Expected Result:

App should not display the 'copy to clipboard' icon on message if it does nothing on click
@parasharrajat recommended here
Hide the icon for this case and also other icons which has no effect.

• From mini-content menu.
• From Context menu.

Actual Result:

App displays copy to clipboard on [deleted message] even though that option does nothing on click

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-06-02.21-50-28.mp4

Recording.2944.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684408470433469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dfe7568572f0563a
• Upwork Job ID: 1665912794319777792
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web- Tread - Copy to clipboard on parent [deleted message] does not work 

What is the root cause of that problem?

• The root cause is ContextMenuActions.js we don’t have any logic to hide Copy to clipboard if message is deleted

What changes do you think we should make in order to solve the problem?

• In order to solve this we need to add a logical condition to check if the message is deleted or not based on a deleted statute we can just hide the option

• On reportActionContextMenu.copyToClipboard inside shouldShow we need to check for the below condition

• We can also hide the delete button (not the scope of this GH but we can check with the same condition

+ `!lodashGet(reportAction, 'originalMessage.isDeletedParentAction', false),`

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Posted in the thread and shared with room.

Gut check... when a message with a thread has been deleted it shows [Deleted message] . When you hover over Copy to clipboard, the icon is clickable but, since the message is deleted, nothing happens.
1, Is this expected behaviour? If so we can :donothing:
2. Since nothing happens when you click Copy to clipboard, so that icon be unclickable for deleted messages?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dfe7568572f0563a

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Triggered auto assignment to @techievivek (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

@aimane-chnaif , please review @dhairyasenjaliya 's proposal above
#20074 (comment)

[aimane-chnaif]

@dhairyasenjaliya's proposal looks good and straight forward.
We've already hidden Download icon for deleted attachment in #19769. So apply same to Copy, Delete icons.

cc: @techievivek
🎀 👀 🎀 C+ reviewed

[parasharrajat]

Let's hide all the icons that are unused for deleted messages in this issue itself. If there are other opened issues for other buttons those should be closed.

[dhairyasenjaliya]

we can hide additional options below

• copy link
• emoji (not sure for this one)

[aimane-chnaif]

we can hide additional options below

• copy link
• emoji (not sure for this one)

no problem with those options but yes we can hide them as well since they're useless.
I checked slack behavior. Only "Mark as unread" option is available for Deleted message

cc: @techievivek if you agree

[techievivek]

Yeah, agree to hide them. Thanks

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @techievivek!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aimane-chnaif]

yes, it's reproducible

[Pujan92]

I think #21632 regression from here(where the icons should hide immediately on delete), which I tried to explain here

[dhairyasenjaliya]

Thanks for insight but not an regressions since this was reported before this PR and we are agreed to handle in separate case #21103 (comment)
@Pujan92

[techievivek]

Agree. I and Joe talked about it and decided to treat it as separate issues.

[techievivek]

Hi, @mallenexpensify have we finished paying contributors for this issue? Or is that pending?

[dhairyasenjaliya]

@mallenexpensify quick note I believe this should be eligible for an urgency bonus as well since PR was created & reviewed by @aimane-chnaif under 3 days but we were not aware that @techievivek was OOO

[techievivek]

Not overdue, waiting for the payments to be done.

[techievivek]

Not overdue, gentle bump @mallenexpensify

[melvin-bot]

@mallenexpensify, @techievivek, @dhairyasenjaliya, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[techievivek]

Gentle bump @mallenexpensify to finish the payment here.

[mallenexpensify]

Sorry for the delay, I was out a couple days and missed the bumps.
Everyone is paid, inc the 50% urgency bonus. since the PR was help up on Vivek being OOO and, more importantly, because changes weren't needed.

@aimane-chnaif can you please complete the checklist?
#20074 (comment)

[aimane-chnaif]

@mallenexpensify Based on #20074 (comment), checklist is already done.

[mallenexpensify]

Thanks @aimane-chnaif, created the TestRail GH https://github.com/Expensify/Expensify/issues/300023

[mallenexpensify]

@aimane-chnaif does any of this need to be completed?

[aimane-chnaif]

I don't think any other step is needed. No PRs caused regression but this case was missed during initial thread implementation.