[HOLD for payment 2023-06-28] [$1000] Web - Split Bill - Profile picture still shows avatar on a new split money page #20118

kbecciv · 2023-06-03T15:07:44Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open NewDot staging on web chrome.
Create a workspace (if you don't already have one). Invite a second member to the workspace.
Go to the workspace's announce room.
Split a bill between the two workspace members.
Click the bill split from within the announce room (so it opens the RHN with the details of the bill split.)
Click the settings tab and change your profile image.
Go back to the announce room, click into the bill split, and notice that your old profile image is display in the details page.

Expected Result:

Profile picture should be updated on a new split money page

Actual Result:

Profile picture still shows avatar on a new split money page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.22.0

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

avatar.mp4

Expensify/Expensify Issue URL:

Issue reported by: @avi-shek-jha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685417843739759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015e350d1e95099cb9
Upwork Job ID: 1665846988733915136
Last Price Increase: 2023-06-12

melvin-bot · 2023-06-03T15:07:49Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-03T15:07:51Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

dukenv0307 · 2023-06-03T15:07:53Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Old Profile picture still shows avatar on a new split money page

What is the root cause of that problem?

The cause is we get payeePersonalDetails from participants that is converted to optionSelector from personalDetails with format here

App/src/libs/OptionsListUtils.js

Lines 216 to 230 in 9fa12f3

    
           keyForList: details.login, 
        
           login: details.login, 
        
           text: details.displayName, 
        
           firstName: lodashGet(details, 'firstName', ''), 
        
           lastName: lodashGet(details, 'lastName', ''), 
        
           alternateText: Str.isSMSLogin(details.login || '') ? LocalePhoneNumber.formatPhoneNumber(details.login) : details.login, 
        
           icons: [ 
        
               { 
        
                   source: UserUtils.getAvatar(details.avatar, details.login), 
        
                   name: details.login, 
        
                   type: CONST.ICON_TYPE_AVATAR, 
        
               }, 
        
           ], 
        
           payPalMeAddress: lodashGet(details, 'payPalMeAddress', ''), 
        
           phoneNumber: lodashGet(details, 'phoneNumber', ''),

App/src/pages/iou/SplitBillDetailsPage.js

Line 69 in 9fa12f3

    
           const payeePersonalDetails = _.filter(participants, (participant) => participant.login === reportAction.actorEmail)[0];

While getIOUConfirmationOptionsFromPayeePersonalDetail fuction get data from fields that follow personalDetailsPropType.

App/src/libs/OptionsListUtils.js

Line 804 in 9fa12f3

    
           function getIOUConfirmationOptionsFromPayeePersonalDetail(personalDetail, amountText) {

Because personalDetail.avatar and personalDetail.displayname is undefined, text is email or phone number instead of display name

App/src/libs/OptionsListUtils.js

Line 806 in 9fa12f3

    
           text: personalDetail.displayName ? personalDetail.displayName : personalDetail.login,

and avatar is default avatar instead of current avatar

App/src/libs/OptionsListUtils.js

Line 810 in 9fa12f3

source: UserUtils.getAvatar(personalDetail.avatar, personalDetail.login),

What changes do you think we should make in order to solve the problem?

We have two solution to fix payee issue

In SpliBillDetailPage, we get payeePersonalDetails from personalDetails instead of participants

App/src/pages/iou/SplitBillDetailsPage.js

Line 69 in 9fa12f3

const payeePersonalDetails = _.filter(participants, (participant) => participant.login === reportAction.actorEmail)[0];
In getIOUConfirmationOptionsFromPayeePersonalDetail function, we only need return personalDetail and other fields that we need because personalDetail now was converted to option

return {
    ...personalDetail
    descriptiveText: amountText,
};

What alternative solutions did you explore? (Optional)

GItGudRatio · 2023-06-03T15:07:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that when we open the Split Bill Details Page, the payee's avatar is not shown correctly.

What is the root cause of that problem?

The root cause behind this issue is that the default avatar URL is passed to the avatar component instead of the user avatar.

This happens because to get the payee's user details, we use the OptionsListUtils.getIOUConfirmationOptionsFromPayeePersonalDetail function. This uses the personalDetails.avatar to get the user's avatar. This is not correct because the payee's details in this.props.payeePersonalDetails are of the format:

{
    "icons": [
        {
            "source": "https://d1wpcgnaa73g0y.cloudfront.net/0fb18190762aaf5fa9f5f91acd2b54a0bbc520f1_128.jpeg",
            "name": "...",
            "type": "avatar"
        }
    ],
    "payPalMeAddress": "",
    "phoneNumber": ""
}

App/src/components/MoneyRequestConfirmationList.js

Lines 198 to 201 in 0813e2c

    
           const formattedPayeePersonalDetails = OptionsListUtils.getIOUConfirmationOptionsFromPayeePersonalDetail( 
        
               this.getPayeePersonalDetails(), 
        
               CurrencyUtils.convertToDisplayString(myIOUAmount, this.props.iou.selectedCurrencyCode), 
        
           );

App/src/libs/OptionsListUtils.js

Line 810 in 245364f

source: UserUtils.getAvatar(personalDetail.avatar, personalDetail.login),

What changes do you think we should make in order to solve the problem?

If there is no props.payeePersonalDetails, it fallbacks to this.props.currentUserPersonalDetails, which has the personalDetails.avatar property. A good way to fix this issue would be to use ternary operators to check if the property avatar exists on the personalDetails object, then use that property else look for icons[0].source or vice versa and pass that to the UserUtils.getAvatar accordingly.

What alternative solutions did you explore? (Optional)

Alternatively, we can modify the personal details prop to use avatar instead of the icons array.

App/src/pages/iou/SplitBillDetailsPage.js

Line 69 in 245364f

    
           const payeePersonalDetails = _.filter(participants, (participant) => participant.login === reportAction.actorEmail)[0];

joekaufmanexpensify · 2023-06-05T22:23:24Z

I can reproduce this. Interestingly, the profile image in the LHN and in the settings tab is also not updating right away after changing it. Although both do update after refreshing the session. Whereas the image on the bill split detailed page does not.

joekaufmanexpensify · 2023-06-05T22:23:54Z

2023-06-05_18-15-42.mp4

melvin-bot · 2023-06-05T22:24:09Z

Job added to Upwork: https://www.upwork.com/jobs/~015e350d1e95099cb9

melvin-bot · 2023-06-05T22:24:11Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-05T22:24:16Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

melvin-bot · 2023-06-05T22:24:20Z

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

parasharrajat · 2023-06-06T01:58:30Z

Reviewing...

joekaufmanexpensify · 2023-06-06T20:18:50Z

Sounds good, thanks @parasharrajat !

joekaufmanexpensify · 2023-06-07T21:14:10Z

@parasharrajat are we good to proceed with either of these proposals?

joekaufmanexpensify · 2023-06-08T18:27:23Z

Bumped proposals in slack here

parasharrajat · 2023-06-09T14:45:39Z

Solution 1 from @dukenv0307 's proposal looks good to me. It seems a simple mistake that we get the payee's personal details from the participants. We do need an option structure for the payee to render but we have a function to convert the personal details to option type. As we fallback to current user personal details, it is clear that payeePersonalDetails should be some type of currentuserpersonalDetails and

App/src/components/MoneyRequestConfirmationList.js

Line 178 in 9fa12f3

getPayeePersonalDetails() {

should return the same type.

cc: @flodnv

🎀 👀 🎀 C+ reviewed

bernhardoj · 2023-06-11T12:01:55Z

Sharing my opinion:

I think @dukenv0307 2nd proposal looks better. Filtering personalDetails (especially in HT account) doesn't sounds good.

parasharrajat · 2023-06-12T09:01:53Z

personalDetails are indexed based on login so IMO, it is O(1) to get the details when we have a login. Also, OptionsListUtils.getPersonalDetailsForLogins can be used for this purpose.

Am I missing something?

joekaufmanexpensify · 2023-06-27T20:24:10Z

As soon as the bug-zero checklist is complete here, we'll be all set to issue payment tomorrow!

parasharrajat · 2023-06-27T20:55:53Z

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:#19390
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:https://github.com/Expensify/App/pull/19390/files#r1244341085
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required! it was a simple mistake and proper testing and code review should have caught it.
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #20118 (comment)

parasharrajat · 2023-06-27T20:55:59Z

Regression Test Steps

Login with any account
Open an announce workspace chat or a group chat
Split bill among members.
Click on the split bill preview to see the details.
Verify that the payee user in detail split bill page displays with the current avatar and display name.
Change the avatar of the login user.
Go back to the preview of the split bill following steps 2 & 4.
Verify that the payee avatar is changed.

Verify that no errors appear in the JS console

Do you agree 👍 or 👎 ?

parasharrajat · 2023-06-27T21:00:12Z

@joekaufmanexpensify Please hold my payment for now. I will ping you soon with further details.

joekaufmanexpensify · 2023-06-27T21:20:05Z

Sounds good, thanks! I will create the regression test issue tomorrow.

flodnv · 2023-06-28T18:09:26Z

I think the regression test sounds good as long as QA agrees it's not too niche... 👍

joekaufmanexpensify · 2023-06-28T19:42:56Z

Sounds good. Added regression test issue above. BZ checklist is now complete!

joekaufmanexpensify · 2023-06-28T19:44:04Z

All set to issue payment here! @parasharrajat I know your payment is held right now, but going to issue the others.

joekaufmanexpensify · 2023-06-28T19:46:17Z

@dukenv0307 $1,000 sent and contract ended!

joekaufmanexpensify · 2023-06-28T19:47:20Z

@avi-shek-jha $250 sent and contract ended!

joekaufmanexpensify · 2023-06-28T19:49:00Z

Leaving this open until we are all set to pay @parasharrajat

joekaufmanexpensify · 2023-06-30T17:28:03Z

Held pending being able to pay rajat.

joekaufmanexpensify · 2023-07-03T13:13:16Z

Not overdue. Pending being able to issue payment here.

joekaufmanexpensify · 2023-07-05T12:53:06Z

Payment to rajat still on hold. Bumped in Slack.

parasharrajat · 2023-07-05T12:59:27Z

@joekaufmanexpensify It will be better to make this weekly.

joekaufmanexpensify · 2023-07-10T14:03:29Z

Still on hold

joekaufmanexpensify · 2023-07-17T13:13:57Z

Bumped in Slack

joekaufmanexpensify · 2023-07-24T13:51:03Z

Checking in on whether we are all set to pay this.

joekaufmanexpensify · 2023-07-31T13:58:24Z

Bumped in Slack.

parasharrajat · 2023-08-01T08:51:32Z

Payment requested. Ref: #20118 (comment)

joekaufmanexpensify · 2023-08-02T19:31:17Z

Thanks! Copying the payment summary message here. No speed bonus here, so these are the relevant payments:

@dukenv0307 - $1,000 (PR). Paid via upwork.
@parasharrajat - $1,000 (C+ review). Pending payment via NewDot.
@avi-shek-jha - $250 (Reporting). Paid via Upwork.

joekaufmanexpensify · 2023-08-02T19:34:22Z

Closing for now, since all that's left is NewDot payment (which has been requested)!

JmillsExpensify · 2023-08-02T23:48:46Z

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 3, 2023

melvin-bot bot assigned joekaufmanexpensify Jun 3, 2023

melvin-bot bot added the Overdue label Jun 5, 2023

melvin-bot bot removed the Overdue label Jun 5, 2023

joekaufmanexpensify added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Jun 5, 2023

melvin-bot bot changed the title ~~Web - Split Bill - Profile picture still shows avatar on a new split money page~~ [$1000] Web - Split Bill - Profile picture still shows avatar on a new split money page Jun 5, 2023

melvin-bot bot assigned parasharrajat Jun 5, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 5, 2023

melvin-bot bot assigned flodnv Jun 5, 2023

melvin-bot bot added the Overdue label Jun 12, 2023

melvin-bot bot added the Daily KSv2 label Jun 27, 2023

parasharrajat mentioned this issue Jun 27, 2023

Build read-only bill split details page #19390

Merged

55 tasks

melvin-bot bot added the Overdue label Jul 3, 2023

melvin-bot bot removed the Overdue label Jul 3, 2023

joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Jul 5, 2023

joekaufmanexpensify closed this as completed Aug 2, 2023

[HOLD for payment 2023-06-28] [$1000] Web - Split Bill - Profile picture still shows avatar on a new split money page #20118

[HOLD for payment 2023-06-28] [$1000] Web - Split Bill - Profile picture still shows avatar on a new split money page #20118

Comments

kbecciv commented Jun 3, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 3, 2023

melvin-bot bot commented Jun 3, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

dukenv0307 commented Jun 3, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

GItGudRatio commented Jun 3, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

joekaufmanexpensify commented Jun 5, 2023 • edited Loading

joekaufmanexpensify commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023

parasharrajat commented Jun 6, 2023

joekaufmanexpensify commented Jun 6, 2023

joekaufmanexpensify commented Jun 7, 2023

joekaufmanexpensify commented Jun 8, 2023

parasharrajat commented Jun 9, 2023 • edited Loading

bernhardoj commented Jun 11, 2023

parasharrajat commented Jun 12, 2023 • edited Loading

joekaufmanexpensify commented Jun 27, 2023

parasharrajat commented Jun 27, 2023 • edited Loading

parasharrajat commented Jun 27, 2023 • edited Loading

Regression Test Steps

parasharrajat commented Jun 27, 2023

joekaufmanexpensify commented Jun 27, 2023

flodnv commented Jun 28, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 30, 2023

joekaufmanexpensify commented Jul 3, 2023

joekaufmanexpensify commented Jul 5, 2023

parasharrajat commented Jul 5, 2023

joekaufmanexpensify commented Jul 10, 2023

joekaufmanexpensify commented Jul 17, 2023

joekaufmanexpensify commented Jul 24, 2023

joekaufmanexpensify commented Jul 31, 2023

parasharrajat commented Aug 1, 2023

joekaufmanexpensify commented Aug 2, 2023

joekaufmanexpensify commented Aug 2, 2023

JmillsExpensify commented Aug 2, 2023

kbecciv commented Jun 3, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 3, 2023 •

edited by joekaufmanexpensify

Loading

dukenv0307 commented Jun 3, 2023 •

edited

Loading

GItGudRatio commented Jun 3, 2023 •

edited

Loading

joekaufmanexpensify commented Jun 5, 2023 •

edited

Loading

parasharrajat commented Jun 9, 2023 •

edited

Loading

parasharrajat commented Jun 12, 2023 •

edited

Loading

parasharrajat commented Jun 27, 2023 •

edited

Loading

parasharrajat commented Jun 27, 2023 •

edited

Loading