Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-17] Selection List Refactor: Radio Button List #20352

Closed
thiagobrez opened this issue Jun 7, 2023 · 12 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@thiagobrez
Copy link
Contributor

This issue keeps track of Phase 1 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:

  • Phase 1: Radio Button List (this phase)
  • Phase 2: Checkbox List
  • Phase 3: Simple Selection List

Thoroughly discussed in the parent issue: #11795 (comment)

@thiagobrez
Copy link
Contributor Author

Update: still on Step 1

Step 1: Create a new, clean component for the Radio Button List, keeping the old one untouched

@cristipaval
Copy link
Contributor

Thanks for the update!

@thiagobrez
Copy link
Contributor Author

Left an update in the umbrella issue:

Working on #20352. Got a clean component working with all previous features for one use-case (Timezone selection). Now, for the other use-cases it should be simpler as the base is done, and I might just need to add a few extra props for customisation. Then, I'll create a few Storybook stories to leave it well documented.

@thiagobrez
Copy link
Contributor Author

Finishing clean-up. Will send a PR tomorrow

@thiagobrez
Copy link
Contributor Author

PR ready to review here: #21048

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 20, 2023
@thiagobrez
Copy link
Contributor Author

Weekly update: PR waiting for review

@thiagobrez
Copy link
Contributor Author

Weekly update: PR is being reviewed, appears to be close to approval

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2023
@melvin-bot melvin-bot bot changed the title Selection List Refactor: Radio Button List [HOLD for payment 2023-07-17] Selection List Refactor: Radio Button List Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

@cristipaval, @thiagobrez, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Santhosh-Sellavel
Copy link
Collaborator

@twisterdotcom Actually payment should have been got here, we mixed up on the parent issue and got it there.

#11795 (comment)

We are good to close this one out, thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2023
@twisterdotcom
Copy link
Contributor

Oh weird, yes this is kind of a dupe. Okay, we can close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants