Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] Web - Sign up - Display name and avatar image does not update automatically #20399

Closed
1 of 6 tasks
kbecciv opened this issue Jun 7, 2023 · 57 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Jun 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign up with new account
  2. Check display name and avatar image
  3. Refresh

Expected Result:

Display name and avatar image updated automatically with Clearbit when sign up

Actual Result:

Display name and avatar image does not update automatically with Clearbit when sign up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome
  • MacOS / Desktop

Version Number: 1.3.21-2

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (55)

image (54)

Expensify/Expensify Issue URL:

Issue reported by: David Barrett

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685567574364299

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01686e8a575bb277c8
  • Upwork Job ID: 1671569692603797504
  • Last Price Increase: 2023-06-30
@kbecciv kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mallenexpensify
Copy link
Contributor

Unable to reproduce, @kbecciv were you able to test? If so, were you able to reproduce?

At signup
image

Refresh after 5-10 seconds
image

@melvin-bot melvin-bot bot added the Overdue label Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

@kbecciv , can you see if you're able to reproduce, I was not able to

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2023
@kbecciv
Copy link
Author

kbecciv commented Jun 15, 2023

I have never used Clearbit before, but if you guide me, happy to try.

@mallenexpensify
Copy link
Contributor

@kbecciv ah... automatically with Clearbit when sign up is a bit confusing, what it means is - we work with a company that pulls in avatars from user's social networks. So, my popsicle avatar is from my twitter account that's associated with my email.

Can you test by using an email that associated with a twitter account that has a custom avatar?

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

@mallenexpensify, @kbecciv Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2023
@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 21, 2023
@melvin-bot melvin-bot bot changed the title Web - Sign up - Display name and avatar image does not update automatically [$1000] Web - Sign up - Display name and avatar image does not update automatically Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01686e8a575bb277c8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@mallenexpensify
Copy link
Contributor

Tested again and was able to reproduce

2023-06-21_10-18-57.mp4

@mallenexpensify mallenexpensify removed the Needs Reproduction Reproducible steps needed label Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

@mallenexpensify @mollfpr @kbecciv this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@ygshbht
Copy link
Contributor

ygshbht commented Jun 21, 2023

Proposal

Hello Expensify Team,

I'm Yogesh, a seasoned web developer eager to get my hands dirty solving your "Sign up - Display name and avatar image does not update automatically" issue. I understand that it's been up for grabs for a couple of weeks now – but rest assured, when I'm on the task, you won't be kept waiting.

Based on the provided details, it seems the hitch is in the display name and avatar image not updating right after sign-up. A plausible starting point could be to direct the new display name and avatar image to draw from the same data source that is accurately updating post-refresh. Yet, this initial analysis only scratches the surface. A precise, fail-proof solution can only be determined once I've delved deep into your existing codebase and unraveled its architecture.

Over the years, I've accumulated a wealth of experience in web development, which is reflected in my 100% job success rate on Upwork. You're welcome to verify this yourself on my profile: https://www.upwork.com/freelancers/~01ca41cc1d47038084. For a more comprehensive look at the diverse array of projects I've undertaken, head over to my portfolio at yogeshbhatt.com.

Let's turn this issue into a non-issue. Looking forward to contributing to Expensify.

Best,
Yogesh

@mollfpr
Copy link
Contributor

mollfpr commented Jun 22, 2023

@ygshbht Thank you for your interest in contributing here. We have a template for proposing a solution that you can find in the CONTRIBUTING.md.

@ygshbht
Copy link
Contributor

ygshbht commented Jun 22, 2023

@mollfpr Thank you for pointing that out. As I'm relatively new here, your guidance is much appreciated!

Proposal

Please re-state the problem that we are trying to solve in this issue.

After a new user signs up, the display name and avatar image are not automatically updated via Clearbit.

What is the root cause of that problem?

It's possible that the application isn't correctly or promptly fetching the updated data from Clearbit post sign-up, or there may be a delay or error in the rendering process.

What changes do you think we should make in order to solve the problem?

The ideal solution would be to ensure synchronization between the Clearbit data fetch and the UI update mechanism. If this issue resides in the frontend, we might need to restructure the way data is rendered or refresh the display post the Clearbit update. Alternatively, if the problem stems from the backend, we might need to examine how and when data is fetched from Clearbit.

@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@rfwoolf
Copy link

rfwoolf commented Jul 8, 2023

Contributor details Your Expensify account email: rfwoolf@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01488b1374506aa570

Please can someone invite me to the slack channels.

I have created a test environment on Windows, but I am stuck here: My browser loads the page with url localhost:8080 and displays a logo (see below). Is that correct? How is this a test environment - how do I interact with it or log in? image

Hi all
I'd be grateful if someone could please help me with this.

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@rfwoolf
Copy link

rfwoolf commented Jul 8, 2023

Contributor details
Your Expensify account email: rfwoolf@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01488b1374506aa570

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@mollfpr
Copy link
Contributor

mollfpr commented Jul 9, 2023

Please can someone invite me to the slack channels.

@rfwoolf Have you send email to contributors@expensify.com with the subject Slack Channel Invites?

My browser loads the page with url localhost:8080 and displays a logo (see below).

I'm not sure what is happening, but usually, I try to clear the storage or use incognito mode.

@melvin-bot melvin-bot bot removed the Overdue label Jul 9, 2023
@rfwoolf
Copy link

rfwoolf commented Jul 9, 2023

"@rfwoolf Have you send email to contributors@expensify.com with the subject Slack Channel Invites?"
Yes, I've done so 2-3 times with no response:
image

"I'm not sure what is happening, but usually, I try to clear the storage or use incognito mode."
Thanks! I've tried multiple browsers but no luck. It'd be helpful to see even just 1 example, so I know exactly what to try replicate.

@mollfpr
Copy link
Contributor

mollfpr commented Jul 10, 2023

@rfwoolf Is there any error in your console log? Or is that also happen with staging or production sites?

I think @mallenexpensify can help you with the invitation.

@mallenexpensify
Copy link
Contributor

@rfwoolf it looks like you were invited to the Slack channels, comment if not and I'll try to do it

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mallenexpensify
Copy link
Contributor

I think this issue falls into the 'update dynamically' category but I can't say with certainty. The avatar eventually updates, it just doesn't do it immediately, with no other actions taken. Removed and readded the Engineering label to get more eyes here. @johnmlee101 , thoughts here?

Two resources...

  1. Slack chat about 'dynamically update' where we plan to treat those as feature requests is here
  2. Tracking issue for 'dynamically updated' in case we want to add this to that.

@rfwoolf
Copy link

rfwoolf commented Jul 12, 2023

I think @mallenexpensify can help you with the invitation.
@mallenexpensify - I have now been invited to slack. Many thanks :)

I have also managed to compile successfully :)

@melvin-bot melvin-bot bot added the Overdue label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

@johnmlee101, @mallenexpensify, @mollfpr, @kbecciv Huh... This is 4 days overdue. Who can take care of this?

@mallenexpensify
Copy link
Contributor

@johnmlee101 👀 above plz
#20399 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@johnmlee101
Copy link
Contributor

Yeah I agree, its a very dynamic thing. It's a bedrock job in the background, so ultimately you're up to a bit of variability on whether you see this happen soon or later. I think in most instances it will be a bit slower since our Clearbit implementation isn't instant, and we shouldn't also block the app on it or show a loading indicator since it might not even populate with anything.

I don't think its a bug, but rather something that if our implementation was different we could improve.

@mallenexpensify
Copy link
Contributor

@quinthar can you review John's comment above? We're likely to close this issue and you raised it as a bug. I would add to the Dynamic updating tracking issue we have too, in case we ever want to holistically address it.

@mallenexpensify
Copy link
Contributor

Added to the tracking list, closing. Reopen/comment if you disagree

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

@johnmlee101 @mallenexpensify Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

8 participants