-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$2000] Web - Sign up - Display name and avatar image does not update automatically #20399
Comments
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Unable to reproduce, @kbecciv were you able to test? If so, were you able to reproduce? |
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@kbecciv , can you see if you're able to reproduce, I was not able to |
I have never used Clearbit before, but if you guide me, happy to try. |
@kbecciv ah... Can you test by using an email that associated with a twitter account that has a custom avatar? |
@mallenexpensify, @kbecciv Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Job added to Upwork: https://www.upwork.com/jobs/~01686e8a575bb277c8 |
Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Tested again and was able to reproduce 2023-06-21_10-18-57.mp4 |
@mallenexpensify @mollfpr @kbecciv this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
ProposalHello Expensify Team, I'm Yogesh, a seasoned web developer eager to get my hands dirty solving your "Sign up - Display name and avatar image does not update automatically" issue. I understand that it's been up for grabs for a couple of weeks now – but rest assured, when I'm on the task, you won't be kept waiting. Based on the provided details, it seems the hitch is in the display name and avatar image not updating right after sign-up. A plausible starting point could be to direct the new display name and avatar image to draw from the same data source that is accurately updating post-refresh. Yet, this initial analysis only scratches the surface. A precise, fail-proof solution can only be determined once I've delved deep into your existing codebase and unraveled its architecture. Over the years, I've accumulated a wealth of experience in web development, which is reflected in my 100% job success rate on Upwork. You're welcome to verify this yourself on my profile: https://www.upwork.com/freelancers/~01ca41cc1d47038084. For a more comprehensive look at the diverse array of projects I've undertaken, head over to my portfolio at yogeshbhatt.com. Let's turn this issue into a non-issue. Looking forward to contributing to Expensify. Best, |
@ygshbht Thank you for your interest in contributing here. We have a template for proposing a solution that you can find in the CONTRIBUTING.md. |
@mollfpr Thank you for pointing that out. As I'm relatively new here, your guidance is much appreciated! ProposalPlease re-state the problem that we are trying to solve in this issue.After a new user signs up, the display name and avatar image are not automatically updated via Clearbit. What is the root cause of that problem?It's possible that the application isn't correctly or promptly fetching the updated data from Clearbit post sign-up, or there may be a delay or error in the rendering process. What changes do you think we should make in order to solve the problem?The ideal solution would be to ensure synchronization between the Clearbit data fetch and the UI update mechanism. If this issue resides in the frontend, we might need to restructure the way data is rendered or refresh the display post the Clearbit update. Alternatively, if the problem stems from the backend, we might need to examine how and when data is fetched from Clearbit. |
Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new. |
Hi all |
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@rfwoolf Have you send email to contributors@expensify.com with the subject Slack Channel Invites?
I'm not sure what is happening, but usually, I try to clear the storage or use incognito mode. |
|
@rfwoolf Is there any error in your console log? Or is that also happen with staging or production sites? I think @mallenexpensify can help you with the invitation. |
@rfwoolf it looks like you were invited to the Slack channels, comment if not and I'll try to do it |
Triggered auto assignment to @johnmlee101 ( |
I think this issue falls into the 'update dynamically' category but I can't say with certainty. The avatar eventually updates, it just doesn't do it immediately, with no other actions taken. Removed and readded the Two resources...
|
I have also managed to compile successfully :) |
@johnmlee101, @mallenexpensify, @mollfpr, @kbecciv Huh... This is 4 days overdue. Who can take care of this? |
@johnmlee101 👀 above plz |
Yeah I agree, its a very dynamic thing. It's a bedrock job in the background, so ultimately you're up to a bit of variability on whether you see this happen soon or later. I think in most instances it will be a bit slower since our Clearbit implementation isn't instant, and we shouldn't also block the app on it or show a loading indicator since it might not even populate with anything. I don't think its a bug, but rather something that if our implementation was different we could improve. |
@quinthar can you review John's comment above? We're likely to close this issue and you raised it as a bug. I would add to the Dynamic updating tracking issue we have too, in case we ever want to holistically address it. |
Added to the tracking list, closing. Reopen/comment if you disagree |
@johnmlee101 @mallenexpensify Be sure to fill out the Contact List! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Display name and avatar image updated automatically with Clearbit when sign up
Actual Result:
Display name and avatar image does not update automatically with Clearbit when sign up
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.21-2
Reproducible in staging?: Yes
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: David Barrett
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685567574364299
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: