[HOLD for payment 2023-06-21] [Regression] Web - Task -User is not able to remove the description

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on + button
2. Click on Assign task
3. Enter title and description
4. Press next button
5. Click on Assignee and select any assignee
6. Click on confirm task button
7. Go to task thread
8. Click on description
9. Remove description and click on save button

Expected Result:

Should remove description because it is optional

Actual Result:

User is not able to remove the description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.3032.mp4

Screen.Recording.2023-06-06.at.12.30.49.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686034899013369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d991a6eac7b405e1
• Upwork Job ID: 1668428386254053376
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[honnamkuan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user attempt to update Task description to empty, the description is reverted back to the previous value before edit.

What is the root cause of that problem?

Referring to

App/src/libs/actions/Task.js

Lines 364 to 369 in 3bccc71

	API.write(
	'EditTask',
	{
	taskReportID: report.reportID,
	title: reportName,
	description: (description || report.description).trim(),

When EditTask API was called, it send the new description only when it is defined and truthy, otherwise the || operator will causes it fallback to the old report.description. That is what happens when we try to update a task with existing non-empty description to an empty description

What changes do you think we should make in order to solve the problem?

We can fix this behaviour by updating the line 369 in above so that it does not fallback to report.description
like so:

description: description.trim(),

In additional to that, we also need to make sure code calling TaskUtils.editTaskAndNavigate(..) are populating the description correctly instead of populating empty and relying on the function to take existing description value. We achieve that by passing in props.task.report.description into the description parameter at the following files:

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 186 in 82ce35f

TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, '', '', option.login);

App/src/pages/tasks/TaskTitlePage.js

Line 62 in 82ce35f

TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, values.title, '', '');

[thienlnam]

I believe this is a regression from a recently merged PR - going to see if I can find it

[dukenv0307]

@thienlnam #19990 my mistake in this PR when I merged main make a regression that is this issue

[thienlnam]

Ah yup that's the one - thanks
Assigning you and fedirjh to handle this regression

[dukenv0307]

@thienlnam @fedirjh The PR is ready to review

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d991a6eac7b405e1

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix user cannot remove the description #20544

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

@dukenv0307 please apply to the upwork job. @fedirjh waiting on your to accept the offer and finish the steps above ^. Thanks!

[thienlnam]

This is a regression - no payments are due here @kevinksullivan except for reporter

[fedirjh]

@thienlnam I am not the C+ on the linked PR that caused the regression.

@kevinksullivan there should be no payment for this issue except reporter.

[kevinksullivan]

Sorry for the confusion everyone. Taking down the job post now.

[melvin-bot]

@kevinksullivan, @thienlnam, @fedirjh, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

Paid @gadhiyamanan , closing out