Fix user cannot remove the description #20544

dukenv0307 · 2023-06-09T19:01:55Z

Details

Fixed Issues

$ #20539
PROPOSAL: #19089 (comment)

Tests

Click on + button
Click on Assign task
Enter title and description
Press next button
Click on Assignee and select any assignee
Click on confirm task button
Go to task thread
Click on description
Remove description and click on save button
Verify that description is removed as well

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on + button
Click on Assign task
Enter title and description
Press next button
Click on Assignee and select any assignee
Click on confirm task button
Go to task thread
Click on description
Remove description and click on save button
Verify that description is removed as well

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.10-06-2023.02.05.34.webm

Mobile Web - Chrome

Record_2023-06-10-02-07-56.mp4

Mobile Web - Safari

original-EF746622-3C28-4A1D-91DF-C881519002E9.mp4

Desktop

Screen.Recording.2023-06-10.at.02.14.12.mov

iOS

Screen.Recording.2023-06-10.at.02.21.00.mov

Android

untitled.webm

melvin-bot · 2023-06-09T19:22:55Z

@thienlnam @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-06-09T19:40:55Z

@dukenv0307 Let's fix the other issue when we update the title , the description got removed.

dukenv0307 · 2023-06-09T19:56:56Z

@fedirjh I updated

fedirjh · 2023-06-09T20:19:21Z

@dukenv0307 I have another suggestion: we can encapsulate the edited task properties in one object and then use partial object filling.

/**
 * @function editTask
 * @param {object} report
 * @param {string} ownerEmail
 * @param {{title?: string, description?: string, assignee?:string}} editedTask
 * @returns {object} action
 *
 */

function editTaskAndNavigate(report, ownerEmail, {title, description, assignee}) {

Then we can use it like

TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, {title: values.title});
TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, {assignee: option.login});
TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, {description: values.description});

dukenv0307 · 2023-06-10T02:58:45Z

@dukenv0307 I have another suggestion: we can encapsulate the edited task properties in one object and then use partial object filling.

@fedirjh I think we don't need to change as this suggestion. For example, if we edit title, we still need to pass the correct description in editTask object to avoid this regression

@dukenv0307 Let's fix the other issue when we update the title , the description got removed.

fedirjh · 2023-06-10T09:07:58Z

For example, if we edit title, we still need to pass the correct description in editTask object to avoid this regression

I don't agree with that , we should update the editTask to check whenever any prop (title, description or assignee) is provided if not we just pass the task props

// for title
title || report.reportName

// for description 
description || report.description

// for assignee
assignee || report.managerEmail

dukenv0307 · 2023-06-10T09:18:15Z

@fedirjh Thanks, I got it. That makes sense.

dukenv0307 · 2023-06-10T09:49:50Z

@fedirjh The case remove description doesn't work with this #20544 (comment)

fedirjh · 2023-06-10T09:54:53Z

The case remove description doesn't work with this #20544 (comment)

@dukenv0307 what is the issue ?

dukenv0307 · 2023-06-10T09:56:19Z

@fedirjh With this suggestion above, we still cannot remove description

fedirjh · 2023-06-10T10:00:17Z

@dukenv0307 I am not sure I am following you , can you please explain more ?

dukenv0307 · 2023-06-10T10:04:23Z

@fedirjh To check description is provided or not we should checck it is undefined or not instead this code here because when we update description to empty description || report,description is old description

// for title
title || report.reportName

// for description 
description || report.description

// for assignee
assignee || report.managerEmail

dukenv0307 · 2023-06-10T10:12:42Z

@fedirjh I updated with your suggestion and also updated check for the description to work well

fedirjh · 2023-06-10T10:27:20Z

src/libs/actions/Task.js

@@ -313,7 +311,7 @@ function editTaskAndNavigate(report, ownerEmail, title, description, assignee) {
            key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
            value: {
                reportName,
-                description: description.trim(),
+                description: (description !== undefined ? description : report.description).trim(),


This can be extracted at top similar to reportName , we can use !_.isUndefined(description) as well.

@fedirjh I think reportName and assignee don't need to check because, title cannot be empty and assignee cannot remove after assign for a user

fedirjh · 2023-06-10T10:45:18Z

src/libs/actions/Task.js

@@ -311,7 +312,7 @@ function editTaskAndNavigate(report, ownerEmail, {title, description, assignee})
            key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
            value: {
                reportName,
-                description: (description !== undefined ? description : report.description).trim(),
+                description: (!_.isUndefined(description) ? description : report.description).trim(),


@dukenv0307 Can we follow DRY code here , should be extracted at the top below line 292

@fedirjh I updated.

fedirjh · 2023-06-12T01:05:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

WEB.mov

Mobile Web - Chrome

Chrome.mov

Mobile Web - Safari

Safari.mp4

Desktop

Desktop.mov

iOS

IOS.mp4

Android

Android.mov

fedirjh

Looks good and tests well

cc @thienlnam

OSBotify · 2023-06-12T16:35:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-13T00:31:45Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T01:05:56Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-14T21:22:03Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix user cannot remove the description

6971a3b

dukenv0307 marked this pull request as ready for review June 9, 2023 19:22

dukenv0307 requested a review from a team as a code owner June 9, 2023 19:22

melvin-bot bot requested review from fedirjh and thienlnam and removed request for a team June 9, 2023 19:22

fix description is remove when editing title

aa8b3aa

optimize edit task function

fe045de

fedirjh reviewed Jun 10, 2023

View reviewed changes

dukenv0307 added 2 commits June 10, 2023 17:37

clear condition

3e36a6c

fix lint

a8dbdfe

fedirjh reviewed Jun 10, 2023

View reviewed changes

optimize description

a1726d5

fedirjh approved these changes Jun 12, 2023

View reviewed changes

thienlnam approved these changes Jun 12, 2023

View reviewed changes

thienlnam merged commit 99e184c into Expensify:main Jun 12, 2023

OSBotify mentioned this pull request Jun 12, 2023

Deploy Checklist: New Expensify 2023-06-12 #20640

Closed

71 tasks

melvin-bot bot mentioned this pull request Jun 14, 2023

[HOLD for payment 2023-06-21] [Regression] Web - Task -User is not able to remove the description #20539

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix user cannot remove the description #20544

Fix user cannot remove the description #20544

dukenv0307 commented Jun 9, 2023 •

edited

Loading

melvin-bot bot commented Jun 9, 2023

fedirjh commented Jun 9, 2023

dukenv0307 commented Jun 9, 2023

fedirjh commented Jun 9, 2023

dukenv0307 commented Jun 10, 2023

fedirjh commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023

fedirjh commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023

fedirjh commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023 •

edited

Loading

dukenv0307 commented Jun 10, 2023 •

edited

Loading

fedirjh Jun 10, 2023

dukenv0307 Jun 10, 2023

fedirjh Jun 10, 2023

dukenv0307 Jun 10, 2023

fedirjh commented Jun 12, 2023

fedirjh left a comment

OSBotify commented Jun 12, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 14, 2023

Fix user cannot remove the description #20544

Fix user cannot remove the description #20544

Conversation

dukenv0307 commented Jun 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 9, 2023

fedirjh commented Jun 9, 2023

dukenv0307 commented Jun 9, 2023

fedirjh commented Jun 9, 2023

dukenv0307 commented Jun 10, 2023

fedirjh commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023

fedirjh commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023

fedirjh commented Jun 10, 2023

dukenv0307 commented Jun 10, 2023 • edited Loading

dukenv0307 commented Jun 10, 2023 • edited Loading

fedirjh Jun 10, 2023

Choose a reason for hiding this comment

dukenv0307 Jun 10, 2023

Choose a reason for hiding this comment

fedirjh Jun 10, 2023

Choose a reason for hiding this comment

dukenv0307 Jun 10, 2023

Choose a reason for hiding this comment

fedirjh commented Jun 12, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 12, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 14, 2023

dukenv0307 commented Jun 9, 2023 •

edited

Loading

dukenv0307 commented Jun 10, 2023 •

edited

Loading

dukenv0307 commented Jun 10, 2023 •

edited

Loading