Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-03] [HOLD for payment] [$250] [Accessible Pressables] Migrate PressableWithDelayToggle #20601

Closed
roryabraham opened this issue Jun 12, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jun 12, 2023

Migrate PressableWithDelayToggle to use new Pressables

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017e3dfcea2e115797
  • Upwork Job ID: 1668308032502738944
  • Last Price Increase: 2023-06-12
@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor Engineering Weekly KSv2 NewFeature Something to build that is a new item. labels Jun 12, 2023
@roryabraham roryabraham self-assigned this Jun 12, 2023
@melvin-bot melvin-bot bot changed the title [Accessible Pressables] Migrate PressableWithDelayToggle [$1000] [Accessible Pressables] Migrate PressableWithDelayToggle Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017e3dfcea2e115797

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Current assignee @roryabraham is eligible for the External assigner, not assigning anyone new.

@roryabraham roryabraham changed the title [$1000] [Accessible Pressables] Migrate PressableWithDelayToggle [$250] [Accessible Pressables] Migrate PressableWithDelayToggle Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Upwork job price has been updated to $250

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2023
@syedsaroshfarrukhdot
Copy link
Contributor

Can i help in migration ?

@kuluruvineeth
Copy link

Could you please assign me this task, I would love to work on it.

@robertKozik
Copy link
Contributor

Hi! As an expert contributor from Software Mansion I'd like to get this issue, can you assign me to this one?
CC. @roryabraham

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

📣 @robertKozik You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added the Overdue label Jun 14, 2023
@roryabraham
Copy link
Contributor Author

Looks like @robertKozik put up a draft PR yesterday

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Jun 14, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

@sonialiap, @roryabraham, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @robertKozik got assigned: 2023-06-12 22:25:09 Z
  • when the PR got merged: 2023-06-22 20:32:28 UTC
  • days elapsed: 8

On to the next one 🚀

@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

📣 @aimane-chnaif You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham
Copy link
Contributor Author

@sonialiap The only payment due here is $250 to @aimane-chnaif

@sonialiap
Copy link
Contributor

@aimane-chnaif offer sent

@sonialiap sonialiap changed the title [$250] [Accessible Pressables] Migrate PressableWithDelayToggle [HOLD for payment] [$250] [Accessible Pressables] Migrate PressableWithDelayToggle Jun 23, 2023
@sonialiap
Copy link
Contributor

Paid ✅

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 23, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 26, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment] [$250] [Accessible Pressables] Migrate PressableWithDelayToggle [HOLD for payment 2023-07-03] [HOLD for payment] [$250] [Accessible Pressables] Migrate PressableWithDelayToggle Jun 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants