Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Login- Continue button is not clickable after login with link and logout #20710

Closed
4 of 6 tasks
kbecciv opened this issue Jun 13, 2023 · 17 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Jun 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #19498

Action Performed:

  1. Open NewDot on mWeb (Chrome/Android)
  2. Login to any account using magic link (not code)
  3. Logout
  4. Input any email and click continue

Expected Result:

Continue button should be clickable

Actual Result:

Continue button is not clickable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.27.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6091711_video_35.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - interna Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01730de90b9047f66a
  • Upwork Job ID: 1678859166743351296
  • Last Price Increase: 2023-07-11
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Christinadobrzyn
Copy link
Contributor

asking if this should be separate - #16301 (comment)

@Christinadobrzyn
Copy link
Contributor

I think this is going to be fixed in the reverted PR here - #16301 (comment)

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Jun 17, 2023
@Christinadobrzyn
Copy link
Contributor

following - #16301 (comment)

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

@Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 27, 2023
@Christinadobrzyn
Copy link
Contributor

Tracking - #16301 (comment)

1 similar comment
@Christinadobrzyn
Copy link
Contributor

Tracking - #16301 (comment)

@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2023
@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Jul 3, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2023
@Christinadobrzyn
Copy link
Contributor

asking for an update - #16301 (comment)

@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2023

@Christinadobrzyn this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Engineering Daily KSv2 and removed Weekly KSv2 labels Jul 4, 2023
@Christinadobrzyn
Copy link
Contributor

following the PR here - #16301 (comment)

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Jul 5, 2023
@Christinadobrzyn
Copy link
Contributor

Following PR here - #20708

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

@Christinadobrzyn this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01730de90b9047f66a

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

@abdulrahuman5196
Copy link
Contributor

@Christinadobrzyn Could you provide information on what this issue is? Only C+ is assigned to internal issue?

@Christinadobrzyn
Copy link
Contributor

The internal label was auto-added because this issue is 4 weeks old. I was following this #20708 which just went into production and in my testing, it resolved the issue.

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants