[HOLD for payment 2023-07-17] [$1000] mWeb - Emoji modal stops working in the chat if the user opens it in the IOU report.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Opened mWeb.
2. Navigated to the chat.
3. Sent money and accessed the IOU report page.
4. Opened the emoji modal
5. Click Back to return to the chat.
6. Tried opening the emoji box.

Expected Result:

The emoji modal should open in the chat compose box.

Actual Result:

The emoji modal doesn't open in the chat compose box.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.3

Reproducible in staging?: y

**Reproducible in production?:**y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-13.at.1.41.34.PM.1.mov

mWeb.repro.emodji.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Tushu17

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686644077744109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f59b5426989a9373
• Upwork Job ID: 1673469119557054464
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

This is on my test list

[payal-lathidadiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji modal stops working in the chat if the user opens it in the IOU report

What is the root cause of that problem?

emojiPickerRef is created as global ref instance here

This ref will be set when ReportScreen is mounted and will be set to null once ReportScreen is unmounted. In our case, the second chat is unmounted which will set the global ref to null.

What changes do you think we should make in order to solve the problem?

We can move EmojiPicker component from ReportScreen here to App here or Expensify component here, so that it won't loose state while re-rendering of report component.

What alternative solutions did you explore? (Optional)

None

[alexpensify]

I'm catching up from my half day, I'll review soon.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f59b5426989a9373

[melvin-bot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[alexpensify]

I've confirmed this is an issue and don't believe there is another GH related to it.

[alexpensify]

Still waiting for proposals here.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

Reassigning another bug team member, I'm going OOO until Monday, July 10, and will take it back if it's not closed by my return date.

Required action from the 🐛 team: Make sure the proposal process is moving forward, so we can get this one assigned out to fix. If no movement on the proposals by next week, then we may want to consider shopping for a reviewer.

[rushatgabhane]

We can move EmojiPicker component from ReportScreen here to App here or Expensify component here, so that it won't loose state while re-rendering of report component.

@payal-lathidadiya thank you for your proposal. Do you think it'll cause performance regressions?
Does the entire app re-render when emoji drawer is reopened?

[payal-lathidadiya]

Do you think it'll cause performance regressions? Does the entire app re-render when emoji drawer is reopened?

@rushatgabhane thanks for reviewing my proposal.

As investigated and tested, i didn't observe or notice any performance regressions with proposed update. And it won't impact app to cause re-render when emoji drawer is reopened.

In fact, I think this would be more optimised way of handling emoji picker instance global ref here, IMO.

FYI, we also have similar report action context menu global component ref defined in Expensify component here

[payal-lathidadiya]

PR is up for review

cc: @rushatgabhane @michaelhaxhiu

[alexpensify]

Alright, removing the other 🐛 team member. I'm back online and see that this is our current state:

Waiting for automation here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: emoji modal stops working in the chat when opening in the IOU report #22188

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

To prepare for payment: @Tushu17 can you please apply to the job? I don't think that automation accounted for you finding this 🐛. Thanks!

https://www.upwork.com/jobs/~01f59b5426989a9373

[Tushu17]

@alexpensify Okay, I've applied for the job.

[alexpensify]

I'll work on the payment process tomorrow.

[alexpensify]

@Tushu17 - I've prepared the payment in Upwork, please accept and I can complete the next steps

@payal-lathidadiya - I've sent the payment via Upwork

@rushatgabhane - please request payment in NewDot, thanks!

[Tushu17]

@alexpensify I've accepted the offer. Thank you!

[alexpensify]

Everyone has been paid here.

---

@rushatgabhane - When you get a chance, can you please complete the checklist:

#21101 (comment)

Thank you!

[alexpensify]

@rushatgabhane - I'm checking in to see if the checklist is ready and we can close this out. Thanks!

[alexpensify]

@anmurali - we are on hold for C+ payment and will give the 🟢 as soon as the checklist has been completed.

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Umm so this bug happened when we added threads. I can't point to a specific PR for that using git blame.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required

4. Determine if we should create a regression test for this bug. - No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Made a manual request here for $1.5K https://staging.new.expensify.com/r/2734383403522123

[alexpensify]

Thank you @rushatgabhane! @anmurali all set for payment here. I'm going to close this GH since all actions have been completed.

[JmillsExpensify]

@alexpensify Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @rushatgabhane's NewDot payments. More information on this compliance process in Slack.

[alexpensify]

Here is the payment summary:

• External issue reporter: @Tushu17 $250
• Contributor that fixed the issue: @payal-lathidadiya $1500
• Contributor+ that helped on the issue and/or PR: @rushatgabhane $1500

Upwork Job:
https://www.upwork.com/jobs/~01f59b5426989a9373

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: All set here @JmillsExpensify! This one was pre-summary days. Everyone has been paid here except @rushatgabhane. Thank you!

[JmillsExpensify]

Reviewed details for @rushatgabhane. This is accurate based on summary from Business Reviewer and approved for payment in NewDot.