[HOLD for payment 2023-07-10] [$1000] Web - random QR code is generated on opening share code of room using URL

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From userA, click on + button and select New room option
2. Fill the details and click on create room option
3. Click on header of room report screen
4. Go to share code and copy the URL
5. From userB (who is not part of room), go to share code using URL ( https://new.expensify.com/r/5701471373675426 )

Expected Result:

Should show 'hmm it's not there...' as user is not part of room

Actual Result:

Users share code shows if user is logged in and if user is not logged in it shows random share code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-6

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-14.at.11.15.27.AM.1.mov

Recording.787.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686722986231259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018651b89a2a819106
• Upwork Job ID: 1673303498370383872
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

shows QR code screen for restricted room to non member while using direct url

What is the root cause of that problem?

In the shareCodePage we haven't used FullPageNotFoundView to restrict the user when the report is not available for them.

What changes do you think we should make in order to solve the problem?

Use FullPageNotFoundView component to wrap here which will show 'hmm it's not there...' page while accessing the invalid room for the user. We can also pass the prop shouldShowLink if we want to show Go back to home page link for the Not Found page.

App/src/pages/ShareCodePage.js

Lines 52 to 53 in 2a5aee6

	<ScreenWrapper>
	<HeaderWithBackButton

<ScreenWrapper>
      <FullPageNotFoundView shouldShow={!isReport}>
            <HeaderWithBackButton

Result

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

show users QR code on opening share code of restricted room using URL

What is the root cause of that problem?

We have a check isReport but we don't use it to display not found page if isReport is false.

What changes do you think we should make in order to solve the problem?

1. Subscrible isLoadingReportData from Onyx with key ONYXKEYS.IS_LOADING_REPORT_DATA
2. We could use FullPageNotFoundView component here to display not found page if the user cannot access the report that has reportID is provided from route.
   

   App/src/pages/ShareCodePage.js

   Line 53 in 342d4fd

   <HeaderWithBackButton

<FullPageNotFoundView shouldShow={!isLoadingReportData && !isReport} shouldShowLink>

shouldShow prop should be !isLoadingReportData && !isReport because when we open with the deep link before signing in we need to wait to report data loads completely to check isReport correctly.

And if isLoadingReportData is true we should display the loading screen to wait to report data loads completely.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Will handle first thing Monday

[muttmuure]

Looks like this one is fixed:

[gadhiyamanan]

@muttmuure still able to reproduce

Screen.Recording.2023-06-26.at.5.39.05.PM.mov

[muttmuure]

Updated the reproduction steps because they didn't explicitly mention copying the URL in step 4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018651b89a2a819106

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[sobitneupane]

shouldShow prop should be !isLoadingReportData && !isReport because when we open with the deep link before signing in we need to wait to report data loads completely to check isReport correctly.

And if isLoadingReportData is true we should display the loading screen to wait to report data loads completely.

@dukenv0307 Can you please explain a bit about the need of isLoadingReportData. If you can attach an example of the issue that can occur if we don't add isLoadingReportData, it will be very helpful.

[dukenv0307]

shouldShow prop should be !isLoadingReportData && !isReport because when we open with the deep link before signing in we need to wait to report data loads completely to check isReport correctly.

@sobitneupane If we don't use isLoadingReportData, there is an issue occurs when we open a shareCode page that is valid for current user by deep link before signing. Like this video below, not found page will display briefly because the report data doesn't load completely.

Screencast.from.28-06-2023.19.54.58.webm

And if isLoadingReportData is true we should display the loading screen to wait to report data loads completely.

And I think we should display loadingPage while report data is loading.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display not found page with invalid reportID in share code page #21824

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#18636

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#18636 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1688979049764729

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#21157 (comment)

[sobitneupane]

Regression Test Proposal

1. Login with user A
2. On another device, login with user B
3. From user B, open a room where user A isn't a member
4. Click on the header of the report
5. Go to share code and copy the URL
6. From user A, go to share code with the URL copied above
7. Verify that "Not Found Page" is displayed.

Do we agree 👍 or 👎

[sobitneupane]

Payment Requested on Expensify.

[muttmuure]

Looks like @sobitneupane has been paid.

@dukenv0307 I've invited you to apply to the Upwork job

[gadhiyamanan]

@muttmuure offer accepted, thanks!

[dukenv0307]

@muttmuure I applied, thank you!

[muttmuure]

@gadhiyamanan paid

@dukenv0307 offer sent

[dukenv0307]

@muttmuure I accepted, thank you!

[muttmuure]

@dukenv0307 paid

@sobitneupane invited

[melvin-bot]

@arosiclair, @sobitneupane, @muttmuure, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sobitneupane]

@muttmuure I already received payment through newDot.

[muttmuure]

OK, no worries!

[muttmuure]

@gadhiyamanan - $250.00 (paid in Upwork)

@dukenv0307 - $1,500.00 (paid in Upwork)

@sobitneupane - $1,500.00 (paid in Expensify)