[HOLD for payment 2023-07-10] [$1000] Web - Does not open site on click of name in URL preview

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send any website link
3. Click on name of site in preview to open open site as name shows as hyperlink

Expected Result:

It should open site on click of name

Actual Result:

Name shows as hyperlink but does not open site

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-6

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-14.at.12.51.15.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686727392348349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014222f9e922c403b3
• Upwork Job ID: 1671915466959015936
• Last Price Increase: 2023-06-22

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Does not open site on click of name in URL preview.

What is the root cause of that problem?

The root cause of this issue is that the title of URL preview is wrapped in Text, see

App/src/pages/home/report/LinkPreviewer.js

Lines 106 to 113 in b20f917

	<Text
	fontSize={variables.fontSizeNormal}
	style={styles.pv2}
	color={colors.blueLinkPreview}
	>
	{title}
	</Text>
	)}

Which is not link to the url.

What changes do you think we should make in order to solve the problem?

To fix this issue, we can use TextLink to wrap the title of link preview by changing

App/src/pages/home/report/LinkPreviewer.js

Lines 106 to 112 in b20f917

	<Text
	fontSize={variables.fontSizeNormal}
	style={styles.pv2}
	color={colors.blueLinkPreview}
	>
	{title}
	</Text>

to

<TextLink
    fontSize={variables.fontSizeNormal}
    style={styles.pv2}
    color={colors.blueLinkPreview}
    href={url}
>
    {title}
</TextLink>

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[twisterdotcom]

Asking if we need to make this external yet or not: https://expensify.slack.com/archives/C049HHMV9SM/p1687391276929729?thread_ts=1686727392.348349&cid=C049HHMV9SM

[twisterdotcom]

Okay, yes I can reproduce.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014222f9e922c403b3

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[nikhiln]

Proposal

---

Please re-state the problem that we are trying to solve in this issue.

The title in the link preview is not clickable

What is the root cause of that problem?

The title in the preview for the shared link is being rendered as a regular text instead of the link and so making it as non-clickable

https://github.com/Expensify/App/blob/main/src/pages/home/report/LinkPreviewer.js#L106

What changes do you think we should make in order to solve the problem?

Simply replace the usage of Text component with TextLink component. E.g.

<TextLink
    style={{...styles.link, ...styles.textUnderline, ...styles.pv2}}
    href={url}
    >
    {title}
</TextLink>

This would make sure to have same look and feel of the link as well.

What alternative solutions did you explore? (Optional)

None

[thesahindia]

@eh2077's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MariaHCD]

The proposal looks good to me too!

[MariaHCD]

Hmm, something went wrong with our GH webhook handler (internal logs)

[MariaHCD]

Oh, I see the problem. This issue has the Upwork Automation label which tries to auto hire the contributor here but the issue body is null here because it was unset here.

cc: @thienlnam

Going to remove that label so we can move forward here.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

I'm the second assignee while Ted is ooo. I'm leaving for Sabbatical today.
@mallenexpensify you're now the second assignee until Ted returns on July 04.

@twisterdotcom will be back in office when the payment date comes about.

---

CURRENT STATUS:

We'll be nearing the waiting period for payment soon.

• Issue reported by: @gadhiyamanan [$250]
• Assigned for Fix: @eh2077 [$1000] + [$500 PR Bonus] pending no regressions
• Assigned C+: @thesahindia [$1000] + [$500 PR Bonus] pending no regressions

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: clicking title of url preview don't open site #21717

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom / @mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Ted's back today so unassigning

[twisterdotcom]

Upwork offers sent to @gadhiyamanan and @eh2077.

@thesahindia are we paying you directly now?

[eh2077]

@twisterdotcom Accepted the offer, thanks!

[thesahindia]

@thesahindia are we paying you directly now?

Yes, I am going to try the new method.

[thesahindia]

We can skip the checklist because it was not a regression.

If we want we can add this test case -

1. Go to a chat and add a comment google.com
2. Wait for the URL preview to load
3. Click the blue title of URL preview and verify that it opens google.com

[gadhiyamanan]

@twisterdotcom offer accepted, thanks!

[twisterdotcom]

All paid out!

[eh2077]

Hi @twisterdotcom , sorry I haven’t been paid on Upwork.

[eh2077]

Friendly bump @twisterdotcom ^

[twisterdotcom]

Wow, Sorry for missing that. It's paid now.

[JmillsExpensify]

$1,500 payment approved for @thesahindia based on BZ summary.