[HOLD for payment 2023-08-14] [$1000] Add Tooltip for the report actions whose actor is the workspace

[cristipaval]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a workspace where you are a non-admin member
2. Request money from the workspace
3. Verify that you have the report preview where the actor is the workspace
4. Hover the workspace name on that report preview

Expected Result:

You should see a tooltip with the workspace avatar and name

Actual Result:

Nothing happens

Workaround:

No workaround

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a1fc3c444f423b4
• Upwork Job ID: 1675995747731927040
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[cristipaval]

Hey @jliexpensify, this is a follow-up issue after this PR. Don't try to reproduce this before the PR gets merged and deployed.

[abdulrahuman5196]

If required i can work on this issue as C+ in future since the original PR and this followup issue was found during the C+ review.

[cristipaval]

Yes, makes sense!

[jliexpensify]

Looks like the PR got deployed to Staging, so testing now.

[jliexpensify]

@cristipaval I'm confused by the instructions:

2. Request money from the workspace

How do you do this? I found this SO but on Staging v1.3.32-5, I can only request an IOU from an individual.

Is there a Beta I need to be added to?

3. Verify that you have the report preview where the actor is the workspace

What does "where the actor is the workspace" mean?

Thanks!

[cristipaval]

Hey @jliexpensify! The App PR which fixes this issue is already merged and deployed to staging. So you won't be able to reproduce the issue.

In order to understand the testing steps, it might help you to watch the screen recordings in the PR that fixes the issue, here.

[jliexpensify]

Had some additional questions, so reached out to Cristi via DM.

[cristipaval]

Screen.Recording.2023-06-29.at.16.23.26.mov

Hey @jliexpensify! This is how you request money from a workspace.

You can see that after requesting the money, you see in the chat the action "Workspace owes x money"

In this particular case, I am requesting money from the workspace where I am an admin, that's why I can also see the button to pay the money to myself on behalf of the workspace.

[jliexpensify]

Ok, turns out this was under a beta. Got myself added and now can test:

2023-07-03_15-23-15.mp4

[jliexpensify]

So I see the avatar and name, but this avatar is not correct right?

cc @abdulrahuman5196

[abdulrahuman5196]

@jliexpensify No that was not the issue this GH is made for. I have marked in the below image and add video.

Screen.Recording.2023-07-03.at.8.05.45.PM.mov

[jliexpensify]

Ok yeah, I can also see that - it would be nice to have a tooltip as we show one for individuals:

But is this also an issue? For consistency's sake, we reflect the exact same display image for other tooltips:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012a1fc3c444f423b4

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[youssef-lr]

This proposal looks good to me as well. Assigning @Nodebrute.

[cristipaval]

I was ooo last week and today I've been catching up for what I missed. Thanks @youssef-lr for pushing this forward. I agree with the proposal 🙇

[Nodebrute]

@abdulrahuman5196 @cristipaval PR is ready but I am unable to login to my account due to latest changes here https://expensify.slack.com/archives/C01GTK53T8Q/p1690241973418379

[abdulrahuman5196]

@Nodebrute I have made a comment regarding the same here https://expensify.slack.com/archives/C01GTK53T8Q/p1690262057767139?thread_ts=1690224959.854549&cid=C01GTK53T8Q

For now you can locally test by reverting the changes or making a rebase on older commit.

You could also try different browsers or from different IP?

[Nodebrute]

@abdulrahuman5196 Can you please review this PR #23527?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Workspace tooltip #23527

If no regressions arise, payment will be issued on 2023-08-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @Nodebrute requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[jliexpensify]

Not overdue!

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. Followup of this PR #20941 (comment)

Determine if we should create a regression test for this bug.

YES

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to a workspace
2. Request money from the workspace
3. Verify that you have the report preview where the actor is the workspace
4. Hover the workspace name on that report preview
5. Verify that you can see the tooltip

[jliexpensify]

Payment Summary:

• Bug Reporter: N/A (Cristi)
• Contributor: @Nodebrute $1000
• C+: @abdulrahuman5196 $1000

Upworks job.

Is this correct? I don't think anyone is eligible for a bonus.

[jliexpensify]

@Nodebrute I have invited you (i think, there was only one Anusha?) but can you add your full name from upworks to your GH profile? Thanks.

[abdulrahuman5196]

@jliexpensify correct. Accepted the offer.

[Nodebrute]

@jliexpensify I have accepted the offer.

[jliexpensify]

Everyone paid, job closed!