[HOLD for payment 2023-09-06] [$2000] IOS - Application Not Responding after adding built-in emoji from Keyboard and NewDot

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Tap the chat field to load the iOS built-in keyboard
3. Tap the emoji icon on the iOS built-in keyboard
4. Quickly tap on many emojis : Notice they fill in the chat field (don't send the chat)
5. Then tap the NewDot emoji icon on the chat field
6. Tap on any NewDot emoji : notice the app doesn't respond or add to the chat field
7. Try sending the message or touch any where on screen

Expected Result:

App should add the emojis to the chat field and send the message

Actual Result:

Application Not Responding

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1687893910.MP4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687205953132519

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013295df289a5037fc
• Upwork Job ID: 1673779604035960832
• Last Price Increase: 2023-07-19
• Automatic offers:
• ShogunFire | Contributor | 26265168
• tranvantoan-qn | Reporter | 26265171

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tranvantoan-qn]

2. Insert built-in emoji of keyboard
3. Insert NewDot’s Emoji

The word NewDot’s Emoji may cause confusion so I will explain it more:

These 2 steps mean we need to use both emoji of the keyboard and emoji added in our app - Expensify

It may not happen the first time, but try sending it a few times then the app will hang

[tranvantoan-qn]

This is the console log I got when connecting with XCode - the issue happened at about 13:27
Xcode-log.txt

[Christinadobrzyn]

I can't reproduce - asking for more information in Slack - https://expensify.slack.com/archives/C049HHMV9SM/p1687811366675009?thread_ts=1687205953.132519&cid=C049HHMV9SM

[tranvantoan-qn]

@Christinadobrzyn

I tested on 2 devices:

iOS 14.2: It happened just after 1 or 2 messages (the one on the attached video)

iOS 16.2: It happened after 5 or 6 message

Can you give it more try? And maybe using a combination of texts and emojis in the message could help reproduce it easier?

[Christinadobrzyn]

Okay, I can reproduce it - it seems like the issue is dependent on entering a lot of emojis from the iOS keyboard. I updated the OP and the video. adding an external label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013295df289a5037fc

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Is this only happening on iOS?

[Christinadobrzyn]

@parasharrajat Yes only iOS - I couldn't reproduce on Android

[parasharrajat]

No proposals...

[parasharrajat]

No proposals.....

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[parasharrajat]

@Christinadobrzyn Let's increase the bounty.

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($2000)

[melvin-bot]

📣 @ShogunFire 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @tranvantoan-qn 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[parasharrajat]

Let's remove the hold from title of this issue.

[melvin-bot]

🎯 ⚡️ Woah @parasharrajat / @ShogunFire, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @ShogunFire got assigned: 2023-08-22 15:03:29 Z
• when the PR got merged: 2023-08-24 15:15:16 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixing the freeze on ios when we choose multiple emojis quickly #25708

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ShogunFire requires payment offer (Contributor)
• @parasharrajat does not require payment (Eligible for Manual Requests)
• @tranvantoan-qn requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

@parasharrajat do you think we need a regression test for this?

[Christinadobrzyn]

Hey @parasharrajat just checking before paying this out - do you think we need a regression test?

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Migrate ReportActionCompose to function #18648
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18648/files#r1319710137
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA. We added the responsible code to fix the freezing but it didn't work as expected.
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Test 1:

1. Go to any report
2. Click on the emojis picker button
3. Click on a lot of emojis quickly
4. Do step 2 and 3 multiple times and verify the app is not frozen

Test 2:

1. Go to any report
2. Tap/focus the composer.
3. Switch to the iOS built-in emoji keyboard.
4. Quickly tap on many emojis
5. Observe that the app is not frozen.
6. Then tap the app emoji picker on the composer.
7. Select a few emojis quickly.
8. Verify the app is not frozen

Do you agree 👍 or 👎 ?

[hayata-suenaga]

I agree with @parasharrajat 's regression tests

[Christinadobrzyn]

Awesome thanks @parasharrajat

Regression Test GH: https://github.com/Expensify/Expensify/issues/316248

Payouts due:

Issue Reporter: $250 @tranvantoan-qn - paid in Upwork
Contributor: $2000 + $1000 bonus @ShogunFire - paid in Upwork
Contributor+: $2000 + $1000 bonus @parasharrajat - paid through NewExpensify

Eligible for 50% #urgency bonus? Y - #21540 (comment)

Upwork job is here.

[parasharrajat]

Payment requested.

[JmillsExpensify]

$3,000 payment approved for @parasharrajat based on BZ summary.