[$1000] Clicking on back button to close emoji modal takes user back to LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Click on emoji icon from the composer
3. Click on back button to close the modal

Expected Result:

Emoji picker should close

Actual Result:

Emoji picker closes after taking user back to LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-06-26-20-30-19.mp4

Screen_Recording_20230621_215000_Chrome.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687373497207199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dea35f22a7048c58
• Upwork Job ID: 1673981484525449216
• Last Price Increase: 2023-06-28

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on back button to close emoji modal takes user back to LHN #20446

What is the root cause of that problem?

Emoji picker is placed in ReportScreen

App/src/pages/home/ReportScreen.js

Line 360 in e5f00f8

<EmojiPicker ref={EmojiPickerAction.emojiPickerRef} />

When users back to LHN, the LHN is shown then ReportScreen is unmounted => hide the emoji picker

What changes do you think we should make in order to solve the problem?

We should hide the emoji picker when the navigation states get changed

In

App/src/libs/Navigation/NavigationRoot.js

Line 59 in e5f00f8

const updateSavedNavigationStateAndLogRoute = (state) => {

detect the navigation states get changed and hide the picker

if(_.get(EmojiPickerAction.emojiPickerRef.current,'state.isEmojiPickerVisible',false)){
            EmojiPickerAction.hideEmojiPicker()
        }

we can create the new function on EmojiPickerAction to check if the picker is visible or not.

We should do the same thing with context menu,...

Result

Screenrecorder-2023-06-27-15-26-57-726.mp4

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[bfitzexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dea35f22a7048c58

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[absolutezero13]

This is android hardware back button problem yes?

[melvin-bot]

📣 @absolutezero13! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[absolutezero13]

Contributor details
Your Expensify account email: ilker897@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01e04a206fe6f84390

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[parasharrajat]

I feel like we already have a similar issue on GH.

Update:
Duplicate of #9823. We can close this @bfitzexpensify

[bfitzexpensify]

Good call @parasharrajat. Closing this out.