Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] mWeb / Android - Popovers aren't closing on navigating back in native - reported by @thesahindia #9823

Closed
mvtglobally opened this issue Jul 11, 2022 · 91 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Jul 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Back button

  1. Go to any chat
  2. Open emoji picker
  3. Press native back button (back button of your device)

Swipe back

  1. Open any chat that has a message
  2. Long press on a message
  3. Without letting your finger leave the screen during the long press, swipe right
  4. The app goes to the previous screen but context menu stays active

Expected Result:

Popover should close

Actual Result:

Popover don't close

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.79-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

video_20220629_104413_edit.mp4
Screen.Recording.2023-01-21.at.9.28.37.PM.mov

Upwork job URL: https://www.upwork.com/jobs/~01402faaf5968f784d
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1656497620210449

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 11, 2022
@zanyrenney zanyrenney removed their assignment Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@deetergp
Copy link
Contributor

Definitely a contributor-worthy issue!

@deetergp deetergp added External Added to denote the issue can be worked on by a contributor Weekly KSv2 and removed Daily KSv2 labels Jul 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2022

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 13, 2022
@deetergp deetergp added Weekly KSv2 and removed Daily KSv2 labels Jul 13, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2022

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@aldo-expensify aldo-expensify changed the title [HOLD #11768] mWeb / Android - Popovers aren't closing on pressing native back button - reported by @thesahindia [HOLD #11768] mWeb / Android - Popovers aren't closing on navigating back in native - reported by @thesahindia Feb 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@JmillsExpensify
Copy link

Same same

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@JmillsExpensify
Copy link

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@JmillsExpensify
Copy link

Coming off hold very soon!

@JmillsExpensify
Copy link

Working on testing this week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@iwiznia
Copy link
Contributor

iwiznia commented Jul 21, 2023

Going on sabbatical, please reassign another engineer if this goes off hold

@JmillsExpensify
Copy link

You're fine. I still need to get around to testing.

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@JmillsExpensify
Copy link

Hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@JmillsExpensify
Copy link

@thesahindia Would you mind re-testing this issue that you reported and confirm if it's still happening?

@thesahindia
Copy link
Member

Looks like it got fixed. I couldn't repro it.

@JmillsExpensify
Copy link

Perfect, thank you! $250 payment due to @thesahindia for issue reporting.

@JmillsExpensify
Copy link

Given that you are on NewDot payments, I'm going to approve and close this issue.

@JmillsExpensify
Copy link

$250 payment approved for @thesahindia based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Development

No branches or pull requests