[HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover #21683

kbecciv · 2023-06-27T13:06:46Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app.
Open a chat.
Mention a user using the @ symbol. Send the message.
Hover over the mention. It shows the old tooltip with only email.

Expected Result:

Hovering on mentions should show the new tooltip with email, avatar and display name.

Actual Result:

Hovering on mentions shows the old tooltip with only email.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-23.at.2.39.46.PM.2.mov

Desktop.2023.06.26.-.18.09.42.15.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nikhil-Vats
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687512682797759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0123436a96eaad8d30
Upwork Job ID: 1679594587000627200
Last Price Increase: 2023-07-13

melvin-bot · 2023-06-27T13:06:51Z

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-27T13:06:53Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Nikhil-Vats · 2023-06-27T13:12:20Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mentions don't show new tooltip on hover.

What is the root cause of that problem?

We still use the old tooltip component for mentions.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Lines 40 to 52 in e5f00f8

    
           <Tooltip text={loginWithoutLeadingAt}> 
        
               <TextLink 
        
                   // eslint-disable-next-line react/jsx-props-no-spreading 
        
                   {...defaultRendererProps} 
        
                   href={ROUTES.getDetailsRoute(loginWithoutLeadingAt)} 
        
                   style={[_.omit(props.style, 'color'), StyleUtils.getMentionStyle(isOurMention), {color: StyleUtils.getMentionTextColor(isOurMention)}]} 
        
                   onPress={() => showUserDetails(loginWithoutLeadingAt)} 
        
                   // Add testID so it is NOT selected as an anchor tag by SelectionScraper 
        
                   testID="span" 
        
               > 
        
                   <TNodeChildrenRenderer tnode={props.tnode} /> 
        
               </TextLink> 
        
           </Tooltip>

What changes do you think we should make in order to solve the problem?

Use the new UserDetailsTooltip in MentionUserRenderer and pass accountID to it.

accountID is not available in MentionUserRenderer so to get accountID from login use getAccountIDsByLogins from PersonalDetailsUtils -

const accountID = PersonalDetailsUtils.getAccountIDsByLogins([loginWithoutLeadingAt])[0];

We can also make a new function for getting accountID from login for a single user -

function getAccountIDByLogin(login) {
  const currentDetail = _.find(personalDetails, (detail) => detail.login === login);
  if (!currentDetail) {
      // generate an account ID because in this case the detail is probably new, so we don't have a real accountID yet
      return UserUtils.generateAccountID();
  }
  return Number(currentDetail.accountID);
}

Then, to keep code DRY we can use this function in getAccountIDsByLogins.

What alternative solutions did you explore? (Optional)

NA

Result -

Screen.Recording.2023-06-27.at.7.07.11.PM.mov

alitoshmatov · 2023-06-27T13:30:00Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Mentions don't show the new tooltip on hover

What is the root cause of that problem?

We are using simple tooltip rather than UserDetailsTooltip

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Lines 40 to 52 in e5f00f8

    
           <Tooltip text={loginWithoutLeadingAt}> 
        
               <TextLink 
        
                   // eslint-disable-next-line react/jsx-props-no-spreading 
        
                   {...defaultRendererProps} 
        
                   href={ROUTES.getDetailsRoute(loginWithoutLeadingAt)} 
        
                   style={[_.omit(props.style, 'color'), StyleUtils.getMentionStyle(isOurMention), {color: StyleUtils.getMentionTextColor(isOurMention)}]} 
        
                   onPress={() => showUserDetails(loginWithoutLeadingAt)} 
        
                   // Add testID so it is NOT selected as an anchor tag by SelectionScraper 
        
                   testID="span" 
        
               > 
        
                   <TNodeChildrenRenderer tnode={props.tnode} /> 
        
               </TextLink> 
        
           </Tooltip>

What changes do you think we should make in order to solve the problem?

We should use UserDetailsTooltip but since it is mentions we don't have accountID available for us to supply to tooltip, but it is planned to migrate to accountID based mentions which then solves this issue we can put this issue on hold for this migration and then solve this issue. If we have to till then we can provide fallbackUserDetails for UserDetailsTooltip with following values

           {
                login,
                displayName: login,
                avatar: UserUtils.getDefaultAvatar(),
            }

What alternative solutions did you explore? (Optional)

Christinadobrzyn · 2023-06-27T15:05:20Z

Might be fixed with this job- #20716 (comment) - asking

Nikhil-Vats · 2023-06-27T16:26:34Z

@Christinadobrzyn this issue is for the missing tooltip for mentions in chat messages.

The issue that you referenced is for missing tooltip for chats in LHN.

I think both are different.

Christinadobrzyn · 2023-06-27T23:02:27Z

There are some big changes to tooltip happening in this GH -#20512 (related to threads here - https://github.com/Expensify/Expensify/issues/290271)

I'm going to put on hold to see if it's resolved after this

Christinadobrzyn · 2023-07-03T22:03:09Z

still on hold for #20512

Christinadobrzyn · 2023-07-12T22:22:49Z

This is almost in production - #20512 - moving to daily

Christinadobrzyn · 2023-07-13T20:52:00Z

#20512 in production - testing this again it's still happening. Adding External

melvin-bot · 2023-07-13T20:52:11Z

Job added to Upwork: https://www.upwork.com/jobs/~0123436a96eaad8d30

melvin-bot · 2023-07-13T20:52:15Z

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-13T20:52:21Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

Christinadobrzyn · 2023-07-14T18:34:33Z

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.

At this time, we're receiving and reviewing proposals. I'll take this back when I'm back if it's still open

melvin-bot · 2023-07-20T17:01:13Z

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

melvin-bot · 2023-07-20T17:01:17Z

📣 @Nikhil-Vats 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-07-20T17:01:21Z

📣 @Nikhil-Vats 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

Nikhil-Vats · 2023-07-20T20:51:51Z

Contributor details
Your Expensify account email: whivats5499@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~015012a47c23b056bc

melvin-bot · 2023-07-20T20:51:53Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot · 2023-07-25T01:15:26Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-07-25T01:15:30Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix tooltip for mentions #23310

If no regressions arise, payment will be issued on 2023-08-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter @Nikhil-Vats $250
Contributor that fixed the issue @Nikhil-Vats $1500
Contributor+ that helped on the issue and/or PR @mollfpr $1500

For reference, here are some details about the assignees on this issue:

@mollfpr requires payment
@Nikhil-Vats requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-25T01:15:31Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

tjferriss · 2023-07-25T22:26:47Z

Offers have been sent to everyone via Upworks. @mollfpr can you get started on the checklist when you have time?

Christinadobrzyn · 2023-08-01T22:15:17Z

I'm back from ooo - happy to take this back @tjferriss - even though we're close to done - whatever is best for you!

tjferriss · 2023-08-01T22:24:41Z

@Christinadobrzyn I can finish this one up. All that's left is the payments and checklist.

tjferriss · 2023-08-02T03:36:36Z

All payments have been made via Upworks. @mollfpr can you complete the checklist?

mollfpr · 2023-08-02T03:49:11Z

@tjferriss Thank you! Completing it now 🚀

mollfpr · 2023-08-02T03:57:42Z

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. It's not caught while working on the new user detail tooltip component.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

In general, this is not a bug but rather an improvement for the tooltip to show the user detail. So the regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Only testable on the desktop or web

Open the app
Go to any chat
Mention any user by typing @ in the composer and selecting anyone from the list
Hover the cursor on the mentioned user
Verify that the user detail displayed inside the tooltip
Now mention someone not in the mention suggestion by typing their full email like - @unexistingperson@gmail.com
Hover the cursor on the mentioned user
Verify that the user detail displayed inside the tooltip
👍 or 👎

tjferriss · 2023-08-03T18:51:38Z

I've submitted the regression test. We're good to close this one.

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 27, 2023

melvin-bot bot assigned Christinadobrzyn Jun 27, 2023

Christinadobrzyn mentioned this issue Jun 27, 2023

[HOLD https://github.com/Expensify/App/pull/20512 $1000] Web - New tooltip is not displayed over workspace direct chats and general workspace chat name #20716

Closed

6 tasks

Christinadobrzyn changed the title ~~Web - Mentions don't show the new tooltip on hover~~ [HOLD #20512] Web - Mentions don't show the new tooltip on hover Jun 27, 2023

Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Jun 27, 2023

melvin-bot bot added the Overdue label Jul 12, 2023

melvin-bot bot removed the Overdue label Jul 12, 2023

Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Jul 12, 2023

Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Jul 13, 2023

melvin-bot bot changed the title ~~[HOLD #20512] Web - Mentions don't show the new tooltip on hover~~ [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover Jul 13, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 13, 2023

melvin-bot bot assigned mollfpr Jul 13, 2023

Christinadobrzyn removed the Bug Something is broken. Auto assigns a BugZero manager. label Jul 14, 2023

Nikhil-Vats mentioned this issue Jul 20, 2023

Fix tooltip for mentions #23310

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 20, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 25, 2023

melvin-bot bot changed the title ~~[$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover~~ [HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover Jul 25, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jul 25, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 31, 2023

melvin-bot bot removed the Overdue label Aug 1, 2023

tjferriss unassigned Christinadobrzyn Aug 1, 2023

tjferriss closed this as completed Aug 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover #21683

[HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover #21683

kbecciv commented Jun 27, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023 •

edited by Christinadobrzyn

Loading

Nikhil-Vats commented Jun 27, 2023 •

edited

Loading

alitoshmatov commented Jun 27, 2023

Christinadobrzyn commented Jun 27, 2023

Nikhil-Vats commented Jun 27, 2023

Christinadobrzyn commented Jun 27, 2023 •

edited

Loading

Christinadobrzyn commented Jul 3, 2023

Christinadobrzyn commented Jul 12, 2023

Christinadobrzyn commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

Christinadobrzyn commented Jul 14, 2023 •

edited

Loading

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

Nikhil-Vats commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023 •

edited by tjferriss

Loading

melvin-bot bot commented Jul 25, 2023

tjferriss commented Jul 25, 2023

Christinadobrzyn commented Aug 1, 2023

tjferriss commented Aug 1, 2023 •

edited

Loading

tjferriss commented Aug 2, 2023

mollfpr commented Aug 2, 2023

mollfpr commented Aug 2, 2023

tjferriss commented Aug 3, 2023

[HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover #21683

[HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover #21683

Comments

kbecciv commented Jun 27, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023 • edited by Christinadobrzyn Loading

Bug0 Triage Checklist (Main S/O)

Nikhil-Vats commented Jun 27, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alitoshmatov commented Jun 27, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented Jun 27, 2023

Nikhil-Vats commented Jun 27, 2023

Christinadobrzyn commented Jun 27, 2023 • edited Loading

Christinadobrzyn commented Jul 3, 2023

Christinadobrzyn commented Jul 12, 2023

Christinadobrzyn commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

Christinadobrzyn commented Jul 14, 2023 • edited Loading

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

Nikhil-Vats commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023 • edited by tjferriss Loading

melvin-bot bot commented Jul 25, 2023

tjferriss commented Jul 25, 2023

Christinadobrzyn commented Aug 1, 2023

tjferriss commented Aug 1, 2023 • edited Loading

tjferriss commented Aug 2, 2023

mollfpr commented Aug 2, 2023

mollfpr commented Aug 2, 2023

tjferriss commented Aug 3, 2023

kbecciv commented Jun 27, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 27, 2023 •

edited by Christinadobrzyn

Loading

Nikhil-Vats commented Jun 27, 2023 •

edited

Loading

Christinadobrzyn commented Jun 27, 2023 •

edited

Loading

Christinadobrzyn commented Jul 14, 2023 •

edited

Loading

melvin-bot bot commented Jul 25, 2023 •

edited by tjferriss

Loading

tjferriss commented Aug 1, 2023 •

edited

Loading