Fix tooltip for mentions #23310

Nikhil-Vats · 2023-07-20T20:37:50Z

Details

Use the new tooltip for mentions.

Fixed Issues

$ #21683
PROPOSAL: #21683 (comment)

Tests

Open the app only on desktop or web. Since this is related to tooltip which is not shown on mobiles, this can't be tested on mobiles.
Go to any chat.
Mention any user by typing @ in the composer and selecting anyone from the list.
Verify that the new tooltip should be displayed.
Now mention someone not in the mention suggestion by typing their full email like - @unexistingperson@gmail.com.
Verify that the new tooltip is shown on hover.

Note - Tooltip is not currently shown for unregistered mobile numbers. This is a known bug.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-21.at.1.51.40.AM.mov

Screen.Recording.2023-07-21.at.1.52.24.AM.mov

Mobile Web - Chrome

Since this is related to tooltip which is not shown on mobiles, this can't be tested on mobiles.

Mobile Web - Safari

Since this is related to tooltip which is not shown on mobiles, this can't be tested on mobiles.

Desktop

Screen.Recording.2023-07-21.at.2.04.57.AM.mov

Screen.Recording.2023-07-21.at.2.05.17.AM.mov

iOS

Since this is related to tooltip which is not shown on mobiles, this can't be tested on mobiles.

Android

Since this is related to tooltip which is not shown on mobiles, this can't be tested on mobiles.

melvin-bot · 2023-07-20T20:37:55Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nikhil-Vats · 2023-07-20T20:41:41Z

src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

+            <UserDetailsTooltip
+                accountID={accountID}
+                fallbackUserDetails={{
+                    displayName: loginWithoutLeadingAt,


we don't need to pass anything else here since login is not shown if displayName is same as login

App/src/components/UserDetailsTooltip/index.web.js

Line 38 in bc7f689

const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : '';

and avatar is generated from optimistic accountID passed above in UserDetailsTooltip component here -

App/src/components/UserDetailsTooltip/index.web.js

Line 48 in bc7f689

source={props.icon ? props.icon.source : UserUtils.getAvatar(userAvatar, userAccountID)}

Nikhil-Vats · 2023-07-20T20:47:36Z

@mollfpr PR is open.

mollfpr · 2023-07-21T13:25:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

23310.Web.mp4

Mobile Web - Chrome

23310.mWeb-Chrome.mp4

Mobile Web - Safari

23310.mWeb-Safari.mp4

Desktop

23310.Desktop.mp4

iOS

23310.iOS.mp4

Android

23310.Android.mp4

mollfpr

LGTM and tests well 👍

mountiny

Thanks!

OSBotify · 2023-07-21T17:30:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-21T18:49:48Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:23:45Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix tooltip for mentions

642f346

Nikhil-Vats requested a review from a team as a code owner July 20, 2023 20:37

melvin-bot bot requested review from mollfpr and removed request for a team July 20, 2023 20:37

Nikhil-Vats commented Jul 20, 2023

View reviewed changes

mollfpr approved these changes Jul 21, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny July 21, 2023 17:04

mountiny assigned Nikhil-Vats Jul 21, 2023

mountiny approved these changes Jul 21, 2023

View reviewed changes

mountiny merged commit 2c5dd69 into Expensify:main Jul 21, 2023

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

melvin-bot bot mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-01] [$1000] [HOLD #20512] Web - Mentions don't show the new tooltip on hover #21683

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tooltip for mentions #23310

Fix tooltip for mentions #23310

Nikhil-Vats commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

Nikhil-Vats Jul 20, 2023

Nikhil-Vats commented Jul 20, 2023

mollfpr commented Jul 21, 2023 •

edited

Loading

mollfpr left a comment

mountiny left a comment

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Fix tooltip for mentions #23310

Fix tooltip for mentions #23310

Conversation

Nikhil-Vats commented Jul 20, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 20, 2023

Nikhil-Vats Jul 20, 2023

Choose a reason for hiding this comment

Nikhil-Vats commented Jul 20, 2023

mollfpr commented Jul 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

mollfpr commented Jul 21, 2023 •

edited

Loading