Only render `UserDetailsTooltip` on web #21807

hannojg · 2023-06-28T14:58:48Z

Details

We only need the UserDetailsTooltip component on web, that's why we can skip it for the other platforms.

Fixed Issues

$ #21796
PROPOSAL: #21796

Tests

Verify that no errors appear in the JS console
Hover over an entry on the SidebarLinks and verify that the tooltip is still working on web
Verify that the SidebarLinks look correct on the mobile platforms

Offline tests

Doesn't apply

QA Steps

Same as testing steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

248286364-1f353f08-c501-42c8-a78b-880192860e09

iOS

Android

melvin-bot · 2023-06-28T14:58:53Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham

@hannojg few things:

There are some conflicts to resolve here
Instead of using withLocalize and adding ...withLocalizePropTypes to the propTypes, can we instead use the useLocalize hook?
Bit odd that the displayName is different on native, but I guess that's fine.

roryabraham · 2023-06-29T22:38:29Z

Also, I don't think well need a C+ review here.

roryabraham · 2023-07-07T23:01:20Z

@hannojg bump for changes and conflicts

…f/remove-userdetailstooltip-mobile

hannojg · 2023-07-10T20:06:48Z

Hey @roryabraham sorry for the wait! This is good for review again! 😊

melvin-bot · 2023-07-11T01:03:36Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2023-07-11T01:04:58Z

Not an emergency, but I did actually forget to do the reviewer checklist here. My bad, but this is a trivial change where we just removed a tooltip on mobile, where it never shows anyways. Anyways, still should've completed the checklist...

OSBotify · 2023-07-11T01:45:19Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.39-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-07-11T03:00:41Z

@hannojg Can you pls clarify for QA team what is "SidebarLinks" component on the page

chiragxarora · 2023-07-11T07:10:17Z

@roryabraham @hannojg I'm unable to see changes of my PR #22567 after your merge
Can you please look into it
PS: my pr was also merged yesterday, few hours before yours

hannojg · 2023-07-11T11:55:52Z

Hey @chiragxarora good catch, so sorry, might have happened that I missed your change during merge. Double checking …

hannojg · 2023-07-11T12:09:34Z

Reapplied the changes in this PR: #22637

chiragxarora · 2023-07-11T14:28:23Z

Heyyy @hannojg , can I make this PR instead of you?
It's kinda overwriting my changes and I wouldn't be able to see my name on git blame, sad hehe :(

hannojg · 2023-07-11T14:43:21Z

Hey, for sure! I also didn't meant to take the credits for the fix, sorry! its all yours, just wanted to help with creating the PR because I messed it up for you 😅 will close it, nw!

chiragxarora · 2023-07-11T14:46:53Z

I NEVER meant that @hannojg , I just love my name showing up on blame that's all😂😭

mananjadhav · 2023-07-11T15:11:10Z

@chiragxarora do we have an ETA for this one? This would mean our original issue will be pushed in the payment timeline.

OSBotify · 2023-07-13T01:42:48Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-07-17T23:10:06Z

src/components/UserDetailsTooltip/index.web.js

+    return (
+        <Tooltip
+            renderTooltipContent={renderTooltipContent}
+            renderTooltipContentKey={[userDisplayName, userLogin]}


@hannojg Do you recall why we had to add renderTooltipContentKey? (Coming from #22840)

I think that was already there when i made the changes, so no clue, sorry

Oops sorry my bad, the merge with main commit tricked me 😅. This was added in #22246.

Only render UserDetailsTooltip on web

0c70ad8

hannojg requested a review from a team as a code owner June 28, 2023 14:58

melvin-bot bot requested review from sobitneupane and removed request for a team June 28, 2023 14:58

roryabraham requested changes Jun 29, 2023

View reviewed changes

roryabraham removed the request for review from sobitneupane June 29, 2023 22:38

hannojg added 5 commits July 10, 2023 21:56

Merge branch 'main' of github.com:margelo/expensify-app-fork into per…

8ba1551

…f/remove-userdetailstooltip-mobile

update with changes from main

afeba44

use localize hook

457da56

Merge branch 'main' of github.com:margelo/expensify-app-fork into per…

2ac340e

…f/remove-userdetailstooltip-mobile

fix prop types

1183cd7

hannojg requested a review from roryabraham July 10, 2023 20:07

roryabraham approved these changes Jul 11, 2023

View reviewed changes

roryabraham merged commit 42f96d3 into Expensify:main Jul 11, 2023

melvin-bot bot added the Emergency label Jul 11, 2023

roryabraham removed the Emergency label Jul 11, 2023

OSBotify mentioned this pull request Jul 11, 2023

Deploy Checklist: New Expensify 2023-07-10 #22598

Closed

76 tasks

hannojg mentioned this pull request Jul 11, 2023

Fix: reapply #22567 #22637

Closed

57 tasks

mananjadhav mentioned this pull request Jul 11, 2023

re-applying breakword to userDetailsTooltip #22648

Merged

58 tasks

melvin-bot bot mentioned this pull request Jul 13, 2023

[HOLD for payment 2023-07-20] [Performance] UserDetailsTooltip component renders unnecessary on mobile platforms #21796

Closed

6 tasks

s77rt reviewed Jul 17, 2023

View reviewed changes

s77rt mentioned this pull request Jul 17, 2023

[$1000] Chat - Tooltip vibrates when moving cursor over it and does not automatically resize #22840

Closed

6 tasks

Nikhil-Vats mentioned this pull request Jul 20, 2023

Fix tooltip for mentions #23310

Merged

58 tasks

Nodebrute mentioned this pull request Jul 25, 2023

Workspace tooltip #23527

Merged

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only render `UserDetailsTooltip` on web #21807

Only render `UserDetailsTooltip` on web #21807

hannojg commented Jun 28, 2023

melvin-bot bot commented Jun 28, 2023

roryabraham left a comment

roryabraham commented Jun 29, 2023

roryabraham commented Jul 7, 2023

hannojg commented Jul 10, 2023

melvin-bot bot commented Jul 11, 2023

roryabraham commented Jul 11, 2023

OSBotify commented Jul 11, 2023

mvtglobally commented Jul 11, 2023

chiragxarora commented Jul 11, 2023 •

edited

Loading

hannojg commented Jul 11, 2023

hannojg commented Jul 11, 2023

chiragxarora commented Jul 11, 2023 •

edited

Loading

hannojg commented Jul 11, 2023

chiragxarora commented Jul 11, 2023

mananjadhav commented Jul 11, 2023

OSBotify commented Jul 13, 2023

s77rt Jul 17, 2023

hannojg Jul 18, 2023

s77rt Jul 18, 2023

Only render UserDetailsTooltip on web #21807

Only render UserDetailsTooltip on web #21807

Conversation

hannojg commented Jun 28, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 28, 2023

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Jun 29, 2023

roryabraham commented Jul 7, 2023

hannojg commented Jul 10, 2023

melvin-bot bot commented Jul 11, 2023

roryabraham commented Jul 11, 2023

OSBotify commented Jul 11, 2023

mvtglobally commented Jul 11, 2023

chiragxarora commented Jul 11, 2023 • edited Loading

hannojg commented Jul 11, 2023

hannojg commented Jul 11, 2023

chiragxarora commented Jul 11, 2023 • edited Loading

hannojg commented Jul 11, 2023

chiragxarora commented Jul 11, 2023

mananjadhav commented Jul 11, 2023

OSBotify commented Jul 13, 2023

s77rt Jul 17, 2023

Choose a reason for hiding this comment

hannojg Jul 18, 2023

Choose a reason for hiding this comment

s77rt Jul 18, 2023

Choose a reason for hiding this comment

Only render `UserDetailsTooltip` on web #21807

Only render `UserDetailsTooltip` on web #21807

chiragxarora commented Jul 11, 2023 •

edited

Loading

chiragxarora commented Jul 11, 2023 •

edited

Loading