[HOLD for payment 2023-07-20] [Performance] UserDetailsTooltip component renders unnecessary on mobile platforms

[hannojg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

What performance issue do we need to solve?

We want to avoid doing unnecessary work, especially on low end mobile devices, to get the most performance budget as possible for important tasks.

Right now, the UserDetailsTooltip is only affecting web/desktop users that can hover over a user. Mobile users cannot. However, we are rendering that component on every platform.
We are e.g. rendering it in the report list, and thereby we are creating unnecessary renders. Even though it has no UI its connecting to onyx which is slightly blocking, and we want to avoid that:

What is the impact of this on end-users?

Especially on lower end devices we will gain a bit of our performance budget back making other important operations slightly faster.

List any benchmarks that show the severity of the issue

Using the react-devtools and profiling the app with the release bundle. We don't want to see render commits of unnecessary components like UserDetailsTooltip

Proposed solution (if any)

Very simple:

• Rename UserDetailsTooltip/index.js to UserDetailsTooltip/index.web.js
• Create a new UserDetailsTooltip/index.js, which is just forwarding the children

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Measure the app start again with react-devtools, there now should be less commits.
I applied the proposal and checked again. In the previous profile we had 75 commits, after the change it only were 69 and we can't find any rendering of the UserDetailsTooltip

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: latest/main
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on Upwork

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@roryabraham Huh... This is 4 days overdue. Who can take care of this?

[roryabraham]

Co-assignign @hannojg here. I reviewed the PR but it has not been updated since last week and has conflicts.

[hannojg]

Will update today !

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Only render UserDetailsTooltip on web #21807

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

This issue has not been updated in over 15 days. @hannojg, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[roryabraham]

This is finished.