Deploy Checklist: New Expensify 2023-07-25

[OSBotify]

Release Version: 1.3.45-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Support new emojiReaction data format #17996
• Fix/regression 18110 composer should have the same height in other platforms #19516
• Convert Date Picker to Functional Component #20864
• Remove port to fix Flipper #21243
• [No QA] Add TypeScript Guideline #21549
• fix: disable the default callout in ios safari #22216
• fix: Regression - Emoji reaction not working - Issue 22235 (Original - 21826) #22270
• Cut off reveal button when deleting in offline mode #22276
• Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430
• Remove passwordless beta logic #22461
• Navigate to #admin on workspace creation #22619
• Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645
• fix remove only first request #22727
• fix: format amount before navigating to next page #22728
• Refactor KeyboardDismissingFlatList to a functional component #22805
• refactor: WindowDimensionsProvider to function component #22809
• AutoFocus On Debit Card Page #22841
• Assignee selector #22851
• fix: deleted message not show when deleting thread #22864
• Migrate BaseKeyboardSpacer.js to fc component #22886
• Migrate BasePasswordPopover.js to function component #22891
• fix: optimistically add personal details #22904
• Component refactor: migrate ReportSettingsPage to function component #22927
• Go back to new task page if the URL doesn't contain reportID #22982
• Fix the emoji picker does not close when editing message is deleted #22984
• fix 22610: Request Money input is not getting focus when navigating back #22985
• Prevent potential duplication of adding the event listeners #22991
• [navigation-refactor] Fix: dont use fallback if there are multiple rhp stacks #23007
• Fix: when someone assign a task to himself and share it, his email hi… #23041
• Update Expensify-Chat-Playbook-for-Conferences.md #23047
• fix: text below the input flickers in ios. #23054
• fix: 22692 FAB menu is not open when login with the new account #23056
• Center Emojis Vertically on Native #23071
• fix: scroll date of birth year list on first mount only #23079
• Fix - close account confirmation modal is displayed by ENTER when network is offline #23099
• Fix magic code input border bottom does not turn red after receiving error from server #23101
• Clarify regression penalty expectations #23112
• Fix: When the language changes, we should not change the focused index in a list #23117
• Create DesignDocIssue template #23127
• #22803 followup - update composer handlePaste conditions #23135
• fix: ensure multiple errors are not shown on Add New contact page #23141
• fix: the created task message is grey when offline #23150
• Remove lhNormal from MenuItem #23156
• subtitle added for share destination #23159
• Fix the cursor position is not at the end of the message when editing the welcome message #23162
• Add provisioning profile for Expensify AdHoc App #23176
• Setup the compose focus manager on screen focus #23181
• Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185
• [CP Staging] Add missing Toggle Developer Tools option to desktop menu #23192
• Rename DesignDocIssue to DesignDocIssue.md #23205
• Remove unnecessary default value #23206
• Update DesignDocIssue.md #23211
• Change allReportActionsParam default #23214
• migare workspace Reimburse #23215
• #20709: Use windowHeight in getNavigationModalCardStyles #23222
• [CP Staging] Fix regression #23189 #23240
• Migrate OptionsList/index.js to a functional component #23241
• Revert "fix: The title field is cleared when the Confirm task button is pressed" #23243
• Fix padding above time stamp in report view #23244
• remove limit and add max length task description #23246
• fix: allow to add link with code block inside alias text part #23247
• changes for wording for use plus button #23248
• Fix for: Web - App displays upload popup along with edit photo page on double enter on photo upload in profile #23249
• Update ReportSettingsPage and NotificationPreferencePage permission #23255
• [NoQA] Fix the usage of localize #23256
• fix crash while pressing mention #23259
• fix click request magic code #23263
• Fix: No gap between username and ReportPreview in chat #23276
• Fix non-functional LHN "Mark as unread" button for IOU reports #23277
• fix: height calculation of BaseTextInput #23286
• Revert "Apple sign-in" #23295
• [CP Staging] [NO QA] Update provisioning profile to include one with Apple Sign In entitlement #23299
• Fix tooltip for mentions #23310
• Fix the app is cut off if a picker unmounted while visible #23337
• Fix Share somewhere in assign task shows a wrong report #23338
• Fix shouldUseFullTitle #23358
• fix: safari layout glitch using a CSS property #23363
• Fix text based mobile search on InviteMembers page #23366
• [NO QA] Support new format of multiple events with lastUpdateID and previousUpdateID #23391
• Fix Infinite loop on timezone page when visit timezone selection page by direct link #23418
• fix tooltip not visible for task assignee #23461
• fix break description #23487
• Fix bugs surrounding report name when deleting first thread comment #23514

Internal QA:

• Fix the settled preview message #23110 - @mountiny

Deploy Blockers:

• [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] Web - Workspace avatar is not updating after renaming #23189

• [HOLD for payment 2023-08-01][$1000] Chat - App crashed while clicking on non-existed mention email #23250

• [HOLD for payment 2023-08-02] LHN - If the first comment in a thread is deleted [Deleted message] appears in the LHN subtitle of the parent report #23401

• Workspace rooms details page display user list in place of room name #23416

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Workspace - System throws an error when refreshing 'Invite new members' page immediately after creating a workspace #23536

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Web - User is unable to paste text to 'Invite new members' & 'Members' search field #23537

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Task - Unable paste from clipboard on share somewhere page after reloading the page #23539

• Web - Assignee contact list is not showing up after user reloads the page #23540

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Contact methods - System throws an error when refreshing the secondary login verification page #23542

• Web - Magic input showing along with delivery failure page for suspended accounts #23544

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] [$1000] Dev: Web - User is unable to authenticate with magic link #23504

• Chat -Auth GetAccountIDsByEmails returned an error message displayed in default workspace room #23584

• Task - 'Share somewhere' subtitle appears a few seconds after user display name #23583

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Bank Account - Unable to enter year of birth from keyboard on Personal Information page #23576

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.45-1 🚀

[mountiny]

checking the HOLD deploy blockers as they are resolved already and they should not be here anymore

[mountiny]

Checking these 2 off:

• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Web - User is unable to paste text to 'Invite new members' & 'Members' search field #23537
• [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Task - Unable paste from clipboard on share somewhere page after reloading the page #23539

They are resolved by a CP to staging

[Natnael-Guchima]

The following issues might be deploy blockers. I reported them when they were only reproducible on dev, now they are reproducible on staging too.

• Dev: Web - User is signed-out when adding 2FA
• Dev: Web - User is unable to authenticate with magic link

[marcaaron]

Checking off #23416 because the fix for that went out yesterday - we just did not remove the DeployBlockerCash label so it returned on this checklist.

[marcaaron]

Checking off #23542 & #23536 as per this comment

[marcaaron]

Checking off #23540 as per this comment

[amyevans]

Checked off #23544

[mvtglobally]

Regression is ongoing, we still have about 25%

Current checklist updates
#22619 is failing #23566 repro in PROD checking off
#22886 is failing #23565 repro in PROD
#23159 is failing #23583
#23248 the issue observed #23584. pls double check if related
#23418 is failing #23548 repro in prod checking off

[marcaaron]

Checking off #23504 as we CP'd a fix

[marcaaron]

Checking off #23584 as it is a web deploy blocker and not a blocker for App

[marcaaron]

Checking off #20864 since we reverted the PR

[marcaaron]

Checking off #23583 as per #23583 (comment)

[marcaaron]

#23248 the issue observed #23584. pls double check if related

Not related

[marcaaron]

Were either of these PRs blocked by anything @mvtglobally ?

#22461
#22982

Or just not yet tested?

[mvtglobally]

@marcaaron
We are down to just 15% TestRail regression left

Was double checking with the team.
We are blocked for #22461 due to #12913
#22982 we have an issue, but it's repro in prod, so not a blocker. Will post in a few

[mvtglobally]

@mountiny @marcaaron regression is completed

#22982 is failing with #23598 repro in prod

[mountiny]

Thank you! Checking off the last one #22461 (comment) as I have qaed it and it works

[mountiny]

API timings are good and no crashes which would stand out and would be unique for this version as far as I can tell

There are github incidents with PRs for some users

[mountiny]

Actions are good so going to trigger the deploy

[mountiny]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[mountiny]