Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430

Ollyws · 2023-07-07T15:41:49Z

Details

Fixed Issues

$ #21673
PROPOSAL: #21673 (comment)

Tests

Go to the "Settings" section.
Click on the "Security" option.
Select the "Two-factor authentication" feature.
Select the 'Copy' button and move the mouse outside the button
Verify that when the copy icon re-appears it is in a non-highlighted state.

Verify that no errors appear in the JS console

Offline tests

Go to the "Settings" section.
Click on the "Security" option.
Select the "Two-factor authentication" feature.
Select the 'Copy' button and move the mouse outside the button
Verify that when the copy icon re-appears it is in a non-highlighted state.

QA Steps

Go to the "Settings" section.
Click on the "Security" option.
Select the "Two-factor authentication" feature.
Select the 'Copy' button and move the mouse outside the button
Verify that when the copy icon re-appears it is in a non-highlighted state.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

MacOS_Web.mp4

Mobile Web - Chrome

Android_Chrome.mp4

Mobile Web - Safari

iOS_Safari.mp4

Desktop

MacOS_Desktop.mp4

iOS

iOS_Native.mp4

Android

Android_Native.mp4

melvin-bot · 2023-07-07T15:41:54Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2023-07-07T17:02:11Z

I opted to render the text inside the Pressable only if the inline prop is not true, this way it will retain the correct alignment when using inline in CopyTextToClipboard on pages like Contact Methods.

abdulrahuman5196 · 2023-07-09T17:43:50Z

@Ollyws Checklist is not complete? Is the PR not ready to review?

Ollyws · 2023-07-09T18:51:39Z

@abdulrahuman5196 Sorry clocked off for the weekend. Checklist complete, ready for review.

Ollyws · 2023-07-12T08:37:46Z

@abdulrahuman5196 Friendly bump.

abdulrahuman5196 · 2023-07-12T20:17:48Z

Sorry for the delay will complete the review tomorrow morning

abdulrahuman5196 · 2023-07-13T09:15:24Z

I opted to render the text inside the Pressable only if the inline prop is not true, this way it will retain the correct alignment when using inline in CopyTextToClipboard on pages like Contact Methods.

@Ollyws Is this solving some issue? Could you provide some details on this?

Ollyws · 2023-07-13T11:05:12Z

@abdulrahuman5196 If we just always render the text inside pressable, inline is vertically misaligned on Android:

arosiclair · 2023-07-17T14:03:14Z

@abdulrahuman5196 can you keep moving this forward?

abdulrahuman5196 · 2023-07-17T14:05:51Z

Sorry for the delay. Will close this out today

abdulrahuman5196 · 2023-07-17T20:58:53Z

@Ollyws Sorry for the delay. Can we fix the merge conflicts? I will close this review today itself as a first thing.

Ollyws · 2023-07-17T21:20:03Z

@abdulrahuman5196 No worries, merge conflicts fixed.

abdulrahuman5196 · 2023-07-17T21:59:37Z

@abdulrahuman5196 If we just always render the text inside pressable, inline is vertically misaligned on Android:

@Ollyws But this change is causing the original issue of "on text hover, icon is not highlighted" issue to come up here. Even pressing on the email only copies.

Screen.Recording.2023-07-18.at.3.26.46.AM.mov

Ollyws · 2023-07-17T22:21:39Z

@abdulrahuman5196
The original issue was when we clicked on the copy button on the 2fa page and moused out, it remained hovered.
These changes leave the CopyTextToClipboard in its current state (same as production).
Changing the behaviour of CopyTextToClipboard seems out of scope for this issue imo, as it's never used on the 2fa page.

abdulrahuman5196 · 2023-07-17T22:24:30Z

@arosiclair What do you think of this CopyTextToClipboard behaviour? Should we keep the same behaviour as in production or change it as per the current behaviour changes?

Ollyws · 2023-07-17T22:33:39Z

The original issue never occurs on CopyTextToClipboard, it always seems to be in the correct hover state as far as I can see.

arosiclair · 2023-07-18T14:11:01Z

What exactly is the existing behavior of CopyTextToClipboard and how is it changed with this PR? I only see a clip of the changed version.

Ollyws · 2023-07-18T14:29:00Z

@arosiclair This is the current behavior of CopyTextToClipboard:

copytexttoclipboard.mp4

You can check it on the Contact Methods Page.

It's not changed in this PR the only buttons that are changed are the ones on the 2FA codes page.

abdulrahuman5196 · 2023-07-18T15:23:09Z

@arosiclair

What exactly is the existing behavior of CopyTextToClipboard and how is it changed with this PR? I only see a clip of the changed version.

Existing behaviour of CopyTextToClipboard is not changed yet in this PR

The question would be, Do we want to change the existing behaviour with the current new behaviour we are implementing in the 2FA page buttons ("If we hover over the button text, icon should be also in hover state") in the CopyTextToClipboard?

Current behaviour video here #22430 (comment)

arosiclair · 2023-07-19T15:31:01Z

Okay since it's unchanged, I think we can consider that out of scope for now. Consider reporting it as its own bug.

abdulrahuman5196 · 2023-07-20T19:49:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-21.at.12.22.20.AM.mp4

Mobile Web - Chrome

az_recorder_20230721_010223.mp4

Mobile Web - Safari

Untitled.1.mp4

Desktop

Screen.Recording.2023-07-21.at.12.55.04.AM.mp4

iOS

Screen.Recording.2023-07-21.at.12.49.18.AM.mp4

Android

az_recorder_20230721_011804.mp4

abdulrahuman5196

The changes looks good and works well. Reviewers checklist is also complete.

All yours @arosiclair

🎀 👀 🎀
C+ Reviewed

OSBotify · 2023-07-21T15:02:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-21T18:50:03Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:24:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:21Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Move text within and apply styles to Pressable

d8009a5

Ollyws requested a review from a team as a code owner July 7, 2023 15:41

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team July 7, 2023 15:41

Render text inside pressable if inline

1b2f4fc

arosiclair assigned Ollyws Jul 17, 2023

arosiclair self-requested a review July 17, 2023 13:51

Ollyws added 2 commits July 17, 2023 22:13

Merge branch 'main' into issue-21673

6a3471f

Oops, remove extra tooltipText

674da24

Replace isDelayButtonStateComplete with !isActive

374d594

abdulrahuman5196 approved these changes Jul 20, 2023

View reviewed changes

arosiclair approved these changes Jul 21, 2023

View reviewed changes

arosiclair merged commit a984818 into Expensify:main Jul 21, 2023

maddylewis mentioned this pull request Jul 21, 2023

[HOLD for payment 2023-08-01] [$1000] Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #21673

Closed

6 tasks

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

Ollyws deleted the issue-21673 branch August 17, 2023 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430

Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430

Ollyws commented Jul 7, 2023 •

edited

Loading

melvin-bot bot commented Jul 7, 2023

Ollyws commented Jul 7, 2023

abdulrahuman5196 commented Jul 9, 2023

Ollyws commented Jul 9, 2023

Ollyws commented Jul 12, 2023

abdulrahuman5196 commented Jul 12, 2023

abdulrahuman5196 commented Jul 13, 2023

Ollyws commented Jul 13, 2023

arosiclair commented Jul 17, 2023

abdulrahuman5196 commented Jul 17, 2023

abdulrahuman5196 commented Jul 17, 2023

Ollyws commented Jul 17, 2023

abdulrahuman5196 commented Jul 17, 2023

Ollyws commented Jul 17, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 17, 2023 •

edited

Loading

Ollyws commented Jul 17, 2023

arosiclair commented Jul 18, 2023 •

edited

Loading

Ollyws commented Jul 18, 2023

abdulrahuman5196 commented Jul 18, 2023

arosiclair commented Jul 19, 2023

abdulrahuman5196 commented Jul 20, 2023 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430

Fix for: Web – 2FA - The copy icon placed in "copy code" button is clicked, the icon remains in a hovered state. #22430

Conversation

Ollyws commented Jul 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 7, 2023

Ollyws commented Jul 7, 2023

abdulrahuman5196 commented Jul 9, 2023

Ollyws commented Jul 9, 2023

Ollyws commented Jul 12, 2023

abdulrahuman5196 commented Jul 12, 2023

abdulrahuman5196 commented Jul 13, 2023

Ollyws commented Jul 13, 2023

arosiclair commented Jul 17, 2023

abdulrahuman5196 commented Jul 17, 2023

abdulrahuman5196 commented Jul 17, 2023

Ollyws commented Jul 17, 2023

abdulrahuman5196 commented Jul 17, 2023

Ollyws commented Jul 17, 2023 • edited Loading

abdulrahuman5196 commented Jul 17, 2023 • edited Loading

Ollyws commented Jul 17, 2023

arosiclair commented Jul 18, 2023 • edited Loading

Ollyws commented Jul 18, 2023

abdulrahuman5196 commented Jul 18, 2023

arosiclair commented Jul 19, 2023

abdulrahuman5196 commented Jul 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Ollyws commented Jul 7, 2023 •

edited

Loading

Ollyws commented Jul 17, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 17, 2023 •

edited

Loading

arosiclair commented Jul 18, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 20, 2023 •

edited

Loading