Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Web - User is signed-out when adding 2FA #23507

Closed
1 of 6 tasks
kbecciv opened this issue Jul 24, 2023 · 6 comments
Closed
1 of 6 tasks

Dev: Web - User is signed-out when adding 2FA #23507

kbecciv opened this issue Jul 24, 2023 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Jul 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on 'Profile' avatar
  2. Click on 'Security' link
  3. Click on 'Two-factor authentication' link
  4. Click on 'Copy' button > click on 'Next' button
  5. Enter authenticated code & verify that 2FA is added successfully
  6. Close RHP
  7. Click on 'Profile' avatar

Expected Result:

User shouldn't be signed out on adding 2FA

Actual Result:

User is signed out on adding 2FA

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.44.0
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-24.12-46-42.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690192308790909

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv kbecciv added the Needs Reproduction Reproducible steps needed label Jul 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Natnael-Guchima
Copy link

@kevinksullivan This is reproducible on staging but not on prod. It might be a good idea to label this as a deploy blocker.

2023-07-25.06.59.50.mp4
2023-07-25.07.03.38.mp4

@Natnael-Guchima
Copy link

The issue seems to be fixed now. But, I couldn't find the fixing PR. Is this something that I am eligible for reporting bonus?
Thanks.

Screencast.from.2023-07-26.11-30-36.mp4

@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kevinksullivan
Copy link
Contributor

@Natnael-Guchima we only pay out reporting bonus for issues that are fixed on this GH. closing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

3 participants