Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645

lazar-stamenkovic · 2023-07-11T14:43:14Z

Details

After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom. This PR fixes this bug.

Fixed Issues

$ #21603
PROPOSAL: #21603 (comment), #21603 (comment)

Tests

Open any LONG chat
Scroll up the chat list
Go into any sub-thread
Click Back button on Mobile or Browser to go back to the main chat
Input any text and Click on send button
Verify to scroll down to the latest/new message

Offline tests

Same above

QA Steps

Open any LONG chat
Scroll up the chat list
Go into any sub-thread
Click Back button on Mobile or Browser to go back to the main chat
Input any text and Click on send button
Should be verified to scroll down to the latest/new message

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

New.Expensify.-.web.mp4

Mobile Web - Chrome

expensify-mobile-chrome.mov

Mobile Web - Safari

Expensify-mobile-safari-compress.mov

Desktop

Electron.-.New.Expensify.-.18.July.2023.mp4

iOS

expensify-ios.mov

Android

expensify-android.mp4

…riber object

melvin-bot · 2023-07-11T14:43:19Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-07-11T14:43:29Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

lazar-stamenkovic · 2023-07-11T14:58:42Z

I have read the CLA Document and I hereby sign the CLA

lazar-stamenkovic · 2023-07-11T21:19:03Z

@thesahindia, could you please review my pull request (PR)? Please let me know if I missed anything in the PR.

allroundexperts · 2023-07-12T22:33:43Z

I'll be taking this over!

allroundexperts · 2023-07-12T23:17:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-18.at.2.56.25.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-18.at.3.05.35.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-18.at.3.03.09.PM.mov

Desktop

Screen.Recording.2023-07-18.at.7.02.55.PM.mov

iOS

Screen.Recording.2023-07-18.at.3.02.35.PM.mov

Android

Screen.Recording.2023-07-18.at.3.06.37.PM.mov

allroundexperts · 2023-07-13T16:59:35Z

Hi @lazar-stamenkovic!

Why does the migration to a functional component make your originally proposed solution invalid? I think the changes that you've made right now are more of a work around. Can you please explain?

lazar-stamenkovic · 2023-07-13T18:02:13Z

@allroundexperts This is the proposal for this PR.
#21603 (comment)

Thanks.

allroundexperts · 2023-07-18T10:00:18Z

Hi @lazar-stamenkovic!
This does not seem to work on Desktop. Can you please check?

Also, the screen recording for Desktop is missing.

lazar-stamenkovic · 2023-07-18T13:19:20Z

Hi @allroundexperts ,
thanks for your review. this issue can't be produced on Desktop because Desktop version doesn't have the function backing to main screen from thread.

Please take a look again.

allroundexperts · 2023-07-18T13:20:27Z

Hi @allroundexperts , thanks for your review. this issue can't be produced on Desktop because Desktop version doesn't have the function backing to main screen from thread.

Please take a look again.

You can open the console and just enter window.history.back() to check this.

lazar-stamenkovic · 2023-07-18T13:29:53Z

it works for desktop perfectly. i attached screen recording.

Electron.-.New.Expensify.-.18.July.2023.mp4

lazar-stamenkovic · 2023-07-18T13:31:32Z

@allroundexperts i attached the screen record on Desktop in description.

allroundexperts · 2023-07-18T14:09:41Z

Thanks for adding the screen recording @lazar-stamenkovic!

I'm not sure why it wasn't working previously. I just tested it again and it seems to work fine. Maybe I was on a wrong branch.

allroundexperts · 2023-07-18T14:10:15Z

Can you please add QA steps as well?

lazar-stamenkovic · 2023-07-18T14:19:53Z

@allroundexperts I added QA steps in description.

allroundexperts

LGTM!

lazar-stamenkovic · 2023-07-19T13:08:46Z

LGTM!

@allroundexperts thanks for your review.

lazar-stamenkovic · 2023-07-20T21:28:20Z

@deetergp please review the PR and let me know if you need any updating.

mountiny

Thanks!

mountiny · 2023-07-20T23:04:25Z

src/libs/actions/Report.js

-};
-
-let newActionSubscriber = defaultNewActionSubscriber;
+// new action subscriber array for report pages


Suggested change

// new action subscriber array for report pages

// New action subscriber array for report pages

mountiny · 2023-07-20T23:12:17Z

@lazar-stamenkovic lint is failing and one NAB

lazar-stamenkovic · 2023-07-21T01:18:31Z

@lazar-stamenkovic lint is failing and one NAB

@mountiny fixed lint errors. thanks for review

mountiny

Thanks everyone!

@lazar-stamenkovic Congratulations to your first contribution! We are very glad to have you here, hope to see many more 🍾

OSBotify · 2023-07-21T10:54:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

lazar-stamenkovic · 2023-07-21T13:11:48Z

Thanks everyone!

@lazar-stamenkovic Congratulations to your first contribution! We are very glad to have you here, hope to see many more 🍾

Thanks @mountiny

OSBotify · 2023-07-21T18:50:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:24:06Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add newActionSubscribers array in Report.js instead of newActionSubsc…

21c85f0

…riber object

lazar-stamenkovic requested a review from a team as a code owner July 11, 2023 14:43

melvin-bot bot requested review from thesahindia and removed request for a team July 11, 2023 14:43

lazar-stamenkovic mentioned this pull request Jul 11, 2023

[Awaiting Checklist Completion] [$1000] After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #21603

Closed

6 tasks

fix a comment, approve CLA

ecc9db3

twisterdotcom requested review from allroundexperts and removed request for thesahindia July 13, 2023 09:31

Merge branch 'main' into lazar-report-page-scroll-bug

af9050b

allroundexperts approved these changes Jul 18, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp July 18, 2023 17:58

mountiny assigned lazar-stamenkovic Jul 20, 2023

mountiny previously approved these changes Jul 20, 2023

View reviewed changes

fix lint error

ccf002f

lazar-stamenkovic dismissed mountiny’s stale review via ccf002f July 21, 2023 00:46

lazar-stamenkovic added 3 commits July 20, 2023 19:47

Merge branch 'main' into lazar-report-page-scroll-bug

d0d2a93

resolve a comment

6c3e7aa

code clean - add semicolon, remove space

a43b085

mountiny approved these changes Jul 21, 2023

View reviewed changes

mountiny merged commit f4551ca into Expensify:main Jul 21, 2023

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

tienifr mentioned this pull request Jul 26, 2023

[$1000] New messages aren't showing up as unread and bold in LHN #23599

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645

Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645

lazar-stamenkovic commented Jul 11, 2023 •

edited

Loading

melvin-bot bot commented Jul 11, 2023

github-actions bot commented Jul 11, 2023 •

edited

Loading

lazar-stamenkovic commented Jul 11, 2023

lazar-stamenkovic commented Jul 11, 2023

allroundexperts commented Jul 12, 2023

allroundexperts commented Jul 12, 2023 •

edited

Loading

allroundexperts commented Jul 13, 2023

lazar-stamenkovic commented Jul 13, 2023

allroundexperts commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

allroundexperts commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

allroundexperts commented Jul 18, 2023

allroundexperts commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

allroundexperts left a comment

lazar-stamenkovic commented Jul 19, 2023

lazar-stamenkovic commented Jul 20, 2023

mountiny left a comment

mountiny Jul 20, 2023

lazar-stamenkovic Jul 21, 2023

mountiny commented Jul 20, 2023

lazar-stamenkovic commented Jul 21, 2023

mountiny left a comment

OSBotify commented Jul 21, 2023

lazar-stamenkovic commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

	// new action subscriber array for report pages
	// New action subscriber array for report pages

Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645

Fix: After going back from a thread, clicking on New Message button doesn't scroll to the new message at the bottom #22645

Conversation

lazar-stamenkovic commented Jul 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 11, 2023

github-actions bot commented Jul 11, 2023 • edited Loading

lazar-stamenkovic commented Jul 11, 2023

lazar-stamenkovic commented Jul 11, 2023

allroundexperts commented Jul 12, 2023

allroundexperts commented Jul 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Jul 13, 2023

lazar-stamenkovic commented Jul 13, 2023

allroundexperts commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

allroundexperts commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

allroundexperts commented Jul 18, 2023

allroundexperts commented Jul 18, 2023

lazar-stamenkovic commented Jul 18, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

lazar-stamenkovic commented Jul 19, 2023

lazar-stamenkovic commented Jul 20, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny Jul 20, 2023

Choose a reason for hiding this comment

lazar-stamenkovic Jul 21, 2023

Choose a reason for hiding this comment

mountiny commented Jul 20, 2023

lazar-stamenkovic commented Jul 21, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 21, 2023

lazar-stamenkovic commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

lazar-stamenkovic commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 11, 2023 •

edited

Loading

allroundexperts commented Jul 12, 2023 •

edited

Loading