Cut off reveal button when deleting in offline mode #22276

dukenv0307 · 2023-07-05T15:43:34Z

Details

Cut off reveal button when deleting in offline mode

Fixed Issues

$ #20946
PROPOSAL: #20946 (comment)

Tests

Login with user A
On another device, login with user B
From user A, send a message to user B
From user B, choose a flag option that will hide the message after flagging to flag this message
From user A, go offline and delete the message
Verify that the reveal button is cut off and the message is shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with user A
On another device, login with user B
From user A, send a message to user B
From user B, choose a flag option that will hide the message after flagging to flag this message
From user A, go offline and delete the message
Verify that the reveal button is cut off and the message is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.05-07-2023.22.37.19.webm

Mobile Web - Chrome

Record_2023-07-05-22-46-38.mp4

Mobile Web - Safari

original-3E5A6E66-A680-42D3-979A-C5D6CAF0ED4F.mp4

Desktop

Screen.Recording.2023-07-05.at.23.44.52.mov

iOS

Screen.Recording.2023-07-05.at.23.13.28.mp4

Android

20946.mp4

melvin-bot · 2023-07-05T16:47:23Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-07-07T03:12:26Z

@rushatgabhane Friendly bump. Please help me to review the PR when you have a chance.

rushatgabhane · 2023-07-10T05:22:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-20.at.10.26.29.mov

Mobile Web - Chrome

WhatsApp.Video.2023-07-20.at.10.46.36.mp4

Mobile Web - Safari

Desktop

Screen.Recording.2023-07-20.at.10.29.37.mov

iOS

Screen.Recording.2023-07-20.at.10.36.24.mov

Android

rushatgabhane · 2023-07-10T05:23:34Z

src/pages/home/report/ReportActionItem.js

+            return;
+        }
+
+        if (_.isEmpty(latestDecision)) {


@dukenv0307 could you please add a comment on why we're doing this?

setModerationDecision(CONST.MODERATION.MODERATOR_DECISION_APPROVED);
setIsHidden(false);

dukenv0307 · 2023-07-12T03:08:55Z

@rushatgabhane Friendly Bump

dukenv0307 · 2023-07-17T07:34:12Z

@rushatgabhane Do I need to update anything else to complete the PR?

dukenv0307 · 2023-07-20T02:57:33Z

@rushatgabhane Please help to continue reviewing the PR when you have a chance.

rushatgabhane

LGTM

MariaHCD · 2023-07-20T13:52:24Z

Ran out of time today, will review this tomorrow

OSBotify · 2023-07-21T06:57:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-21T18:50:18Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:24:15Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:36Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:54:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

cut off reveal button when deleting in offline mode

4fe6323

dukenv0307 marked this pull request as ready for review July 5, 2023 16:47

dukenv0307 requested a review from a team as a code owner July 5, 2023 16:47

melvin-bot bot requested review from rushatgabhane and removed request for a team July 5, 2023 16:47

merge main

716d889

rushatgabhane reviewed Jul 10, 2023

View reviewed changes

dukenv0307 added 4 commits July 10, 2023 12:33

add comment

d5751ce

edit comment

7feca4f

fix lint

6410748

Merge branch 'main' into fix/20946

1efdf15

MariaHCD mentioned this pull request Jul 13, 2023

[Awaiting Checklist Completion] [$1000] Web - The reveal /hide button text is cut off in offline mode and doesn't disappears dynamically #20946

Closed

6 tasks

rushatgabhane approved these changes Jul 20, 2023

View reviewed changes

melvin-bot bot requested a review from MariaHCD July 20, 2023 05:30

MariaHCD approved these changes Jul 21, 2023

View reviewed changes

MariaHCD merged commit 8dcad16 into Expensify:main Jul 21, 2023

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cut off reveal button when deleting in offline mode #22276

Cut off reveal button when deleting in offline mode #22276

dukenv0307 commented Jul 5, 2023 •

edited

Loading

melvin-bot bot commented Jul 5, 2023

dukenv0307 commented Jul 7, 2023

rushatgabhane commented Jul 10, 2023 •

edited

Loading

rushatgabhane Jul 10, 2023 •

edited

Loading

dukenv0307 Jul 10, 2023

rushatgabhane Jul 10, 2023

dukenv0307 commented Jul 12, 2023

dukenv0307 commented Jul 17, 2023

dukenv0307 commented Jul 20, 2023

rushatgabhane left a comment

MariaHCD commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Cut off reveal button when deleting in offline mode #22276

Cut off reveal button when deleting in offline mode #22276

Conversation

dukenv0307 commented Jul 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 5, 2023

dukenv0307 commented Jul 7, 2023

rushatgabhane commented Jul 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

dukenv0307 Jul 10, 2023

Choose a reason for hiding this comment

rushatgabhane Jul 10, 2023

Choose a reason for hiding this comment

dukenv0307 commented Jul 12, 2023

dukenv0307 commented Jul 17, 2023

dukenv0307 commented Jul 20, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

MariaHCD commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

dukenv0307 commented Jul 5, 2023 •

edited

Loading

rushatgabhane commented Jul 10, 2023 •

edited

Loading

rushatgabhane Jul 10, 2023 •

edited

Loading