[HOLD for payment 2023-07-12][$1000] All task related pages have extra padding between header and content

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Click on FAB Icon
3. Click on Assign task
4. Notice on assign page Header and content has huge extra spacing then other pages (this can be quick compare by navigating to profile page (from drawer) notice here padding between header and contact does not have extra padding
5. This extra padding gap of (20px) can be found on all task related pages like Assign task, confirm task, task title ,task description pages

Expected Result:

There should be no extra padding between header and content just like all other pages (consistency across the similar pages on app)

Actual Result:

There is extra padding between header and content on all task related pages

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687764851615229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5dc2de852edd528
• Upwork Job ID: 1674640685641990144
• Last Price Increase: 2023-06-30

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

All task related pages have extra padding between header and content

What is the root cause of that problem?

The root cause is we might have added extra styles.mt5 to parent view of the all below screens during initial phase which was not required as per code consistency

What changes do you think we should make in order to solve the problem?

Solution - 1

We need to remove extra styles.mt5 padding on below pages as we don’t required since header already has enough padding

App/src/pages/tasks/NewTaskDetailsPage.js

Line 87 in c261901

style={[styles.mh5, styles.mt5, styles.flexGrow1]}

App/src/pages/tasks/NewTaskPage.js

Line 153 in c261901

<View style={[styles.mt5, styles.containerWithSpaceBetween]}>

App/src/pages/tasks/NewTaskTitlePage.js

Line 88 in c261901

style={[styles.mh5, styles.mt5, styles.flexGrow1]}

App/src/pages/tasks/NewTaskDescriptionPage.js

Line 82 in c261901

style={[styles.mh5, styles.mt5, styles.flexGrow1]}

Solution -2

Apply required padding-top on above files (but mostly solution - 1 is recommend as it makes all this pages consistent with other pages

[kadiealexander]

@thienlnam @shawnborton Just wanted to check that this padding isn't intentional before we fix it, any advice please?

[shawnborton]

I agree that we should remove that extra padding to be consistent with other pages. Thoughts @thienlnam ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5dc2de852edd528

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@dhairyasenjaliya's proposal make sense to me, looks straightforward.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tylerkaraszewski]

@dhairyasenjaliya's proposal make sense to me, looks straightforward.

🎀 👀 🎀 C+ reviewed

Are you sure that's the correct user? The proposal was posted by @kavimuru

[dhairyasenjaliya]

@tylerkaraszewski actually they created this gh and i posted proposal along with report so thats my proposal

[melvin-bot]

📣 @fedirjh You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[tylerkaraszewski]

@kadiealexander - I am leaving today on sabbatical. Can you please remove and re-apply the Engineering label to select a new engineer to finish this issue? Thanks!

[dhairyasenjaliya]

@fedirjh PR ready for review

[Julesssss]

I am leaving today on sabbatical. Can you please remove and re-apply the Engineering label to select a new engineer to finish this issue? Thanks!

I was assigned the review, so I'll take over, no need to reassign.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account 🎉

Reviewer - [$1000] All task related pages have extra padding between header and content

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[Julesssss]

Merged, awaiting deployment

[fedirjh]

Seems like automation didn’t trigger here. PR deployed to production

[dhairyasenjaliya]

seems like Melvin has some problem specific with mehhhhh it never has triggered for my PR even if that has been merged within an hour hehe 😺

[kadiealexander]

🎯 ⚡️ Woah @fedirjh / @dhairyasenjaliya, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dhairyasenjaliya got assigned: 2023-06-30 16:02 UTC
• when the PR got merged: 2023-07-03 07:57 UTC

On to the next one 🚀

[kadiealexander]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove extra spacing from content & header on task create flow #21981

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[kadiealexander]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

@fedirjh Please make sure the checklist is complete!

[fedirjh]

• Link to the PR: Create Task FrontEnd Changes #17992
• Link to comment: Create Task FrontEnd Changes #17992 (comment)
• Link to discussion: I don't think there's any change needed.
• Determine if we should create a regression test for this bug: ❌ This is a little padding issue, no regression test is needed.

[Julesssss]

Hi @kadiealexander, this is ready to be paid out now I think

[kadiealexander]

Everyone has been paid :)