[HOLD for checklist] [$1000] Web - Pressing the Pin/Unpin option from the LHN context menu does not refocus the composer.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App and go to any chat
2. On LHN, Right click on any user's chat to Open the context menu
3. Press Pin/Unpin option

Expected Result:

After pressing on the pin/unpin then composer should be refocused, as the same happens After pressing on the mark as read/unread option from the LHN context menu

Actual Result:

After Pressing the pin/unpin option, Composer is not refocused.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pin-unpin-does-npt-focus.mov

Recording.3307.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687938349897719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc6f96ae79d98073
• Upwork Job ID: 1674685137307795456
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

from @jayeshmangwani

Please re-state the problem that we are trying to solve in this issue.

Pressing the Pin/Unpin option from the LHN context menu does not refocus the composer

What is the root cause of that problem?

On press of the Pin and Unpin buttons we only hide the Context Menu, we do not call the refocus of the Composer.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

What changes do you think we should make in order to solve the problem?

When we press the Pin and Unpin buttons, then we need to call the ReportActionComposeFocusManager.focus, like same, we do for Mark As Read button

Need to update this code at these two places

    hideContextMenu(false); // OLD
    hideContextMenu(true, ReportActionComposeFocusManager.focus); // NEW

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the Pin/Unpin option from the LHN context menu does not refocus the composer

What is the root cause of that problem?

On press of the Pin and Unpin buttons we only hide the Context Menu, we do not call the refocus of the Composer.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

What changes do you think we should make in order to solve the problem?

When we press the Pin and Unpin buttons, then we need to call the ReportActionComposeFocusManager.focus, like same, we do for Mark As Read button

Need to update this code at these two places

    hideContextMenu(false); // OLD
    hideContextMenu(true, ReportActionComposeFocusManager.focus); // NEW

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 313 to 315 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 300 to 302 in 94e2656

	if (closePopover) {
	hideContextMenu(false);
	}

[greg-schroeder]

Reviewing

[greg-schroeder]

Reproduced, seems like it should match the Read/Unread behavior to me

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc6f96ae79d98073

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[abdulrahuman5196]

@greg-schroeder I have doubts on the requirements. I agree we have to improve the experience with consistency here, but wanted to confirm on the expectation.
The current Mark as unread in LHN works like if we use it on any chat the current open is getting focused not the chat which we marked as unread.

So pin/unpin any LHN item should focus current composer? Is this what we want?

[melvin-bot]

@greg-schroeder, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[greg-schroeder]

@abdulrahuman5196 Hmm. I mean I think it should, right? To me it feels more natural that the composer is focused after the LHN action is complete - when nothing is focused it doesn't feel right. And so I think it should be the currently selected chat, yes.

Do you not agree?

[greg-schroeder]

bump on the above

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

@greg-schroeder Agree on the above - #21861 (comment)

Then as per the expectation @jayeshmangwani 's proposal here #21861 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

cc: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[Beamanator]

I agree with the problem & solution 👍

@greg-schroeder can we make sure this gets into Test Rail or something? :D I keep seeing these types of issues pop up, which means we probably don't have this flow in test rail right?

[jayeshmangwani]

PR is ready for review

cc: @abdulrahuman5196

[greg-schroeder]

I agree with the problem & solution 👍

@greg-schroeder can we make sure this gets into Test Rail or something? :D I keep seeing these types of issues pop up, which means we probably don't have this flow in test rail right?

Certainly. @abdulrahuman5196 let's make sure when completing the checklist for this issue that we definitely add a robust regression test in testrail

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refocus composer on pin/unpin press from LHN context menu #22549

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Payments complete. Just looking for the checklist to be completed cc @abdulrahuman5196

Let's keep #21861 (comment) in mind as well

[abdulrahuman5196]

@greg-schroeder Thank you for quickly processing the payment. Sorry for the delay. Completed checklist now.

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This was not present during initial implementation of PIn/Unpin option. Made the a comment on the same - #16079 (comment)

Determine if we should create a regression test for this bug.

Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open App and go to any chat
2. On LHN, Right click on any user's chat to Open the context menu
3. Press Pin/Unpin option
4. Verify that after pressing on the pin/unpin composer should be refocused

[greg-schroeder]

Thanks @abdulrahuman5196! Taking care of filing that and closing this out.