[HOLD for payment 2023-07-28] [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button #21953

kbecciv · 2023-06-30T14:04:36Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open App and Go to Settings > Payments
Press Add payment method button

Expected Result:

Should not show any console warnings

Actual Result:

Getting Console Warnings (The prop anchorPosition.horizontal is marked as required in PopoverMenu, but its value is undefined)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: iOS (Dev)
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

console-bug-ios-anchorPosition.horizontal.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688037417930409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0151ff298169cff532
Upwork Job ID: 1679538004659675136
Last Price Increase: 2023-07-13

The text was updated successfully, but these errors were encountered:

melvin-bot · 2023-06-30T14:04:41Z

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-30T14:04:43Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

kbecciv · 2023-06-30T14:05:01Z

Proposal

from: @jayeshmangwani

Please re-state the problem that we are trying to solve in this issue.

Getting console warning on the Payments page when pressing Add payment method button

What is the root cause of that problem?

The issue is happening because, on BasePaymentsPage, we pass the horizontal: this.state.anchorPositionHorizontal to AddPaymentMethodMenu Component, and the horizontal value should be the number horizontal: PropTypes.number When we press the Add payment method button at that time, we are setting the horizontal: undefined and this should be a number value

Here, on AddPaymentMethodMenu anchorPosition's horizontal value should be the number

App/src/components/AddPaymentMethodMenu.js

Lines 21 to 25 in f9acca9

    
           /** Anchor position for the AddPaymentMenu. */ 
        
           anchorPosition: PropTypes.shape({ 
        
               horizontal: PropTypes.number, 
        
               vertical: PropTypes.number, 
        
           }),

And we are passing the anchorPosition value from BasePaymentsPage to AddPaymentMethodMenu

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 416 to 424 in f9acca9

    
           <AddPaymentMethodMenu 
        
               isVisible={this.state.shouldShowAddPaymentMenu} 
        
               onClose={this.hideAddPaymentMenu} 
        
               anchorPosition={{ 
        
                   horizontal: this.state.anchorPositionHorizontal, 
        
                   vertical: this.state.anchorPositionVertical - 10, 
        
               }} 
        
               onItemSelected={(method) => this.addPaymentMethodTypePressed(method)} 
        
           />

On Add payment method button we call the paymentMethodPressed function and on this function, we calculate the position of the click

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 190 to 191 in f9acca9

    
           paymentMethodPressed(nativeEvent, accountType, account, isDefault, methodID) { 
        
               const position = getClickedTargetLocation(nativeEvent.currentTarget);

And Then We call the setPositionAddPaymentMenu

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 236 in f9acca9

this.setPositionAddPaymentMenu(position);

getClickedTargetLocation values will be different for Mobile Devices and Web, For the web, we calculate this by using the getBoundingClientRect method of HTML DOM Element, and its returns the eight properties left top, right, bottom, x, y, width, height

App/src/libs/getClickedTargetLocation/index.js

Lines 7 to 9 in df91473

    
           function getClickedTargetLocation(target) { 
        
               return target.getBoundingClientRect(); 
        
           }

And for Mobile devices(Android and IOS), We return only bottom and left values

App/src/libs/getClickedTargetLocation/index.native.js

Lines 7 to 10 in df91473

And On mobile devices when we call setPositionAddPaymentMenu with the position object that we have calculated from getClickedTargetLocation, There will be only bottom and left values for the mobile devices, and here anchorPositionHorizontal expects the x value, but x is undefined.
And that's why we are getting this error as anchorPositionHorizontal should be a number, and here we are getting undefined.

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 153 to 162 in f9acca9

    
           setPositionAddPaymentMenu(position) { 
        
               this.setState({ 
        
                   anchorPositionTop: position.top + position.height + variables.addPaymentPopoverTopSpacing, 
        
                   // We want the position to be 13px to the right of the left border 
        
                   anchorPositionRight: this.props.windowWidth - position.right + variables.addPaymentPopoverRightSpacing, 
        
                   anchorPositionHorizontal: position.x, 
        
                   anchorPositionVertical: position.y, 
        
               }); 
        
           }

What changes do you think we should make in order to solve the problem?

On the getClickedTargetLocation function, we should return the x and y too, On mobile devices we use the bottom-docked modal so we actually don't need the anchorPosition so here we should add the x and y values to 0 as, horizontal and vertical values expecting a number

App/src/libs/getClickedTargetLocation/index.native.js

Lines 7 to 10 in df91473

    return {
        bottom: 0,
        left: 0,
        x: 0,
        y: 0,
    };

And on top of that, we should add missing values top, right, width, height with value 0 as anchorPositionTop is also expecting the number value of top and height; anchorpositionright expects the right value to be a number.

What alternative solutions did you explore? (Optional)

We should pass the anchorPosition value conditionally when there is no Small screen device, then pass the anchorPosition

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 416 to 424 in f9acca9

    
           <AddPaymentMethodMenu 
        
               isVisible={this.state.shouldShowAddPaymentMenu} 
        
               onClose={this.hideAddPaymentMenu} 
        
               anchorPosition={{ 
        
                   horizontal: this.state.anchorPositionHorizontal, 
        
                   vertical: this.state.anchorPositionVertical - 10, 
        
               }} 
        
               onItemSelected={(method) => this.addPaymentMethodTypePressed(method)} 
        
           />

{...(!this.props.isSmallScreenWidth ? {anchorPosition} : {})}

jayeshmangwani · 2023-06-30T14:06:20Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Getting console warning on the Payments page when pressing Add payment method button

What is the root cause of that problem?

The issue is happening because, on BasePaymentsPage, we pass the horizontal: this.state.anchorPositionHorizontal to AddPaymentMethodMenu Component, and the horizontal value should be the number horizontal: PropTypes.number When we press the Add payment method button at that time, we are setting the horizontal: undefined and this should be a number value

Here, on AddPaymentMethodMenu anchorPosition's horizontal value should be the number

App/src/components/AddPaymentMethodMenu.js

Lines 21 to 25 in f9acca9

    
           /** Anchor position for the AddPaymentMenu. */ 
        
           anchorPosition: PropTypes.shape({ 
        
               horizontal: PropTypes.number, 
        
               vertical: PropTypes.number, 
        
           }),

And we are passing the anchorPosition value from BasePaymentsPage to AddPaymentMethodMenu

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 416 to 424 in f9acca9

    
           <AddPaymentMethodMenu 
        
               isVisible={this.state.shouldShowAddPaymentMenu} 
        
               onClose={this.hideAddPaymentMenu} 
        
               anchorPosition={{ 
        
                   horizontal: this.state.anchorPositionHorizontal, 
        
                   vertical: this.state.anchorPositionVertical - 10, 
        
               }} 
        
               onItemSelected={(method) => this.addPaymentMethodTypePressed(method)} 
        
           />

On Add payment method button we call the paymentMethodPressed function and on this function, we calculate the position of the click

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 190 to 191 in f9acca9

    
           paymentMethodPressed(nativeEvent, accountType, account, isDefault, methodID) { 
        
               const position = getClickedTargetLocation(nativeEvent.currentTarget);

And Then We call the setPositionAddPaymentMenu

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 236 in f9acca9

this.setPositionAddPaymentMenu(position);

getClickedTargetLocation values will be different for Mobile Devices and Web, For the web, we calculate this by using the getBoundingClientRect method of HTML DOM Element, and its returns the eight properties left top, right, bottom, x, y, width, height

App/src/libs/getClickedTargetLocation/index.js

Lines 7 to 9 in df91473

    
           function getClickedTargetLocation(target) { 
        
               return target.getBoundingClientRect(); 
        
           }

And for Mobile devices(Android and IOS), We return only bottom and left values

App/src/libs/getClickedTargetLocation/index.native.js

Lines 7 to 10 in df91473

And On mobile devices when we call setPositionAddPaymentMenu with the position object that we have calculated from getClickedTargetLocation, There will be only bottom and left values for the mobile devices, and here anchorPositionHorizontal expects the x value, but x is undefined.
And that's why we are getting this error as anchorPositionHorizontal should be a number, and here we are getting undefined.

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 153 to 162 in f9acca9

    
           setPositionAddPaymentMenu(position) { 
        
               this.setState({ 
        
                   anchorPositionTop: position.top + position.height + variables.addPaymentPopoverTopSpacing, 
        
                   // We want the position to be 13px to the right of the left border 
        
                   anchorPositionRight: this.props.windowWidth - position.right + variables.addPaymentPopoverRightSpacing, 
        
                   anchorPositionHorizontal: position.x, 
        
                   anchorPositionVertical: position.y, 
        
               }); 
        
           }

What changes do you think we should make in order to solve the problem?

On the getClickedTargetLocation function, we should return the x and y too, On mobile devices we use the bottom-docked modal so we actually don't need the anchorPosition so here we should add the x and y values to 0 as, horizontal and vertical values expecting a number

App/src/libs/getClickedTargetLocation/index.native.js

Lines 7 to 10 in df91473

    return {
        bottom: 0,
        left: 0,
        x: 0,
        y: 0,
    };

And on top of that, we should add missing values top, right, width, height with value 0 as anchorPositionTop is also expecting the number value of top and height; anchorpositionright expects the right value to be a number.

What alternative solutions did you explore? (Optional)

We should pass the anchorPosition value conditionally when there is no Small screen device, then pass the anchorPosition

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 416 to 424 in f9acca9

    
           <AddPaymentMethodMenu 
        
               isVisible={this.state.shouldShowAddPaymentMenu} 
        
               onClose={this.hideAddPaymentMenu} 
        
               anchorPosition={{ 
        
                   horizontal: this.state.anchorPositionHorizontal, 
        
                   vertical: this.state.anchorPositionVertical - 10, 
        
               }} 
        
               onItemSelected={(method) => this.addPaymentMethodTypePressed(method)} 
        
           />

{...(!this.props.isSmallScreenWidth ? {anchorPosition} : {})}

muttmuure · 2023-07-03T17:44:29Z

https://expensify.slack.com/archives/C01GTK53T8Q/p1688406242558149

Not sure we're supposed to fix bugs on dev

muttmuure · 2023-07-05T15:22:04Z

Asking what I need to do if something is a deploy blocker

jayeshmangwani · 2023-07-10T14:37:04Z

@muttmuure This issue is not the deploy blocker. Above is the console warning, and this console warning issue does not happen on staging or production, and this warning is displayed when run from the local main branch.

Few GH issues, example for, console warnings/errors #22206, #22169, #21840

muttmuure · 2023-07-10T14:37:51Z

So is the answer to these questions: no

Reproducible in staging?: n/a
Reproducible in production?: n/a

?

jayeshmangwani · 2023-07-10T14:42:50Z

So is the answer to these questions: no

Reproducible in staging?: n/a Reproducible in production?: n/a

?

Yes, I think so

For #22206 issue, we have added dev, so for this issue too we can say dev

muttmuure · 2023-07-13T11:03:57Z

Not sure how I can reproduce this, so I've asked about getting console logs for iOS here: https://expensify.slack.com/archives/C01SKUP7QR0/p1689246208691599

Julesssss · 2023-07-13T11:24:13Z

Don't think you'll be able to. We should get an internal engineer to verify

melvin-bot · 2023-07-13T12:37:13Z

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

muttmuure · 2023-07-13T12:37:43Z

Adding engineering to ask if they can reproduce.

stitesExpensify · 2023-07-13T17:05:10Z

Confirmed. I am getting the same error on web too

stitesExpensify · 2023-07-13T17:06:08Z

Just kidding that's actually a different error 😅

stitesExpensify · 2023-07-13T17:06:41Z

I am also getting the error described in the OP

melvin-bot · 2023-07-13T17:07:21Z

Job added to Upwork: https://www.upwork.com/jobs/~0151ff298169cff532

melvin-bot · 2023-07-21T18:19:47Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-07-21T18:19:50Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[NoQA] Fix: console warning by adding the missing values to target location for native devices #23042

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@jayeshmangwani requires payment
@0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-21T18:19:51Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

muttmuure · 2023-07-31T14:25:22Z

@jayeshmangwani paid urgency bonus and reporting bonus

@0xmiroslav invited to apply to job on Upwork

0xmiros · 2023-07-31T14:27:43Z

@muttmuure Sorry, can you please hold my payment until further notice? I am working on some stuff due to recent measurements in my region. And update issue to Monthly. Thanks

melvin-bot · 2023-08-03T20:10:53Z

@jayeshmangwani, @stitesExpensify, @muttmuure, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

stitesExpensify · 2023-08-03T20:54:31Z

Holding payment

melvin-bot · 2023-08-07T20:09:25Z

@jayeshmangwani, @stitesExpensify, @muttmuure, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

stitesExpensify · 2023-08-08T14:55:05Z

@0xmiroslav any update? Or are we still holding your payment?

0xmiros · 2023-08-08T14:58:02Z

still holding my payment. will update here when ready

0xmiros · 2023-09-12T10:06:12Z

Not overdue

stitesExpensify · 2023-10-16T17:25:42Z

@0xmiroslav what's the status here?

0xmiros · 2023-10-16T17:27:00Z

Please close this one. I am tracking myself. Thanks

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 30, 2023

melvin-bot bot assigned muttmuure Jun 30, 2023

melvin-bot bot added the Overdue label Jul 3, 2023

melvin-bot bot removed the Overdue label Jul 3, 2023

melvin-bot bot added the Overdue label Jul 7, 2023

melvin-bot bot removed the Overdue label Jul 10, 2023

melvin-bot bot added the Overdue label Jul 12, 2023

melvin-bot bot removed the Overdue label Jul 13, 2023

muttmuure added the Engineering label Jul 13, 2023

melvin-bot bot assigned stitesExpensify Jul 13, 2023

stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 13, 2023

melvin-bot bot changed the title ~~Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button~~ [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button Jul 13, 2023

melvin-bot bot changed the title ~~[$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button~~ [HOLD for payment 2023-07-28] [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button Jul 21, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jul 21, 2023

melvin-bot bot added Daily KSv2 Monthly KSv2 Overdue and removed Weekly KSv2 labels Jul 27, 2023

melvin-bot bot removed the Overdue label Jul 31, 2023

melvin-bot bot added the Overdue label Aug 2, 2023

melvin-bot bot added Overdue and removed Overdue labels Aug 3, 2023

stitesExpensify removed the Daily KSv2 label Aug 8, 2023

melvin-bot bot removed the Overdue label Aug 8, 2023

melvin-bot bot added the Overdue label Sep 11, 2023

melvin-bot bot removed the Overdue label Sep 12, 2023

melvin-bot bot added the Overdue label Oct 13, 2023

melvin-bot bot removed the Overdue label Oct 16, 2023

stitesExpensify closed this as completed Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-07-28] [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button #21953

[HOLD for payment 2023-07-28] [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button #21953

kbecciv commented Jun 30, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 30, 2023

melvin-bot bot commented Jun 30, 2023

kbecciv commented Jun 30, 2023

jayeshmangwani commented Jun 30, 2023

muttmuure commented Jul 3, 2023

muttmuure commented Jul 5, 2023

jayeshmangwani commented Jul 10, 2023

muttmuure commented Jul 10, 2023

jayeshmangwani commented Jul 10, 2023

muttmuure commented Jul 13, 2023

Julesssss commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

muttmuure commented Jul 13, 2023

stitesExpensify commented Jul 13, 2023

stitesExpensify commented Jul 13, 2023

stitesExpensify commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

melvin-bot bot commented Jul 21, 2023

melvin-bot bot commented Jul 21, 2023 •

edited by muttmuure

Loading

melvin-bot bot commented Jul 21, 2023

muttmuure commented Jul 31, 2023

0xmiros commented Jul 31, 2023

melvin-bot bot commented Aug 3, 2023

stitesExpensify commented Aug 3, 2023

melvin-bot bot commented Aug 7, 2023

stitesExpensify commented Aug 8, 2023

0xmiros commented Aug 8, 2023

0xmiros commented Sep 12, 2023

stitesExpensify commented Oct 16, 2023

0xmiros commented Oct 16, 2023

[HOLD for payment 2023-07-28] [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button #21953

[HOLD for payment 2023-07-28] [$1000] Dev: IOS - Getting console warning on the Payments page when pressing Add payment method button #21953

Comments

kbecciv commented Jun 30, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 30, 2023

melvin-bot bot commented Jun 30, 2023

Bug0 Triage Checklist (Main S/O)

kbecciv commented Jun 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

jayeshmangwani commented Jun 30, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

muttmuure commented Jul 3, 2023

muttmuure commented Jul 5, 2023

jayeshmangwani commented Jul 10, 2023

muttmuure commented Jul 10, 2023

jayeshmangwani commented Jul 10, 2023

muttmuure commented Jul 13, 2023

Julesssss commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

muttmuure commented Jul 13, 2023

stitesExpensify commented Jul 13, 2023

stitesExpensify commented Jul 13, 2023

stitesExpensify commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

melvin-bot bot commented Jul 21, 2023

melvin-bot bot commented Jul 21, 2023 • edited by muttmuure Loading

melvin-bot bot commented Jul 21, 2023

muttmuure commented Jul 31, 2023

0xmiros commented Jul 31, 2023

melvin-bot bot commented Aug 3, 2023

stitesExpensify commented Aug 3, 2023

melvin-bot bot commented Aug 7, 2023

stitesExpensify commented Aug 8, 2023

0xmiros commented Aug 8, 2023

0xmiros commented Sep 12, 2023

stitesExpensify commented Oct 16, 2023

0xmiros commented Oct 16, 2023

kbecciv commented Jun 30, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 21, 2023 •

edited by muttmuure

Loading