[HOLD for payment 2023-07-17] [$1000] Dev: Console error appears when opening Workspace Members Page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings -> Workspaces
2. Select any workspace -> Members
3. Refresh the app

Note: without refresh also it can be reproducible.

Expected Result:

No console error

Actual Result:

Error appearing: Warning: Failed prop type: Invalid prop option.keyForList of type number supplied to OptionRow, expected string.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: n/a
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Console.error.on.invite.member.webm

Expensify/Expensify Issue URL:
Issue reported by: @daordonez11
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687887087153099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013423b04ca2e860f4
• Upwork Job ID: 1674868972150136832
• Last Price Increase: 2023-06-30

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Console error appears when opening Workspace Members Page

What is the root cause of that problem?

App/src/pages/workspace/WorkspaceMembersPage.js

Line 336 in 53e4154

keyForList: item.accountID,

Here, item.accountID type is number.
But

App/src/components/optionPropTypes.js

Line 32 in 53e4154

keyForList: PropTypes.string,

keyForList type should be string.

What changes do you think we should make in order to solve the problem?

Convert item.accountID to string type.

App/src/pages/workspace/WorkspaceMembersPage.js

Line 336 in 53e4154

keyForList: item.accountID,

After change:

keyForList: `${item.accountID}`

What alternative solutions did you explore? (Optional)

N/A

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error appears when opening a Workspace.

What is the root cause of that problem?

The root cause is same as mentioned by @jfquevedol2198 in his proposal.

What changes do you think we should make in order to solve the problem?

We should change the propType here to be:

 keyForList: PropTypes.oneOf([PropTypes.number, PropTypes.string])

What alternative solutions did you explore? (Optional)

None

[Pujan92]

Dupe of #21611

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013423b04ca2e860f4

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Pujan92]

@Santhosh-Sellavel @maddylewis plz check this
comment once.

[Santhosh-Sellavel]

@Pujan92 I've checked your comment and @maddylewis's too here. As it's triaged, made external, and ready to move forward let's handle it here.

@maddylewis We need to award reporting bonus to @Pujan92 only as they reported it first!

[Santhosh-Sellavel]

Considering the proposal from the other issue as well

@Pujan92's proposal LGTM!

C+ Reviewed
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

This is a straightforward issue. A couple of proposals suggest making the passed prop with different ways to make it a string So I went selecting the first one and @allroundexperts suggests adding another type to the number of the propTypes That's a good option too, but I don't see any necessity here. Preferably the type String should be good enough for now.

I'll let you take the final call here @Li357, thanks!

[Li357]

Agree we should stick with just a string proptype, and I prefer an explicit coercion with String than string interpolation. @Pujan92 all yours!

[melvin-bot]

📣 @Santhosh-Sellavel You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Pujan92 You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @daordonez11 🎉 An offer has been automatically sent to your Upwork account 🎉

Reporter - [$1000] Dev: Console error appears when opening Workspace Members Page

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Console error appears when opening Workspace Members Page #22203

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21237/files#r1265665581
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Should be caught based on checklist
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

We don't need a separate regression test here, as we used to look for console errors normally!

cc: @Li357 Let me know if differ on any of the above, thanks!

[Santhosh-Sellavel]

Requested payment on ND!

[anmurali]

Approved 1500 for Santhosh on ND

[maddylewis]

is someone able to confirm the following payments were processed:

• @Santhosh-Sellavel ($1500 paid via NewDot)
• @Pujan92 ($1500 auto payment via Upwork)
• @daordonez11 ($250 reporting bonus auto payment via Upwork)

once those are all set i believe we can close this issue - thanks!

[daordonez11]

@maddylewis I rejected reporting, finally @Pujan92 himself did the first report as well.

[maddylewis]

So, @Pujan92 is owed an additional $250?

[daordonez11]

Yeah! I think @Pujan92 total is 1750. He has a bonus for urgency and reporting!

[maddylewis]

additional $250 sent!

[Pujan92]

• @Pujan92 ($1500 auto payment via Upwork)

@maddylewis I think I am yet to receive this. Could you plz check once on it?
Just to inform I haven't received an automatic offer earlier and have not applied to that job which is expired now.

[maddylewis]

• Sent $1500 offer to @Pujan92
• Sent $250 offer to @daordonez11

[daordonez11]

@maddylewis Ill reject the 250! Remember it is 1750 for @Pujan92

[maddylewis]

oh, i see. i thought you were both getting reporting bonuses for this one. I've sent $1750 to @Pujan92 - so i think we're all set here!

[daordonez11]

Yup it's all clear! I always wanna keep things straight 🫡