Profile - New avatar is not saved if changing right after profile name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to NewDot
2. Change profile name
3. Upload new avatar
4. Logout
5. Login

Expected Result:

New avatar should be displayed

Actual Result:

Previous avatar is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6112176_video_64.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lanitochka17]

Not reproduce in Production. Adding Deploy Blocker label

Not.repro.in.Prod.avatar.3006.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[PauloGasparSv]

Taking this over from @aldo-expensify!

[PauloGasparSv]

Can't replicate in staging using my paulogaspar404@gmail.com account

[PauloGasparSv]

Checking the logs from the Requests made for the GH Body evidence

[PauloGasparSv]

I think this is happening because of Pusher and that's why I couldn't replicate in my first tests.

Some times the first request to UpdateDisplayName drags on (examples here and here) so I think the request for uploading the avatar is not even made since I can only see successful calls to UpdateUserAvatar

In logs I see there is a bunch of Push_Service - Sending chunked event attempts for the same event

[PauloGasparSv]

Can't think of any other reason than the mentioned above, I asked for help here!

[aldo-expensify]

ah, good finding, maybe this is not a deploy blocker and it is just the server timing out because we send a ton of pusher events, something like this: https://github.com/Expensify/Expensify/issues/295672

Could that be the case?
Can we reproduce this in staging in an account that doesn't have a ton of contacts?

[PauloGasparSv]

Can we reproduce this in staging in an account that doesn't have a ton of contacts?

Will create a new test account and retry here

[PauloGasparSv]

Worked fine in staging with a new account!

Screen.Recording.2023-06-30.at.20.56.36.mov

(stopped filming bc I had to sign-in again and open my email, after signing in the profile pic was still there):

[PauloGasparSv]

Since I can't reproduce this reliably in new accounts and logs point to Pusher being the problem I'll remove the deploy blocker label from here.

Will re-test this on Monday

[PauloGasparSv]

I just tested with my Expensify account in staging (which has a bunch of chats going on) and everything is working fine!

I compared the logs from today's attempt with the logs of the GH body evidence attempt and now there are waaaaaay less logs related to Push_Service - Sending event (today's log has 229 instances of that but Friday's logs have 7717)

Since it looks like Pusher caused this I'm closing this issue, let's re-open if more people report this problem