Deploy Checklist: New Expensify 2023-06-29

[OSBotify]

Release Version: 1.3.35-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Refactor CloseAccountPage to functional component #19328
• Hide Threads with No Comments from LHN  #19375
• Refactor the EmojiPicker to a functional component #20187
• 17051 - migrated Checkbox to PressableWithFeedback #20257
• Display displayName instead of primaryLogin on the ReportPreview message #20446
• Animate StatusBar background color #20663
• Show the Copilot details if a delegate is set in a report action #21246
• [No QA] Release pending versions before submitting a new version for review #21366
• Fix: Disable admin checkbox and checkbox all #21375
• [NO QA] Add acronym to contributing guide and fix typos #21389
• Is thread concierge report #21481
• Highlight LHN option on context menu press #21613
• Don't index storybook on staging #21646
• Simplify expired code page #21648
• fix: remove assign and make empty avatar header #21659
• Fix - Web - site preview is still visible after flag as intimidation #21195 #21663
• fix: use correct prop type in BaseInvertedFlatlist component #21668
• Migrate withReportOrNotFound.js to function component #21685
• Remove policyMemberList as part of personalDetails migration #21694
• Hotfix search tooltip #21696
• fix: clicking title of url preview don't open site #21717
• Override isLoading only if accountID is invalid #21722
• Fix space inconsistency inserting emoji #21749
• Add sitemap and robots for the help page #21757
• fix missing tooltip on hover of X button while edit message #21764
• update shortcut key of desktop keyboard shortcut menu #21765
• Fix: Date is not being displayed correctly when single digit day is entered #21769
• refactor BaseSidebarScreen to function #21770
• Fix user are able to flag their own comment #21771
• Set new workspace default currency to current user local currency code #21773
• Fix text input label does not deactivate if the input is cleared programmatically #21774
• Fix: Different sections opened clicking on empty space in thread header #21776
• Update CONTRIBUTING.md #21777
• Fix Login page scroll to top on change language #21815
• Fix: Deleting workspace in connect bank account provides update currency error #21819
• Fix text cannot be wrapped in "<{space} text {space}>" in welcome message in new room #21821
• Display not found page with invalid reportID in share code page #21824
• Improve menu item design #21828
• Remove pending-remove thread from LHN #21854
• fix: editing path of link to capital removes link #21858

Internal QA:

• Add logs when calling an API method #21848 - @iwiznia

Deploy Blockers:

• Web - LHN - Console error when clicking FAB button #21944
• FAB menu - Console error when clicking FAB button #21952
• Profile - New avatar is not saved if changing right after profile name #21967
• [HOLD for payment 2023-07-12] [HOLD for payment 2023-07-10] Copilot - Copilot and regular account actions are displayed the same in #admins room #21970
• Workspace avatar reverts to default after reopening the app #22002
• Checkmark appears in incorrect position for paid IOU thread #22021
• [HOLD for payment 2023-07-21] [$1000] Web - Split bill with a new user displays 'undefined owes' on staging #22104

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.35-3 🚀

[Julesssss]

I closed and checked off #21952 as it is a dupe of blocker #21944

[hayata-suenaga]

for #21970, a fix PR has been cherry picked to staging

asked for QA in Slack #qa channel for the PR.

[mvtglobally]

Regression is completed

PR #19328 is failing #21951 & #21952
PR #20446 is failing #21959 repro in prod
PR #21646 is failing #21954. Repro in prod
PR #21246 is failing #21970
PR #21375 is failing #21952
PR #21613 is failing #21952
PR #21668 is failing #21952
PR #21764 is failing #21966. Repro in prod
PR #22006 is pass

[Julesssss]

Taking over deployer duty this week

[Julesssss]

• Closing Web - LHN - Console error when clicking FAB button #21944 as a dupe of [Hold for payment 7-17][$1000] Web - Console log "Invalid Attempt to destructure non-iterable instance" error when clicking 'Add reaction' icon #21833
• Checkmark appears in incorrect position for paid IOU thread #22021 isn't bad enough to be a blocker, and has already been resolved
• Profile - New avatar is not saved if changing right after profile name #21967 is not a blocker

[Julesssss]

More blockers cleared:

• Checked off Refactor CloseAccountPage to functional component #19328, because the raised issues are not blockers
• The fix for [HOLD for payment 2023-07-12] [HOLD for payment 2023-07-10] Copilot - Copilot and regular account actions are displayed the same in #admins room #21970 was Cp'd to staging here. Marking it off
• I can reproduce Workspace avatar reverts to default after reopening the app #22002 (comment) on both staging and prod, so it's not a blocker

[Julesssss]

Checked off the last blocker as I'm able to reproduce on prod. It was also confirmed by others.

[Julesssss]

The final issues to check off the list were those raised as failing due to #21952 (which is a dupe of a known error).

I also validated the only internalQa issue here

[Julesssss]

• App timing looks good, though we seem to now have a slight lag in data timing
• Firebase shows two new crashes, but both are single instances that is not serious enough to hold the release on
• Github is up (currently 🙄)

[Julesssss]