Animate StatusBar background color #20663

roryabraham · 2023-06-13T10:11:49Z

Details

This PR stemmed off of #15462. For now, the only visual change is that the status bar on the homepage w/ the sidebar open matches the sidebar background color

Before

before.mov

After

after.mov

It's implemented in a very generic way, where the same effect can take place on any screen just by adding to the PAGE_BACKGROUND_COLOR constant in the theme file, because we'll be using it more in the future.

Note that this really only has any effect on mobile web, and not all browsers are even affected:

iOS (native) app displays edge-to-edge, so the status bar is transparent
Android (native) as of very recently, the app displays edge-to-edge, to the status bar is transparent
macOS Safari – unaffected by StatusBar.setBackgroundColor
macOS Chrome – unaffected
desktop app – unaffected
iOS Chrome – unaffected
iOS Safari – this is the primary place where this change can be observed.
Android Chrome – my Pixel 4a w/ Chrome is unaffected, but it's possible other devices / browsers may be affected.

Fixed Issues

$ (partial) #12261

Tests / QA Steps (iOS Safari)

Run the app
Verify that the while you're looking at the chat list / sidebar, the status bar matches the background
Open a regular chat. Verify that the StatusBar animates to match the new page background (note: IOU reports happen to have a different background near the top of the screen than a regular chat, I'm considering this out-of-scope for now).
Go back to the sidebar. Verify that the StatusBar animates to match the sidebar background.
Open the settings page. Verify that the StatusBar animates to match the settings page background.
Go back to the sidebar. Verify that the StatusBar animates to match the sidebar background.

Tests / QA Steps (all other platforms)

Nothing – just regression tests. Let me know if you see different behavior in an Android browser. Most likely it will not be a blocker, but since there are a lot of different Android devices I suppose it's possible something unexpected could happen 🤷🏼

Verify that no errors appear in the JS console

Offline tests

Repeat all the same steps offline – it should all happen the same.

PR Author Checklist

Screenshots/Videos

Web

no effect

Mobile Web - Chrome

no effect

Mobile Web - Safari

after.mov

Desktop

no effect

iOS

no effect

Android

no effect

…page

melvin-bot · 2023-06-13T10:32:00Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2023-06-13T10:33:02Z

@sobitneupane requesting your review since you were assigned as C+ in the original PR and issue

sobitneupane

Getting few console errors in Web:

sobitneupane

In addition to Money Request Header, header in Task Page and AttachmentModal has lighter background color and doesn't match with statusBar. I think they are also out of scope of this PR as mentioned in the Test steps.

roryabraham · 2023-06-17T01:34:22Z

@sobitneupane Unless I'm mistaken, all those propTypes errors were not introduced by this code.

roryabraham · 2023-06-17T01:35:38Z

In addition to Money Request Header, header in Task Page and AttachmentModal has lighter background color and doesn't match with statusBar. I think they are also out of scope of this PR as mentioned in the Test steps.

Agree those are out of scope. As stated in the PR description, this PR is implemented in a way that should make it very easy to fix similar issues in the future by just adding the screen + background color to the style file.

# Conflicts: # src/libs/Navigation/NavigationRoot.js

roryabraham · 2023-06-17T01:43:07Z

Updated and conflicts resolved.

sobitneupane

It solves the issue both on IOS/safari and Android/Chrome

Screenshots/Videos

Web

Mobile Web - Chrome

vidma_recorder_edited_23062023_125340.mp4

Mobile Web - Safari

Screen.Recording.2023-06-23.at.12.25.17.mov

Desktop

iOS

Android

Screen.Recording.2023-06-23.at.12.35.31.mov

sobitneupane

@roryabraham I am getting following console error on IOS and android. I am not sure if it is related to this PR or not but it is not reproducible in main. If it is not reproducilbe in your end we are good to merge this.

sobitneupane · 2023-06-23T07:31:55Z

src/libs/Navigation/NavigationRoot.js

+        () => statusBarAnimation.value,
+        () => {
+            const color = interpolateColor(statusBarAnimation.value, [0, 1], [prevStatusBarBackgroundColor.current, statusBarBackgroundColor.current]);
+            runOnJS(StatusBar.setBackgroundColor)(color);


Looks like above console error is related to runOnJS.

roryabraham · 2023-06-26T18:38:59Z

@sobitneupane fixed the console error 👍🏼

Needed to pay attention to the Reanimated docs:

If you want to invoke some function from an external library in runOnJS please wrap it in a separate function

sobitneupane · 2023-06-27T09:12:56Z

@roryabraham There is a new console warning on android.

roryabraham · 2023-06-28T23:56:49Z

@sobitneupane that one is safe to ignore since our app displays edge-to-edge. Let me see about disabling it...

# Conflicts: # src/components/withCurrentReportId.js # src/libs/Navigation/NavigationRoot.js

roryabraham · 2023-06-29T02:01:33Z

@sobitneupane resolved conflicts and that warning

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

vidma_recorder_edited_29062023_142335.mp4

Mobile Web - Safari

Screen.Recording.2023-06-29.at.14.09.32.mov

Desktop

iOS

Screen.Recording.2023-06-29.at.14.10.05.mov

Android

Screen.Recording.2023-06-29.at.14.13.23.mov

OSBotify · 2023-06-29T14:48:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-29T20:37:36Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-03T14:35:27Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-03T15:18:02Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

sobitneupane · 2023-07-24T16:15:29Z

@roryabraham @AndrewGable PR was deployed to production 3 weeks ago. Should I make payment request on newDot?

AndrewGable · 2023-07-24T17:01:27Z

Yes

sobitneupane · 2023-07-24T17:05:08Z

Thanks @AndrewGable. Requested payment on newDot.

JmillsExpensify · 2023-07-27T23:58:45Z

@AndrewGable Can you confirm that the correct payment for @sobitneupane is $1,000 for this PR review?

AndrewGable · 2023-07-28T00:10:00Z

Yes 👍

JmillsExpensify · 2023-07-29T15:45:14Z

Reviewed details for @sobitneupane. These details are accurate based on summary from Business Reviewer (note: No BugZero member assigned to this issue) and are now approved for payment in NewDot.

roryabraham added 10 commits June 13, 2023 01:13

Extract constant for SETTINGS.ROOT screen

27536ec

Add theme color for SETTINGS_ROOT background color

be225ff

Add StatusBar animation for opening settings page

1e5cb78

Pass screenListeners down correctly

f855656

Move animation from AuthScreens to NavigationRoot

273e7e1

Implement correct background color, for homepage instead of settings …

a71d414

…page

Remove all unrelated / unecessary changes

5410e5a

Remove unused import

9359c8a

useWindowDimensions instead of withWindowDimensions

e3d854c

Move useWindowDimensions declaration

b7b58ed

roryabraham self-assigned this Jun 13, 2023

roryabraham changed the title ~~Animate StatusBar background color~~ [WIP] Animate StatusBar background color Jun 13, 2023

roryabraham changed the title ~~[WIP] Animate StatusBar background color~~ Animate StatusBar background color Jun 13, 2023

Fix lint

62c3279

roryabraham marked this pull request as ready for review June 13, 2023 10:31

roryabraham requested a review from a team as a code owner June 13, 2023 10:31

melvin-bot bot requested review from AndrewGable and removed request for a team June 13, 2023 10:31

roryabraham mentioned this pull request Jun 13, 2023

Better default empty states with animation #12261

Closed

roryabraham requested a review from sobitneupane June 13, 2023 10:32

Implement with Reanimated instead

5a0c26a

sobitneupane reviewed Jun 14, 2023

View reviewed changes

roryabraham added 2 commits June 16, 2023 18:36

Merge branch 'main' into Rory-AnimateHeaderBackgroundColor

fd869f0

# Conflicts: # src/libs/Navigation/NavigationRoot.js

Use a hook instead of a HOC to fix propTypes

8bed0d2

sobitneupane reviewed Jun 23, 2023

View reviewed changes

Fix Reanimated error

5f33be8

roryabraham requested a review from sobitneupane June 26, 2023 18:39

roryabraham added 2 commits June 28, 2023 16:58

Merge branch 'main' into Rory-AnimateHeaderBackgroundColor

23766ca

# Conflicts: # src/components/withCurrentReportId.js # src/libs/Navigation/NavigationRoot.js

fix warnings and resolve conflicts correctly

b4a3cb0

roryabraham mentioned this pull request Jun 29, 2023

New preferences page layout #21852

Merged

57 tasks

Fix typo

bfd0cdf

sobitneupane approved these changes Jun 29, 2023

View reviewed changes

AndrewGable approved these changes Jun 29, 2023

View reviewed changes

AndrewGable merged commit c83b2d1 into main Jun 29, 2023

AndrewGable deleted the Rory-AnimateHeaderBackgroundColor branch June 29, 2023 14:44

OSBotify mentioned this pull request Jun 29, 2023

Deploy Checklist: New Expensify 2023-06-29 #21911

Closed

51 tasks

allroundexperts mentioned this pull request Jul 4, 2023

revert usage of InteractionManager in Modal #21865

Merged

57 tasks

situchan mentioned this pull request Jan 3, 2024

Add back animated status bar transition #33200

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Animate StatusBar background color #20663

Animate StatusBar background color #20663

roryabraham commented Jun 13, 2023 •

edited

Loading

melvin-bot bot commented Jun 13, 2023

roryabraham commented Jun 13, 2023

sobitneupane left a comment

sobitneupane left a comment •

edited

Loading

roryabraham commented Jun 17, 2023

roryabraham commented Jun 17, 2023

roryabraham commented Jun 17, 2023

sobitneupane left a comment

sobitneupane left a comment

sobitneupane Jun 23, 2023 •

edited

Loading

roryabraham commented Jun 26, 2023 •

edited

Loading

sobitneupane commented Jun 27, 2023

roryabraham commented Jun 28, 2023 •

edited

Loading

roryabraham commented Jun 29, 2023

sobitneupane left a comment

OSBotify commented Jun 29, 2023

OSBotify commented Jun 29, 2023

OSBotify commented Jul 3, 2023

OSBotify commented Jul 3, 2023

sobitneupane commented Jul 24, 2023

AndrewGable commented Jul 24, 2023

sobitneupane commented Jul 24, 2023

JmillsExpensify commented Jul 27, 2023

AndrewGable commented Jul 28, 2023

JmillsExpensify commented Jul 29, 2023

Animate StatusBar background color #20663

Animate StatusBar background color #20663

Conversation

roryabraham commented Jun 13, 2023 • edited Loading

Details

Before

After

Fixed Issues

Tests / QA Steps (iOS Safari)

Tests / QA Steps (all other platforms)

Offline tests

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 13, 2023

roryabraham commented Jun 13, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

roryabraham commented Jun 17, 2023

roryabraham commented Jun 17, 2023

roryabraham commented Jun 17, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

sobitneupane Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

roryabraham commented Jun 26, 2023 • edited Loading

sobitneupane commented Jun 27, 2023

roryabraham commented Jun 28, 2023 • edited Loading

roryabraham commented Jun 29, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jun 29, 2023

OSBotify commented Jun 29, 2023

OSBotify commented Jul 3, 2023

OSBotify commented Jul 3, 2023

sobitneupane commented Jul 24, 2023

AndrewGable commented Jul 24, 2023

sobitneupane commented Jul 24, 2023

JmillsExpensify commented Jul 27, 2023

AndrewGable commented Jul 28, 2023

JmillsExpensify commented Jul 29, 2023

roryabraham commented Jun 13, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading

sobitneupane Jun 23, 2023 •

edited

Loading

roryabraham commented Jun 26, 2023 •

edited

Loading

roryabraham commented Jun 28, 2023 •

edited

Loading