[$250] mWeb - When tapping back, the header on mWeb stays purple for a couple of seconds

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53686
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro / 18
App Component: Chat Report View

Action Performed:

1. Access staging.new.expensify.com
2. Open FAB > Submit expense.
3. Enter amount > Next.
4. Tap "Submit an expense, get $250" banner.
5. Tap back
6. Verify that: The device navigation bar will not have purple color.

Expected Result:

User expects the header to turn back to green immediately after tapping back

Actual Result:

The top nav menu turns purple for a couple of seconds and stays purple when tapping back, even after exiting the banner page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702727_1735261423209.PR_53686_mweb.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021873780397844730879
• Upwork Job ID: 1873780397844730879
• Last Price Increase: 2025-01-20

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The top nav menu turns purple for a couple of seconds and stays purple when tapping back, even after exiting the banner page

What is the root cause of that problem?

• In here:

App/src/components/CustomStatusBarAndBackground/index.tsx

Line 105 in dae99d1

statusBarAnimation.set(withDelay(300, withTiming(1)));

we delay 300 before updating the status bar color, so leads to the bug "the header on mWeb stays purple for a couple of seconds".

What changes do you think we should make in order to solve the problem?

• We can remove the delay logic since we are already using a timing animation, making the delay unnecessary:

                statusBarAnimation.set(withTiming(1, {duration: 300}));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021873780397844730879

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[huult]

Edited by proposal-police: This proposal was edited at 2025-01-01 17:34:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When tapping back, the header on mWeb stays purple for a couple of seconds

What is the root cause of that problem?

We add a delay here to wait 300ms after the transition starts.

App/src/components/CustomStatusBarAndBackground/index.tsx

Line 105 in 0667cf7

statusBarAnimation.set(withDelay(300, withTiming(1)));

I tested this issue, and it only happens on mWeb, where it stays purple for a couple of seconds. It doesn’t occur on native because of differences in how browsers handle animations, rendering, or event timing compared to native platforms.

What changes do you think we should make in order to solve the problem?

This PR (https://github.com/Expensify/App/pull/33200/files) adds a delay to the status bar animation.

To resolve this issue, we should remove the delay for mWeb to avoid the delay for mweb.

App/src/components/CustomStatusBarAndBackground/index.tsx

Line 105 in 0667cf7

statusBarAnimation.set(withDelay(300, withTiming(1)));

update to

  statusBarAnimation.set(withDelay(Browser.isMobile() ? 0 : 300, withTiming(1)));

or increase the delay time to 150

  statusBarAnimation.set(withDelay(Browser.isMobile() ? 150 : 300, withTiming(1)));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI bug and doesn’t require a unit test

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ahmedGaber93]

Reviewing today

[ahmedGaber93]

While removing the delay can fix the start timing issue, the animation of the status bar and page looks inconsistent, status bar is using fading and page content is using sliding. I think we need to fix that if it is available?

20250105035541052.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@bfitzexpensify, @ahmedGaber93 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ahmedGaber93]

Keeping it open for a better proposal if available #54602 (comment)

[melvin-bot]

@bfitzexpensify @ahmedGaber93 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@bfitzexpensify, @ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?

[ahmedGaber93]

Not overdue, still looking for proposals #54602 (comment).

[melvin-bot]

@bfitzexpensify, @ahmedGaber93 Eep! 4 days overdue now. Issues have feelings too...

[ahmedGaber93]

Asking for proposals on slack https://expensify.slack.com/archives/C01GTK53T8Q/p1737374826065079

[parasharrajat]

@ahmedGaber93 There is no way we can set the animation of the bar color. We achieve fading by gradually changing the color value via js, creating a fade effect. The sliding effects are not possible. Browser controls the theme behaviour.

Also, maybe there was a reason for adding the delay. Can you please look into that as well?

At last, this issue is not worth solving. From a user perspective, I won't argue if animation is fading in or pops up. cc: @Expensify/design @bfitzexpensify

[shawnborton]

Rather than need to color the status bar area, why can't we just show the purple layer behind a transparent status bar?

[shawnborton]

Ah actually I see, that's because this is an mWeb thing... that being said, not sure what we can really do about this, I would be fine just closing personally.

[dannymcclain]

Yeah I would fine closing too. Seems like we don't have a ton of options for "fixing" this, and it's also not a super big deal IMO.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ahmedGaber93]

@ahmedGaber93 There is no way we can set the animation of the bar color. We achieve fading by gradually changing the color value via js, creating a fade effect. The sliding effects are not possible. Browser controls the theme behaviour.

@parasharrajat Thanks for letting me know 🙏

[parasharrajat]

Thanks, all.

@bfitzexpensify We have consensus on closing this.