[HOLD for payment 2023-09-20] [$1000] Workspace Bank Connections: resizing browser when entering Step 3 personal information triggers reload

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Open website and Click on Avatar to open the settings
• Click Workspaces > Any Workspace's name > Cards > Connect bank account > Connect manually (or Choose "Continue with setup" if you have already started with it)
• Reach 3rd step which is "Personal Information" that includes some inputs (First name, Last name, Date, ... etc)
• Resize your browser(should be less than 801px)

Expected Result:

Form should instantly resize and shouldn't reload

Actual Result:

Form throws a "we're taking a look at your information" interstitial and takes a while to reload

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Desktop.2023.06.30.-.20.20.43.04.mp4

screen-capture.34.webm

Expensify/Expensify Issue URL:
Issue reported by: @MahmudjonToraqulov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688112326007589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0158fdd5240a39a3cb
• Upwork Job ID: 1676854347206664192
• Last Price Increase: 2023-09-07
• Automatic offers:
• b4s36t4 | Contributor | 26550577
• mahmudjontoraqulov | Reporter | 26550579

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

@MahmudjonToraqulov can you please break down the repo steps in more detail, listing every action and path needed to reproduce, thanks!

[MahmudjonToraqulov]

@MahmudjonToraqulov can you please break down the repo steps in more detail, listing every action and path needed to reproduce, thanks!

Hi @laurenreidexpensify. Of Course!

Action Performed:

1. Open website and Click on Avatar to open the settings
2. Click Workspaces > Any Workspace's name > Cards > Connect bank account > Connect manually (or Choose "Continue with setup" if you have already started with it)
3. Reach 3rd step which is "Personal Information" that includes some inputs (First name, Last name, Date, ... etc)
4. Resize your browser(should be less than 801px)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0158fdd5240a39a3cb

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

We are working on this issue already cc: @mountiny. This should be on hold. I don't know the tracking issue id yet.

[hoangzinh]

@parasharrajat is it this issue #22185?

[parasharrajat]

No idea. Might be this one #20404.

[mountiny]

Put this on hold

[laurenreidexpensify]

Continuing to hold on #20404

[laurenreidexpensify]

Continuing to hold on #20404

[laurenreidexpensify]

Continuing to hold on #20404

[b4s36t4]

@parasharrajat @tgolen Raised PR here #26983

[MahmudjonToraqulov]

Hey @parasharrajat @tgolen @b4s36t4 @laurenreidexpensify. The price for reporter role should be 250$ as it's created before 30th August. We already discussed about that on channel that the issues created before 30th August is eligible for 250$ payment.

[parasharrajat]

Yes, it will be adjusted.

[MahmudjonToraqulov]

Thanks @parasharrajat. I didn't accept the offer for now. Will you send another one or update it to 250$?

[parasharrajat]

When this issue be ready for payment, we can modify the offer.

[melvin-bot]

🎯 ⚡️ Woah @parasharrajat / @b4s36t4, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @b4s36t4 got assigned: 2023-09-07 17:56:01 Z
• when the PR got merged: 2023-09-11 15:23:26 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix css height not working for onfido #26983

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @b4s36t4 requires payment offer (Contributor)
• @MahmudjonToraqulov requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: issue with third-party code.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Select a workspace from settings
2. Go Bank Account section
3. Complete the flow till step 3 and reach the verification step (onifdo screen).
4. Resize the browser to different widths
5. View of Onfido should be consistently visible across different heights & widths

Do you agree 👍 or 👎 ?

[laurenreidexpensify]

Payment Summary

• External issue reporter - @MahmudjonToraqulov - $250 - waiting for @MahmudjonToraqulov to accept job in Upwork
• Contributor that fixed the issue @b4s36t4 - $500 + 50% urgency bonus = $1000, paid in Upwork
• Contributor+ that helped on the issue and/or PR - @parasharrajat - $500 + 50% urgency bonus = $1000, please request in Newdot

[b4s36t4]

@laurenreidexpensify I think you've made wrong calculations here.

Bounty amount is 1000$ and 50% urgency bonus would become 1500$ right?

[b4s36t4]

Bump on above question @laurenreidexpensify

[MahmudjonToraqulov]

Payment Summary

• External issue reporter - @MahmudjonToraqulov - $250 - waiting for @MahmudjonToraqulov to accept job in Upwork
• Contributor that fixed the issue @b4s36t4 - $500 + 50% urgency bonus = $1000, paid in Upwork
• Contributor+ that helped on the issue and/or PR - @parasharrajat - $500 + 50% urgency bonus = $1000, please request in Newdot

@laurenreidexpensify I didn't accept the offer as it's 50$ as I said before. But didn't accept updated offer. Will you send new one pls? Thanks.

[laurenreidexpensify]

@MahmudjonToraqulov we will pay the updated fee of $250 in Upwork, please accept the offer as it is now even if it's $50, it will be adjusted before payment

[laurenreidexpensify]

Updated Summary -

• External issue reporter - @MahmudjonToraqulov - $250 - waiting for @MahmudjonToraqulov to accept job in Upwork
• Contributor that fixed the issue @b4s36t4 - $1000 + 50% urgency bonus = $1500, paid in Upwork
• Contributor+ that helped on the issue and/or PR - @parasharrajat - $1000 + 50% urgency bonus = $1500, please request in Newdot

[b4s36t4]

@laurenreidexpensify I'm sorry that I'm a bit confused here. I have only got 1000$ in my upwork contract could please have a look at it? I don't see any new upwork jobs or any contract updates or whatsoever. Thanks!

[b4s36t4]

Sorry received, Thanks :). Missed it.

[MahmudjonToraqulov]

@MahmudjonToraqulov we will pay the updated fee of $250 in Upwork, please accept the offer as it is now even if it's $50, it will be adjusted before payment

@laurenreidexpensify I accepted the offer.

[laurenreidexpensify]

Update: Paymens have been issued in Upwork, Rajat will request in NewDot.

[parasharrajat]

Payment requested as per #22035 (comment)

[JmillsExpensify]

$1,500 payment approved for @parasharrajat based on BZ summary.