[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] [HOLD FOR PAYMENT - 13th July] User is taken to the first step after changing currency when splitting a bill

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB > Split bill > Enter an amount > Click next > Select users > Click next
2. While on "Cash" page click on Amount
3. Click on currency
4. Select another currency
5. Click next

Expected Result:

App should take user back to cash page

Actual Result:

App takes user back to the first page

Second example

• FAB icon > Split Bill > Enter amount > Click Next >Select any user > Click Next to open up the split bill page ( Do NOT click split button)
• Now click on the user > Click back and see that the split money page is gone
• We shouldn't be persisting the

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-05.21.13.38.mp4

Recording.1170.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688581054112519

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[s77rt]

• Regression from [navigation-refactor] Use minimal action to navigate inside RHP #21067
• The minimalAction does not contain path which is what the MoneyRequestAmountPage relies on to detect if we are viewing the amount page as initial view or as edit view.
• Fix: Add path to minimalAction here

  App/src/libs/Navigation/linkTo.js

  Lines 35 to 38 in d2de779

  	payload: {
  	name: currentAction.payload.params.screen,
  	params: currentAction.payload.params.params,
  	},

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[bondydaa]

tagging all the users who are on #21067 @adamgrzybowski @abdulrahuman5196 @mountiny @venture1981 @WoLewicki

can you please let us know what you think? Does the proposal above look good and we can have @s77rt spin something up or do you want to take care of this yourselves?

[mountiny]

Solution looks good to me

[abdulrahuman5196]

Sorry, I logged in now only.

@bondydaa It seems there was already a PR and got C+ approved to fix the path not present issue here - #22323

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

Fixed by this PR ❤️

[Julesssss]

We have to keep this issue open for the reporter payment, so I'll just remove the label.

[Santhosh-Sellavel]

@Julesssss Seems you closed the other bug #22302 as a duplicate with the same root cause.

But I reported the other bug earlier in the slack. Please check seems @Expensify/applause is processing an issue in the LIFO order instead of FIFO this causes unnecessary confusion and leads to miscredit for reporters.

[Julesssss]

Thanks, I just updated the reporter field. My bad, I'm in quite a rush today

[Nathan-Mulugeta]

Hey guys I am confused here, it seems like the PR fixed the issue I reported here but the issue @Santhosh-Sellavel reported is still present and is not fixed yet even if the PR is deployed to staging. What is happening here? @Julesssss

[Julesssss]

Hi @Nathan-Mulugeta. Sorry, I see now you are correct. The issues are very similar, but they are in fact distinct 😖

I updated the description and will re-open @Santhosh-Sellavel's issue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add missing path in rhp navigation link #22323

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@bondydaa] Determine if we should create a regression test for this bug.
• [@bondydaa] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bondydaa]

i'm honestly very confused and probably not the best person to fill out the checklist. if someone else more familiar with what went on here can that'd be great.

[s77rt]

• The PR that introduced the bug has been identified: [navigation-refactor] Use minimal action to navigate inside RHP #21067
• The offending PR has been commented on: [navigation-refactor] Use minimal action to navigate inside RHP #21067 (comment)
• A discussion in #expensify-bugs has been started: Not needed. This is a specific bug that could only be caught in tests
• Determine if we should create a regression test for this bug: No

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add missing path in rhp navigation link #22323

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
• [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@bondydaa] Determine if we should create a regression test for this bug.
• [@bondydaa] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Nathan-Mulugeta]

Hey guys when is this report's Payment going to be processed? I am seeing duplicate hold for payment on the title? 🤔 @Julesssss @stephanieelliott

[bondydaa]

yeah sorry not sure what's going on there but we're past all of those dates so @stephanieelliott can we get payment going?

[stephanieelliott]

Extended the offer to you in Upwork @Nathan-Mulugeta, once you accept we will pay out ASAP https://www.upwork.com/jobs/~01ad253d7b84b4117d

[Nathan-Mulugeta]

Just accepted offer @stephanieelliott

[stephanieelliott]

All paid!