[HOLD for payment 2023-07-21] [$1000] Inconsistent Copy Functionality while requesting money: displays email instead of name

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on + and initiate a chat with User B
2. Request money from User B
   You will get [User name ]owes [dollar amount] message
3. Copy the message and paste it
   4 Verify if you are getting [email-id ] owes you instead of [name] owes you

Expected Result:

The copied text should accurately reflect the content of the money request message, including the requester's name, along with the information about the requested dollar amount.

Actual Result:

Instead of showing the requester's name, it displays the email associated with the user, followed by the requested dollar amount.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

copy-bug-UPLOAD.mp4

Recording.1175.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688537874364449

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a3cdcadc000cf6ef
• Upwork Job ID: 1677379528003022848
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent Copy Functionality while requesting money: displays email instead of name

What is the root cause of that problem?

The RCA here is the inconsistency between Copy function (using messageHtml) and the displayingMessage inside ReportPreview (using ReportUtils.getReportPreviewMessage(props.iouReport, props.action) to format the message before displaying).

App/src/components/ReportActionItem/ReportPreview.js

Line 100 in 40c494f

const displayingMessage = ReportUtils.getReportPreviewMessage(props.iouReport, props.action);

What changes do you think we should make in order to solve the problem?

Since we displayed the formatted message for IOU report, we should also copy the formatted text instead of original one. So we should update copy function in here. Below is the pseudocode:

if (isIOUReport) {
 const displayingMessage = ReportUtils.getReportPreviewMessage(iouReport, action);
 Clipboard.setString(displayingMessage);
}

What alternative solutions did you explore? (Optional)

N/A

[MitchExpensify]

Agree that copy and paste should reflect what you are copying and anything else is unexpected for now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a3cdcadc000cf6ef

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[rawalyogendra]

Are we certain that we want to address the "Copy to Clipboard" issue, or should we hide the context menu item for the IOU Report? Since the issue was raised, we have updated the IOU Report to utilize the new style.

We do not have a "Copy to Clipboard" menu for IOUs in the thread, so we should maintain consistency with the new changes.

New Layout

IOU in threads

[melvin-bot]

@narefyev91, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

I think we should focus on fixing the copy/paste pattern via the comment action menu wherever it exists

[narefyev91]

Proposal from @hungvu193 looks good to me #22304 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @avi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire avi for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[hungvu193]

@flodnv @narefyev91 #22633 is ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Inconsistent Copy Functionality while requesting money #22633

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder added to my calendar to pay.

Lets check off the BZ steps above as a next step @narefyev91 🚀

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - not a regression - this is an additional flow - which have never been handled
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - no comments
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - no discussions
• Determine if we should create a regression test for this bug - no need any actions in case this is not a regression fix

[MitchExpensify]

Thank you @narefyev91 !

[MitchExpensify]

Invite sent to @avi-shek-jha for reporting bonus

Paid with bonus and contract ended @hungvu193! 🎉

[MitchExpensify]

Contract ended and paid @avi-shek-jha - Thanks everyone!