Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-17] Bank account - Company name and connected account are shaded and hover shows a "Locked" icon #22340

Closed
6 tasks done
lanitochka17 opened this issue Jul 6, 2023 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open Expensify App or go to staging.new.expensify.com
  2. Login with expensifail account
  3. Create workspace or go to existing workspace
  4. Go to workspace > Bank account
  5. Start and complete connection for any bank account
  6. Check what a connected bank account looks like

Expected Result:

The company name and account are white. Nothing happens when you hover the cursor

Actual Result:

The company name and account are shaded and when you hover over them, the cursor has a “Locked” icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.37.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6118135_BA-Added-cursor-blocked

Bug6118135_BA-Added-prod-staging

Expensify/Expensify Issue URL:

**Issue reported by:**Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 6, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jul 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2023

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@youssef-lr
Copy link
Contributor

I think this was caused by this PR https://github.com/Expensify/App/pull/21372/files, but the MenuItem receives a prop disabled and it makes sense that it gets displayed like that. I'm not sure why though do we want to pass in disabled to the menu item displaying the bank account info. I'm creating a PR to remove it but also discussing this in Slack in case there might be a reason for it.

@Julesssss
Copy link
Contributor

Not a blocker, so I'm not going to CP it.

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 6, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 10, 2023
@melvin-bot melvin-bot bot changed the title Bank account - Company name and connected account are shaded and hover shows a "Locked" icon [HOLD for payment 2023-07-17] Bank account - Company name and connected account are shaded and hover shows a "Locked" icon Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@youssef-lr
Copy link
Contributor

No payments needed here, this was handled internally. Closing!

@melvin-bot melvin-bot bot removed the Overdue label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants