[HOLD for payment 2023-07-14] [$1000] Connect Bank - Text on 'Almost Done' page is crossed out if user select to 'Start Over' offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App, create/open workspace and start to add bank account in workspace
2. Exits in the middle of the flow (after page 'Company Information' or 'Personal Information')
3. Return to the flow again > Settings > Workspaces > Connect bank account
4. Go offline
5. Select Start Over on the page 'Almost done!'
6. Tap 'Back' on the info page 'You appear to be offline'

Expected Result:

User returns to 'Almost Done!' page. Text on this page is NOT grayed-out and crossed-out.

Actual Result:

User returns to 'Almost Done!' page. Text on this page IS grayed-out and crossed-out.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.10.4

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6044119_BA-start-over-cross-out.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfc0043de4c187cd
• Upwork Job ID: 1656123288985350144
• Last Price Increase: 2023-05-31

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Connect Bank - Text on 'Almost Done' page is crossed out if user select to 'Start Over' offline

What is the root cause of that problem?

The text in ContinueBankAccountSetup is wrapped with OfflineWithFeedback that's why when we when back from offline state, we will see it crossed out because OfflineWithFeedback component will apply strike through (crossed out) to their children in few cases (when offline and action is delete).

App/src/pages/ReimbursementAccount/ContinueBankAccountSetup.js

Lines 66 to 74 in d120f6a

	<OfflineWithFeedback
	pendingAction={pendingAction}
	errors={errors}
	shouldShowErrorMessage
	onClose={BankAccounts.resetReimbursementAccount}
	>
	<Text>
	{props.translate('workspace.bankAccount.youreAlmostDone')}
	</Text>

What changes do you think we should make in order to solve the problem?

In case we don't want this text to be crossed out (strike through), we can move it above the OfflineWithFeedback.
So it will look like this:

                        <Text>
                            {props.translate('workspace.bankAccount.youreAlmostDone')}
                        </Text>
                        <OfflineWithFeedback
                            pendingAction={pendingAction}
                            errors={errors}
                            shouldShowErrorMessage
                            onClose={BankAccounts.resetReimbursementAccount}
                        >

If we want the description text is blur when it's offline like original, we can add style for the text when it's offline.

What alternative solutions did you explore? (Optional)

None.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The you're almost done description text is strikethrough when Start Over in connect bank account while offline.

What is the root cause of that problem?

When we press Start Over, it will set the pending action to Delete.

App/src/libs/actions/ReimbursementAccount/resetFreePlanBankAccount.js

Lines 27 to 37 in d120f6a

	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.REIMBURSEMENT_ACCOUNT,
	value: {
	shouldShowResetModal: false,
	isLoading: true,
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	},
	},
	],

A component wrapped with OfflineWithFeedback with pending action of delete will strikethrough the children if it's currently offline.

App/src/pages/ReimbursementAccount/ContinueBankAccountSetup.js

Lines 66 to 94 in d120f6a

	<OfflineWithFeedback
	pendingAction={pendingAction}
	errors={errors}
	shouldShowErrorMessage
	onClose={BankAccounts.resetReimbursementAccount}
	>
	<Text>
	{props.translate('workspace.bankAccount.youreAlmostDone')}
	</Text>
	<Button
	text={props.translate('workspace.bankAccount.continueWithSetup')}
	onPress={props.continue}
	icon={Expensicons.Bank}
	style={[styles.mv4]}
	iconStyles={[styles.buttonCTAIcon]}
	shouldShowRightIcon
	large
	success
	isDisabled={Boolean(pendingAction) || !_.isEmpty(errors)}
	/>
	<MenuItem
	title={props.translate('workspace.bankAccount.startOver')}
	icon={Expensicons.RotateLeft}
	onPress={() => BankAccounts.requestResetFreePlanBankAccount()}
	shouldShowRightIcon
	wrapperStyle={[styles.cardMenuItem]}
	disabled={Boolean(pendingAction) || !_.isEmpty(errors)}
	/>
	</OfflineWithFeedback>

You can notice the start over text is also getting strikethrough. I guess the Continue with setup button doesn't get the strikethrough is a different issue (maybe even intentional).

Looking at the PR that introduces this change, the strikethrough looks like intentional: 8aea1c2#r1119420530

However, I don't think it makes sense to have the strikethrough because the component is static, that is not showing a user input (chat message, workspace, etc.). We are not deleting the you're almost done text.

What changes do you think we should make in order to solve the problem?

Remove pendingAction from the OfflineWithFeedback at ContinueBankAccountStep

This is how it will looks

[melvin-bot]

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Alright, I can reproduce this but I think it makes for an interesting consideration. What's the right offline pattern for these workspace titles?

However, I don't think it makes sense to have the strikethrough because the component is static, that is not showing a user input (chat message, workspace, etc.). We are not deleting the you're almost done text.

I completely agree with @bernhardoj that this should not be the pattern. I'm not sure why we'd go with that given that, to the contributor's point, nothing has been deleted.

cc @shawnborton @trjExpensify for visibility.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bfc0043de4c187cd

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @iwiznia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[JmillsExpensify]

Oh perfect. Our favorite pattern B expert is also assigned to the issue.

[shawnborton]

Yeah, I agree with @bernhardoj's proposal but I think both of the option rows should have an equal 50% opacity reduction... currently it looks like the green start over icon is not reduced opacity.

[bernhardoj]

Yeah, they look different. Looking at the code, they use different components. Continue with setup uses Button, while Start over uses MenuItem. If disabled,

1. Button will reduce its opacity to 50%
2. MenuItem will change the text and arrow icon color to #8B9C8F (theme colors icon)

I'm not sure if we want to change how the MenuItem disabled looks like here.

[shawnborton]

I think we should make MenuItem work the same as buttons do and reduce the opacity to 50%.

[rushatgabhane]

perfect!

@iwiznia let's hire @bernhardoj for their proposal. The root cause is correct.

C+ reviewed 🎀👀🎀

[bernhardoj]

Just as a reference, this is how it will looks after changing the opacity to 50% instead of changing the text color if disabled.

Also, this change will affects other component that use MenuItem, example:

Before:

I would also vote to reduce the opacity when disabled as it's easier for a user to know that the menu is disabled. However, I think it could also confuse the user in case the opacity is reduced not because it's disabled, but because there is a pending action. So, visually there is no clear distinction between the disabled menu and the pending action menu (to be fair, Button is also the same 😄, so I guess let's just go with reducing the opacity).

[melvin-bot]

@iwiznia, @JmillsExpensify, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

However, I think it could also confuse the user in case the opacity is reduced not because it's disabled, but because there is a pending action. So, visually there is no clear distinction between the disabled menu and the pending action menu (to be fair, Button is also the same 😄, so I guess let's just go with reducing the opacity).

Yes this is a fair point, though I think that we should start with consistency first and then we can re-evaluate.

[melvin-bot]

@iwiznia, @JmillsExpensify, @rushatgabhane, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@iwiznia, @JmillsExpensify, @rushatgabhane, @bernhardoj Still overdue 6 days?! Let's take care of this!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@iwiznia, @JmillsExpensify, @rushatgabhane, @bernhardoj 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix continue bank account text is crossed out when initiating Start Over while offline #21372

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Handle error in workspace's bank account page #15394

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15394/files#r1261979353

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1689224158805169

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Made a manual request on new dot - https://staging.new.expensify.com/r/3850666924900332
Anu will pay it when she gets the chance

[JmillsExpensify]

Thank you!

[JmillsExpensify]

Apologies @bernhardoj I realized that I still need to circle back and pay you. I've extended a contract via this job: https://www.upwork.com/jobs/~0107e09c5063b9db1c. It doesn't appear that this is eligible for an urgency bonus, though let me know if I've misunderstood.

[bernhardoj]

Accepted!

It doesn't appear that this is eligible for an urgency bonus

yes, it's not eligible

[iwiznia]

Seems this is mostly ready, so not unassigning myself, but if this does not get closed, @JmillsExpensify please unassign and re-assign another engineer since I am going on sabbatical

[iwiznia]

How can it be overdue if I just commented?! 😂

[JmillsExpensify]

Alright, all paid out! Closing this one.