Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-10] Match Report Header and LHN Avatars #22468

Closed
grgia opened this issue Jul 8, 2023 · 16 comments
Closed

[HOLD for payment 2023-08-10] Match Report Header and LHN Avatars #22468

grgia opened this issue Jul 8, 2023 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Jul 8, 2023

Part of #20486. We want to match the header avatars to the LHN avatar patterns.

Used for both #22333 and #22332 so I am separating out into its own issue.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0197cbf143b0f44102
  • Upwork Job ID: 1677617651206991872
  • Last Price Increase: 2023-07-08
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jul 8, 2023
@grgia grgia self-assigned this Jul 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0197cbf143b0f44102

@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review and removed Overdue labels Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

@parasharrajat, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@parasharrajat
Copy link
Member

On, I will close this asap. Just waiting on a question on the PR.

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

@parasharrajat, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@parasharrajat
Copy link
Member

parasharrajat commented Jul 26, 2023

We are close. A recent change was made on the PR to solve a bug that I think might cause issues so I am trying to revert the code which caused the issue and migrate it properly.

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 3, 2023
@melvin-bot melvin-bot bot changed the title Match Report Header and LHN Avatars [HOLD for payment 2023-08-10] Match Report Header and LHN Avatars Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @parasharrajat does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 9, 2023
@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as resolved.

@grgia
Copy link
Contributor Author

grgia commented Aug 16, 2023

@MitchExpensify would you kindly help with the $1000 C+ Review Payment for Internal PR to @parasharrajat?

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@MitchExpensify
Copy link
Contributor

Payment summary:

$1000 to @parasharrajat via NewDot

Please go ahead and request the payment @parasharrajat 👍

@MitchExpensify
Copy link
Contributor

Based on this SO we can close this out in the meantime seeing as no BZ steps are needed here 🚀

@parasharrajat
Copy link
Member

Payment requested.

@JmillsExpensify
Copy link

Reviewed the details for @parasharrajat. This $1,000 payment is approved via NewDot based on the BZ summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants