-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-26] Update Expense Report View #22332
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01809b70d955011b47 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh ( |
@trjExpensify @shawnborton right now we don't show the three dots on the report view and only show it on the single transaction view. Is the new design with the three dots correct? What shows when you click them? |
Yeah, I left a similar comment over in the other issue but I think we should stay consistent with the overflow menu on all of the various report type views (chat, thread, task, report, expense, etc). And then in the very least, it always has a pin option but it also might have:
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-26. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Triggered auto assignment to @conorpendergrast ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
@conorpendergrast could you help to handle the $1000 C+ payment to @fedirjh for #22484 |
I would happily do so |
Contract sent via Upwork, and I'll be able to see that here |
|
@conorpendergrast Thank you, accepted. |
Paid! @grgia Is that everything? If so, close it out |
@grgia I'm assuming that this is all done. Closing out. Please reopen if I'm wrong! |
Part 1 of #20486 (comment)
Related to #20486
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: