Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-26] Update Expense Report View #22332

Closed
grgia opened this issue Jul 6, 2023 · 18 comments
Closed

[HOLD for payment 2023-07-26] Update Expense Report View #22332

grgia opened this issue Jul 6, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Jul 6, 2023

Part 1 of #20486 (comment)
Related to #20486

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01809b70d955011b47
  • Upwork Job ID: 1676899649993342976
  • Last Price Increase: 2023-07-06
@grgia grgia added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jul 6, 2023
@grgia grgia self-assigned this Jul 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01809b70d955011b47

@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

@grgia grgia changed the title Update Expense Report Headers Update Expense Report View Jul 6, 2023
@grgia
Copy link
Contributor Author

grgia commented Jul 8, 2023

@trjExpensify @shawnborton right now we don't show the three dots on the report view and only show it on the single transaction view. Is the new design with the three dots correct? What shows when you click them?

@shawnborton
Copy link
Contributor

Yeah, I left a similar comment over in the other issue but I think we should stay consistent with the overflow menu on all of the various report type views (chat, thread, task, report, expense, etc). And then in the very least, it always has a pin option but it also might have:

  • call
  • delete
  • etc

@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 19, 2023
@melvin-bot melvin-bot bot changed the title Update Expense Report View [HOLD for payment 2023-07-26] Update Expense Report View Jul 19, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 25, 2023
@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label Jul 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as off-topic.

@grgia
Copy link
Contributor Author

grgia commented Jul 28, 2023

@conorpendergrast could you help to handle the $1000 C+ payment to @fedirjh for #22484

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 28, 2023
@conorpendergrast
Copy link
Contributor

conorpendergrast commented Jul 31, 2023

I would happily do so

@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2023
@conorpendergrast
Copy link
Contributor

Contract sent via Upwork, and I'll be able to see that here

@conorpendergrast
Copy link
Contributor

conorpendergrast commented Jul 31, 2023

  • External issue reporter: N/A - no one
  • Contributor that fixed the issue: N/A - no one
  • Contributor+ that helped on the issue and/or PR: @fedirjh for $1000. Offer link. Contract link.
  • Urgency bonus: No

@fedirjh
Copy link
Contributor

fedirjh commented Jul 31, 2023

@conorpendergrast Thank you, accepted.

@conorpendergrast
Copy link
Contributor

Paid! @grgia Is that everything? If so, close it out

@conorpendergrast
Copy link
Contributor

@grgia I'm assuming that this is all done. Closing out. Please reopen if I'm wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants