[HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] [$1000] IOU - No settlement button in the IOU report header

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #22484

Action Performed:

1. Open staging.new.expensify.com
2. Receive an IOU from user A
3. On user B, click on the IOU request to open the report page

Expected Result:

On Account B, ensure that the settlement button appears inline with the avatar in the header

Actual Result:

No settlement button appear at the report header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b09206b5c6870312
• Upwork Job ID: 1681403325956915200
• Last Price Increase: 2023-07-18

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

This must be coming from here I think #22484

cc @grgia

[mountiny]

@lanitochka17 In the screenshot, the button is missing for the requestor. there should not be settlement button in such case

[mountiny]

Taking this over, testing locally

[mountiny]

Works fine for iou and expense reports.

Payer on left, payee on right

[mountiny]

I can produce now so reopening in case

[mvtglobally]

@mountiny Not seeing the button with my accounts as well

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - No settlement button in the IOU report header

What is the root cause of that problem?

We are not rendering children in HeaderWithBackButton anymore -

App/src/components/HeaderWithBackButton/index.js

Lines 95 to 97 in a75e329

	<View style={[styles.reportOptions, styles.flexRow, styles.pr5, styles.alignItemsCenter]}>
	{shouldShowDownloadButton && (
	<Tooltip text={translate('common.download')}>

This is a regression from this PR. They were shown before -

App/src/components/HeaderWithBackButton.js

Lines 202 to 204 in 0b00e1c

	<View style={[styles.reportOptions, styles.flexRow, styles.pr5, styles.alignItemsCenter]}>
	{this.props.children}
	{this.props.shouldShowDownloadButton && (

What changes do you think we should make in order to solve the problem?

We need to destructure children from props after line 22 and render them after line 95.

What alternative solutions did you explore? (Optional)

NA

[mountiny]

@Nikhil-Vats Thanks for the proposal, the problem was a mixture of two PRs coming together. The Header componet is missing passing the children

[mountiny]

Sorry @Santhosh-Sellavel for the ping, handling this through other contributor

[mountiny]

@johncschuster noting that we have agreed with @Nikhil-Vats on $500 for their first "C+ trial" PR review and checklist

[jasperhuangg]

A fix was CP'd for this to staging, and it looks like this isn't happening anymore, closing. Thanks @mountiny @luacmartins @Nikhil-Vats!

[Nikhil-Vats]

We are still pending payments here @jasperhuangg

[mountiny]

@johncschuster $500 payment for @Nikhil-Vats should be pending for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing settlement button #23129

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing settlement button #23129

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Nikhil-Vats requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[johncschuster]

Sorry I missed your comment, @vitHoracek! I've left you a DM in NewDot for one clarifying point.

[johncschuster]

Summary for payment:

External issue reporter - Applause
Contributor that fixed the issue - Internal (@vitHoracek)
Contributor+ that helped on the issue and/or PR - @Nikhil-Vats - $500 (to be paid via Upwork)

[Nikhil-Vats]

Offer accepted @johncschuster .

[johncschuster]

Sent the invite!

[Nikhil-Vats]

Offer accepted.

[johncschuster]

Paid! 🎉