[HOLD for 0xmiroslav] [$1000] Web - Test 'Assignee` is cut of from the bottom

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on Floating Plus button.
2. Click on assign task.
3. Enter any title.
4. Click on Next

Expected Result:

The assignee 'g' should not be cut-off

Actual Result:

The assignee 'g' is cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-15.at.9.51.37.PM.1.mov

Recording.3731.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689438298925379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa67583e6a2f7981
• Upwork Job ID: 1681403142046572544
• Last Price Increase: 2023-07-18

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[DEV] Test 'Assignee` is cut of from the bottom

What is the root cause of that problem?

The applied style has small line height styles.lhNormal.

App/src/components/MenuItem.js

Line 99 in 6e5b07c

styles.lhNormal,

What changes do you think we should make in order to solve the problem?

We need to increase the current line height lhNormal, I think lineHeightLarge is a good enough, but we can also increase it to lineHeightXLarge if we found any issues in PR.

1. Create new style lhLarge after lhNormal.

    lhLarge: {
        lineHeight: variables.lineHeightLarge,
    },

2. Change style in MenuItem to be lhLarge instead of lhNormal
   

   App/src/components/MenuItem.js

   Line 99 in 6e5b07c

   styles.lhNormal,

What alternative solutions did you explore? (Optional)

apply the new style to this MenuItem only
pass lhLarge style in MenuItem prop descriptionTextStyle in NewTaskPage

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

“g” is cut off at the bottom in assign task page

What is the root cause of that problem?

App/src/components/MenuItem.js

Lines 96 to 104 in d71a2be

	const descriptionTextStyle = StyleUtils.combineStyles([
	styles.textLabelSupporting,
	props.icon && !_.isArray(props.icon) ? styles.ml3 : undefined,
	styles.lhNormal,
	props.title ? descriptionVerticalMargin : StyleUtils.getFontSizeStyle(variables.fontSizeNormal),
	props.descriptionTextStyle,
	isDeleted ? styles.offlineFeedback.deleted : undefined,
	]);

We are using font size 15px and line height 16px. It makes the character cut off at the bottom

What changes do you think we should make in order to solve the problem?

We should use lineHeightLarge instead of lineHeightNormal, then line-height will be 18px, and all character is displayed fully

What alternative solutions did you explore? (Optional)

We also can use smaller fontSize in here

Result

<img width=“1107" alt=“Screenshot 2023-07-17 at 15 14 55” src=“https://github.com/Expensify/App/assets/129500732/3e12c6fd-5169-495a-b477-e666b06f072b”>

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem

Assignee text is cut-off in Menu item of task.

What is the root cause of this issue?

This was introduced in this PR: #22484
Here we used to have a style styles.lineHeightNormal which seemed to be a non-existent style and had no effect. But in the above mentioned PR, this non-existent style was identified and replaced with styles.lhNormal which seems to have caused this.

What changes do you think are needed in order to solve this problem?

We should just get rid of the style styles.lhNormal altogether because it will fix this problem and behave as it did before.

What alternative approach did you explore?

We can also set the line height to something more than normal like lh20 or lh140Percent which already exist.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pecanoro]

@grgia It seems this is coming from your PR here #22484, do you want to fix it since you know the styles better? Otherwise, I can try to fix the styles myself.

[jasperhuangg]

Super minor display bug, don't think this needs to be a blocker, gonna remove the deploy blocker label

[pecanoro]

@jasperhuangg In that case, I will assign the external label!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa67583e6a2f7981

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[pecanoro]

@JmillsExpensify friendly bump!

[pecanoro]

@JmillsExpensify pinged you in newdot in case you missed this issue!

[JmillsExpensify]

Apologies for the delay! @0xmiroslav I believe the Upwork contract is waiting on you to accept? It's showing a pending status on my end.

[0xmiros]

@JmillsExpensify can you please check https://expensify.slack.com/archives/C01SKUP7QR0/p1692226249296529?thread_ts=1691559426.466079&cid=C01SKUP7QR0 and send new offer to https://www.upwork.com/freelancers/~01cf406998cdcfc7ae?

[JmillsExpensify]

Do you mind asking having them apply here: https://www.upwork.com/jobs/~01aa67583e6a2f7981. Upwork makes it hard to find this profile and hire them for this specific job.

[0xmiros]

@JmillsExpensify Applied, thanks

[melvin-bot]

@JmillsExpensify, @pecanoro, @esh-g, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pecanoro]

Not overdue

[0xmiros]

Not overdue

[JmillsExpensify]

@0xmiroslav let us know when you're ready to receive payments. Going to put this on hold until then.

[pecanoro]

Still on HOLD

[pecanoro]

Still on HOLD

[JmillsExpensify]

@0xmiroslav similar to other issues, I'm going to close this issue since I'm overwhelmed with GH assignments. Please reach out to us when you are ready for payment.