[HOLD for payment 2023-09-06] [$1000] Tooltip content only have comma in content when hovering group chat with non-register users

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new group chat with non-register users
2. Go to Search page, search the group and hover the subscript avatar of the group chat.
3. Observer the tooltip content.

Expected Result:

Tooltip content should have the user email.

Actual Result:

Tooltip content only have comma

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-10.at.22.03.48.mov

Recording.1239.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688794537559139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f7d4bfbb8b38ac0
• Upwork Job ID: 1678800589651423232
2023-07-11
• Automatic offers:
• hoangzinh | Contributor | 25797512
• hungvu193 | Reporter | 25797513

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltips not working for groups that have all new members.

What is the root cause of that problem?

We're filtering out the personalDetailsList here to include only those accounts that have a login key available.

What changes do you think we should make in order to solve the problem?

We need to remove this line.

What alternative solutions did you explore? (Optional)

I'm not sure why this was added in the first place. A better solution can be proposed if the reasons are clarified.

[sakluger]

This only happens when the group chat users have not yet validated their Expensify accounts, we should still fix this though.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017f7d4bfbb8b38ac0

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[syedsaqib12]

Please re-state the problem that we are trying to solve in this issue.
Tooltips is not working properly.

What changes do you think we should make in order to solve the problem?
We need to remove tooltip.

[melvin-bot]

📣 @syedsaqib12! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip content only have comma in content when hovering group chat with non-register users

What is the root cause of that problem?

Agree with @allroundexperts , we are filtering out personalDetails that doesn't have login

App/src/libs/OptionsListUtils.js

Lines 620 to 624 in 12d54e8

	// We're only picking personal details that have logins set
	// This is a temporary fix for all the logic that's been breaking because of the new privacy changes
	// See https://github.com/Expensify/Expensify/issues/293465 for more context
	// eslint-disable-next-line no-param-reassign
	personalDetails = _.pick(personalDetails, (detail) => Boolean(detail.login));

And then, in createOption utils, we pass above filtering personalDetails when get option's icons, it would return empty string here

App/src/libs/ReportUtils.js

Line 753 in 12d54e8

lodashGet(personalDetails, [accountID, 'login'], lodashGet(personalDetails, [accountID, 'displayName'], '')),

What changes do you think we should make in order to solve the problem?

I could not access this GH issue https://github.com/Expensify/Expensify/issues/293465 to read more context, but I feel instead of filtering personalDetails here, we should only filter when we create allPersonalDetailsOptions here

App/src/libs/OptionsListUtils.js

Lines 696 to 701 in 12d54e8

	let allPersonalDetailsOptions = _.map(personalDetails, (personalDetail) =>
	createOption([personalDetail.accountID], personalDetails, reportMapForAccountIDs[personalDetail.accountID], reportActions, {
	showChatPreviewLine,
	forcePolicyNamePreview,
	}),
	);

[rushatgabhane]

reviewing today

[rushatgabhane]

I don't think we can just remove this line. It says that it's a temorary fix for things that were breaking because of privacy changes.

App/src/libs/OptionsListUtils.js

Lines 616 to 620 in 2e3f8c2

	// We're only picking personal details that have logins set
	// This is a temporary fix for all the logic that's been breaking because of the new privacy changes
	// See https://github.com/Expensify/Expensify/issues/293465 for more context
	// eslint-disable-next-line no-param-reassign
	personalDetails = _.pick(personalDetails, (detail) => Boolean(detail.login));

[rushatgabhane]

@sakluger could we please get some context from https://github.com/Expensify/Expensify/issues/293465
(it's internal only)

Maybe they plan to fix this after some time? idk

[melvin-bot]

@sakluger, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sakluger]

I reopened that GH issue and left a comment to try to figure out which way to go from here. Basically, we modified getOptions to only use personal details that have logins set because it was breaking certain flows otherwise.

The two options I can think of are to either remove the extra commas, or try to figure out some other way display the email addresses of the unregistered users. I think we'll probably end up removing the extra commas, but let's wait to see until I get an answer.

[jasperhuangg]

Not sure if we should get rid of that filter right now. If we do it'll break a whole bunch of other important functionality, including Tasks and IOUs.

We haven't entirely decided what we want to do yet about that, we should probably have a discussion about this change, and HOLD this issue on that for the time being.

[allroundexperts]

If we do it'll break a whole bunch of other important functionality,

@jasperhuangg Curious about which functionality breaks because of this?

[jasperhuangg]

A lot of our Tasks and IOU functionality was written under the assumption that the personalDetails you could look up in their options list always contained logins.

But as a result of a different privacy project for a conference, we sometimes don't send logins back anymore with certain personal details. As a result, a lot of the options list used in Tasks and IOUs were crashing the app, so we added this filter as a temporary fix, while we sorted out how we were going to rewrite a lot of this functionality to rely on accountIDs (which are always sent back with personalDetails) instead of logins.

[hoangzinh]

@jasperhuangg how do you think about my proposal here #22593 (comment)

I suggested just change the place we filter out personalDetails without login when we build personalDetails options list.

[rushatgabhane]

@Beamanator i think we forgot to remove hold from this issue

[rushatgabhane]

I think we can lift hold and move forward

[jasperhuangg]

HOLD removed, thanks for keeping things moving!

[jasperhuangg]

@Beamanator I can take over here, sorry for the delay

[jasperhuangg]

@hoangzinh looking forward to reviewing your PR!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hoangzinh got assigned: 2023-07-27 23:09:11 Z
• when the PR got merged: 2023-08-24 18:27:20 UTC
• days elapsed: 19

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Tooltip content only have comma in content when hovering group chat with non-register users #23807

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor) - $1000
• @rushatgabhane does not require payment (Eligible for Manual Requests) - $1000
• @hungvu193 requires payment offer (Reporter) - $250

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

I went ahead and paid out the reporter bounty to @hungvu193

@rushatgabhane could you please complete the BZ checklist by tomorrow? That way we can approve your manual payment right away after the 7-day hold.

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Only consider personal details with logins set in OptionsListUtils.getOptions #21159

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21159/files#r1316237566

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request here - https://staging.new.expensify.com/r/3100659356231581

[sakluger]

Thanks @rushatgabhane! I assigned @JmillsExpensify to handle the payment request.

Everyone else has been paid out, I'll leave this open so Jason can approve the final payment.

[sakluger]

I checked with @JmillsExpensify and I'm good to close any issue that is only pending the manual request payment, since he sees all payment requests directly in NewDot.

[JmillsExpensify]

Can I get a payment summary with amount so that I can pay @rushatgabhane?

[sakluger]

@JmillsExpensify here you go!

Summarizing payouts for this issue:

Bug reporter: @hungvu193 $250 (paid via Upwork)
Contributor: @hoangzinh $1000 (paid via Upwork)
Contributor+: @rushatgabhane $1000 (Manual Request)

[JmillsExpensify]

$1,000 payment approved for @rushatgabhane based on summary.