Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-21] Report Preview cards merge with the background when hovered over #22625

Closed
Gonals opened this issue Jul 11, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff

Comments

@Gonals
Copy link
Contributor

Gonals commented Jul 11, 2023

Problem
Report previews merge with the background when hoverer over:
Screenshot 2023-07-11 at 12 27 05 PM

Solution

Have them look like iouPreviews:
Screenshot 2023-07-11 at 12 27 12 PM

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010af1f6e82f6cd735
  • Upwork Job ID: 1678712759318437888
  • Last Price Increase: 2023-07-11
@Gonals Gonals added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Jul 11, 2023
@Gonals Gonals self-assigned this Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010af1f6e82f6cd735

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@Gonals Gonals added the Improvement Item broken or needs improvement. label Jul 11, 2023
@Gonals
Copy link
Contributor Author

Gonals commented Jul 11, 2023

Quick style change. No need for C+

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 11, 2023
@Gonals
Copy link
Contributor Author

Gonals commented Jul 11, 2023

Seems like the PRs now always get a C+ assigned, so adding them here

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 14, 2023
@melvin-bot melvin-bot bot changed the title Report Preview cards merge with the background when hovered over [HOLD for payment 2023-07-21] Report Preview cards merge with the background when hovered over Jul 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
  • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@thesahindia] Determine if we should create a regression test for this bug.
  • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 20, 2023
@twisterdotcom
Copy link
Contributor

@thesahindia - please just request payment on NewDot. Going to complete the checklist as this was internal.

@JmillsExpensify
Copy link

@Gonals Do you mind confirming how much @thesahindia should be paid for this issue? Ted is out on parental leave.

@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

@twisterdotcom, @Gonals, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Gonals
Copy link
Contributor Author

Gonals commented Sep 26, 2023

@Gonals Do you mind confirming how much @thesahindia should be paid for this issue? Ted is out on parental leave.

They reviewed the PR, so I guess that's $500, right?

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@thesahindia
Copy link
Member

I believe it's $1000. The review was done before the change in compensation.

@melvin-bot melvin-bot bot added the Overdue label Sep 28, 2023
@Gonals
Copy link
Contributor Author

Gonals commented Sep 29, 2023

True. $1000 it is

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@twisterdotcom, @Gonals, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@twisterdotcom
Copy link
Contributor

@JmillsExpensify is there anything else I can do here? Or do we just need to approve this payment?

@twisterdotcom
Copy link
Contributor

@JmillsExpensify I believe this is just waiting on some confirmation from you, after @Gonals provided the answer to your reopening query.

@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@JmillsExpensify
Copy link

$1,000 payment approved for @thesahindia based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants