-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-26] IOU - Money request header is not greyed out in offline mode #22640
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @danieldoglas ( |
I will create a PR |
Assigning @aimane-chnaif @madmax330 since this is a regression related to an issue you're managing. |
Also I don't think this is a deploy blocker |
Agreed, removing the label |
@madmax330, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-26. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
@madmax330, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue |
Not overdue |
Not overdue |
@aimane-chnaif we can close this out right? Since it's not a new issue, but one that stems from the PR for the other issue there's not payment to make right? |
right, no payment needed here. Let's close |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #21918
Action Performed:
Expected Result:
Money request header is greyed out
Actual Result:
Money request header is not greyed out
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.39.5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6123789_20230711_211526.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
The text was updated successfully, but these errors were encountered: