Deploy Checklist: New Expensify 2023-08-21

[OSBotify]

Release Version: 1.3.56-24
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Refactor code to improve unread marker logic #18637
• Migrate ReportActionCompose to function #18648
• Change Display Name to Functional Component #20953
• Fix Not Found view briefly appears on workspace members and invite pages #21387
• Fix/19496 2fa steps refactor #23060
• display the not found page when attachment is deleted. #23143
• Migrate Composer. web #23359
• Apple & Google Sign In #23673
• The edited message does not dynamically update between the main chat and sub-thread #23706
• Automatically enable memory only keys when payload size of reconnectapp/openapp is too large #23831
• Migrate SwipableView to functional component #23928
• fix: revalidate upon input and refocus if error occurs #23995
• migrated ThreeDotsMenu/index.js to a functional component #24017
• Display NVP-enabled Control policies in NewDot #24021
• Adapt Split Bill to workspace chats #24058
• Fix multiple Onfido screens #24079
• Signin rhp #24083
• fix reply in thread does not have from link in header #24113
• fix: do not focus composer when space is pressed #24162
• [navigation-refactor] Fix browser history for complex navigation actions #24165
• Fix currency handling - always handle backend amounts as if they are in cents #24175
• Fix: prevent signing in to wrong account in the desktop app via magic link #24207
• fix: maintain native behavior when dragging links #24211
• Display receipts in chat #24235
• Only show workspace chats as participants for distance #24236
• prevent blur on composer when click on mini context menu item #24252
• refactor: refactor money request form #24274
• 16185 - Migrate PDFPasswordForm.js to function component #24290
• Add Waypoint Editor #24301
• Integrate Mapbox in App #24306
• fix: replace new report with preexisting #24320
• Migrate reportAction.originalMessage to transactions #24345
• When openOnAdminRoom is set, do not redirect first time users #24346
• fix: invoke useWindowDimensions #24353
• fix:21706 remove optimistic user info from personal details list #24355
• Update hover color for lounge access icon #24358
• fix: prevent unnecessary overlay from being added while opening RIGHT_DOCKED modals #24361
• setting required field errors in app #24379
• Add an action method for creating a distance request #24385
• iou console fix #24386
• Hide delete option for report actions in DMs for initiator #24396
• Update context menu correctly for thread first chat #24404
• Fix: Replies number changes for a second after deleting the parent message #24409
• Migrate addplaidbankaccount.js to function component #24410
• Show reply in thread for IOU and Task. #24412
• Enable avatar preview for workspace & thread replies #24425
• fix: prevent browser form validation #24428
• formatting phone login #24441
• DateUtils refactor, remove moment from the code, timezone fixes. #24446
• Ignore hasOutstandingIOU from child iouReport #24448
• Put link previews behind a beta for now #24475
• The country name is not displayed when you start entering "cote" or "cote d'Ivoire" without a diacritic, and instead you see "no results found" #24477
• Fix unexpected back navigation in Bank Connect flow #24480
• Fix Link Navigation relative to current Environment #24483
• Hide reports with error from task share somewhere list #24506
• disable iOS keyboard avoiding view on screens without text input #24511
• 24265 suggestion list not display when open group chat #24512
• Clear validate error on refresh #24513
• Fix/23003: Placeholders are overlapping with auto-filled text #24525
• Display status in chats #24526
• Fix report action is still detected as attachment even after we delete it #24539
• [NO-QA] Untrack accidentally committed file #24540
• Fix Popover Emoji-reacted does not close for User B when User A deletes the message #24543
• fix: sync draft and edit status of thread first chat #24544
• link config #24547
• Add the ability to search for rooms by reportID in NewDot #24548
• delete nested tag inside pre tag #24549
• fix workspace avatar shows U before reverting to actual avatar in IOU view #24551
• [NO QA] Fix android production build path #24558
• [NO QA] Update buildable name for iOS prod flavour scheme #24560
• Use release certs for Android production build #24562
• Fix reveal message button is copiable even though it's not selectable #24563
• Fix: Unauthorized Task Reopening by Anonymous User in Incognito Mode #24566
• fix: 24232 console log error when pressing ESC key #24567
• Create Enable-Location-Access-on-Web.md #24571
• Do not show currency tooltip when we can't change it #24576
• Disable timezone list if automatic timezone is turned on #24577
• [NO-QA] Update Browserstack Android build path #24583
• 23438 historical IOUs appearing in LHN under pinned chats #24586
• Center Tab Selector Item #24587
• Hide transaction detail and dismiss the edit modal when the request is deleted #24590
• Update context.xml #24592
• [No QA]Set an archive name for iOS #24594
• [NO QA] Add policyCategories collection key #24595
• Update Styling for Suggestion Pagination section of Search Feature #24598
• [No QA]Specify output_name in fastlane to match up with previous names #24599
• [No QA]Add comma to new output_name key #24600
• [No QA] Ensure that no other updates are made to Onyx while missing Onyx updates are fetched and applied #24607
• Fix chat hidden from LHN when last message is attachment #24609
• Fix transaction amount sign and clean up unnecessary pay money request transaction  #24613
• 16165 - Migrate index.js to function component #24625
• Resolve AdHoc build issues #24629
• Card Settings - Rename PaymentsPage to WalletPage #24632
• Followup/23961 edit request autofocus and date #24634
• disabling submitOnEnter(task-desc) for mobile browsers #24636
• [Step 3] Remove CARD_LIST key from NewDot #24637
• Update default port to 8082 #24638
• Call OpenDraftWorkspaceRequest when mounting the MoneyRequestConfirmPage for policyExpenseChats #24640
• [NO QA] [Step 4] Add CORPORATE_CARD_LIST key #24641
• fix:copy-update admin only posting rooms #24643
• fix non-toggle popover to toggle #24645
• Create SaaStr Landing Page with new DemoSetupPage component #24649
• Make all the Pusher logs hmmm and improve the state_change event #25158
• fix: always show go back to home screen link on FullPageNotFoundView #25164
• Followup/23961 edit request headers #25399
• [No QA] Allow mapbox token to stop listening to all listeners and add a network listener #25408
• Bump Onyx to 1.0.61 #25426
• [No QA] Make sure only the active leader is managing the mapbox token #25431
• Add subscriber to money request view to immediately update view #25435
• Update semver to fix vulnerability #25444
• Enable setting created and merchant fields for new requests #25449
• Fix cursor shifting to end while editing messages #25456
• Fix able to scroll horizontally out of screen width on sign in page #25457
• Make sure to get correct total for optimistic paid message #25474
• [NoQA] Move regexp #25475
• Change the way we parse a date because it was converting in wrong timezone date #25476
• [22523] Fix path calculation #25479
• Manually resolve conflicts on staging #25502
• Add link to moderation help from conference playbook #25504
• Revert "Revert "Integrate Mapbox in App"" (i.e. bring the original PR back) #25506
• [CP Staging] fix: do not show link on just BlockingView #25516
• fix: 23563 empty screen shows for a brief moment #25522
• Update text for search results that don't return anything #25541
• Offline mode: Crash after deleting Split Bill request - 25481 #25611
• [CP Staging] Polish displaying receipts in chat #25613
• Do not parse to reportActionID to int when building comment linking url #25623
• [No QA] Consolidate mapbox SDK setup in with setupNode #25628
• [No QA] Pass required secrets to setupNode #25630
• [No QA] Forward secrets to called workflows #25631
• [No QA] Add some notes about secrets in GitHub Actions #25635
• Fix iframe for Google Sign-In #25645
• [No QA] Configure MapBox separately from node #25651
• [No QA] Configure MapBox before running pod install #25655
• [CP Staging]Remove zero prefix from time #25665
• Make sure to use the link as a key for transaction #25682
• fix: don't show merchant info for split bill #25684
• [CP Staging] Remove global styling in BaseHTMLEngineProvider #25691
• Fix for frozen UI state on desktop after redirect from 3rd party sign in #25706
• Fix Apple Sign In token path #25710
• [CP Staging] Pass merchant back when editing money requests #25719
• Revert "Merge pull request #24544 from eh2077/21527-fix-sync-draft-and-edit-status-of-thread-first-chat" #25724
• Fix admin post only welcome message #25726
• Only pass strings with a valid number to Str.fromUSDToNumber #25734
• [CP] impose max length on merchant name in money requests #25738
• [CP Staging] Unread messages fix: change from Etc/UTC to UTC #25772
• Revert "fix: revalidate upon input and refocus if error occurs" #25781
• Hide Overflow of Google Signin Button [DEPLOY BLOCKER] #25789
• [CP Staging] fix "Google icon on sign in page shows overflow horizontal scrolling bars" #25799
• [CP Staging] Stop showing receipt images for cash requests #25800
• [CP staging] Disable assigning users who do not yet exist to tasks #25806

Internal QA:

• Allow any admin to see workspace settings #23626 - @mountiny

Deploy Blockers:

• [HOLD for payment 2023-08-28] [$1000] Offline mode: Crash after deleting Split Bill request #25481
• [HOLD for payment 2023-09-04] Console error on opening the report #25616
• [HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit #25626
• Log in - Apple & Google Sign in buttons are too close and are touching outlines #25637
• [HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU #25640
• [HOLD for payment 2023-09-04] Workspace - 'WS chat closed' message is expanded to full screen even if there were messages #25644
• New contacts are not shown as Recents/contacts #25647
• [HOLD for payment 2023-09-04] Text is overlapping in the main chat window #25648
• [HOLD for payment 2023-09-27] [HOLD for payment 2023-09-06] [$1000] Mention list doesnt automatically popup when typing @ #25649
• [$500] [Awaiting payment]The formatting of the time is zero-prefixed #25650
• Chat - New marker displayed briefly when chat is opened #25673
• [HOLD for payment 2023-09-04] Security - notFound.goBackHome message appears after disabling 2FA authentication #25674
• Chat - Chat history disappears after creating a task #25676
• [HOLD for payment 2023-09-04] Chat - New message overlaps edited tag to a quote #25678
• Desktop - Sign in - The app freezes after logging in via the "Sign in with Google" function #25679
• [HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680
• Request money - Console error shows up when opening request money page #25683
• [HOLD for payment 2023-09-04] [$1000] System throws an error while requesting money if a long description & marchant value is given #25685
• [HOLD for payment 2023-09-11] [$1000] Request money - Address field shows error when saved again and it becomes empty after refresh #25686
• [HOLD for payment 2023-09-04] Task -App becomes unresponsive when Assign Task to user that doesn't have a NewDot account yet #25688
• [$500] [HOLD for payment 2023-09-04] Cleared Statement Reappears Briefly When Deleting Comment Changes #25690
• [HOLD for payment 2023-09-07] [$500] Redirect icon is not highlighted on hover #25692
• [$1000] IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant #25694
• Map not showing in DistanceRequest tab of MoneyRequest page #25696
• [HOLD for payment 2023-09-04] Login - Can't sign in with Apple #25697
• [HOLD for payment 2023-09-27] [$1000] "Hm... it's not here" message displays for a moment when viewing deleted money request that has sub-thread #25698
• [HOLD for payment 2023-09-04] BA - Expensify crashes when entering test transactions #25705
• Login - Unable to log in manually with locked gmail but able to log in with Google #25713
• [HOLD for payment 2023-09-04] Wrong edit message shown in IOU report description when editing date #25715
• [$250] Web - Console error shows up when creating room and opening room chat #25717
• [HOLD for payment 2023-09-04] Room - Missing text in 'You missed the party in' message when 'Admin only' room is deleted #25718
• Login - Focus remains on last digit after login with wrong link and requesting new code #25728
• [HOLD for payment 2023-09-04] Greenline line doesn't appear after the mark of a message as unread (iOS) #25737
• IOU Scan - Receipt is not displayed on IOU preview in chat until IOU preview is opened #25767
• [HOLD for payment 2023-09-04] Login - Sign in with Google logo jumps after the login page is refreshed #25768
• Web - New line marker on Task does not disappear when sending or receiving a message #25776
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$1000] Chat - Accessing an attachment via link that is not found shows the error page twice #25779
• [PAID - Reporting] IOU - When the name of the Merchant is too long, text is out of field in IOU report #25780
• Web - Receipt page tries load when an attachment is present #25784
• Wallet- The wallet page keeps loading infinitely and "add payment method" is greyed out #25787
• [$1000] Deeplink - No prompt to open in app when navigating to deep link as logged-out web user #25790
• [$500] [HOLD for payment 2023-09-04] App crashes when reciever clicking on an edited money request #25795
• [hold for payment 2023-08-30] [$1000] Google icon on sign in page shows overflow horizontal scrolling bars #25797
• Dev: The search field does not automatically focus when selecting a member for a money request #25803

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mountiny]

#23626 this is from previous deploy

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.56-0 🚀

[roryabraham]

Unlocking this because staging deploys are broken. We hopefully fixed them but need to trigger a full deploy from main. Slack context: https://expensify.slack.com/archives/C03V9A4TB/p1692661899493529

[roryabraham]

New staging deploy running here, re-locking this checklist.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.56-2 🚀

[sakluger]

@roryabraham I went through the list of blockers and categorized them by status to help you out a bit! 🆗 means that the deployblocker label was removed (I checked these off above). ✔️ means that the linked PR was merged (I'm not sure if it's okay to check these off above yet). 📋 means that there is a PR in review but not merged. ❗ means that the issue either has no PR yet or is unassigned.

🆗 #25481 - Likely fixed, deploy blocker label removed
✔️ #25616 - PR merged
🆗 #25626 - NAB
🆗 #25637 - NAB (dupe of another issue)
✔️ #25640 - PR merged
📋 #25644 - PR merged
🆗 #25647 - NAB
✔️ #25648 - PR merged
📋 #25649 - PR in review
✔️ #25650 - PR merged
❗ #25673 - No PR
📋 #25674 - PR in review
❗#25676 - No PR
#25678 - PR merged
📋 #25679 - Draft PR
🆗 #25680 - NAB
🆗 #25683 - Closed
❗#25685 - No PR
❗#25686 - No PR
❗#25688 - No PR
❗#25690 - No PR, unable to repro in DEV
🆗 #25692 - NAB
❗#25694 - No PR
❗#25696 - No PR
❗#25697 - No PR
❗#25698 - No PR
❗#25705 - No PR

[roryabraham]

Ok, let's check back in. Going to use a similar system as @sakluger:

❗ – no status
🆗 – demoted / NAB
📋 – solution in progress
🏁 – solution merged + CP'd, needs retest
✅ – resolved

---

✅ #25481
🏁 #25616, should be fixed by #25613 in 1.3.56-7
🆗 #25626
🏁 #25637, this was closed in favor of #25638, but should be fixed by #25645 in 1.3.56-10
🏁 #25640, should be fixed by #25684 in 1.3.56-8
🏁 #25644, solution CP'd to staging in 1.3.56-9
🆗 #25647
🏁 #25648, solution CP'd to staging in 1.3.56-9
📋 #25649, may be fixed by #25660
🏁 #25650, should be fixed by #25665 in 1.3.56-3
❗ #25673
🏁 #25674, should be fixed (or rather, made irrelevant) by #25516 in 1.3.56-4
✅ #25676
🏁 #25678, should be fixed by #25691 in 1.3.56-9
✅ #25679, fixed by #25706 in 1.3.56-14
🆗 #25680
🆗 #25683
🏁 #25685, should be fixed by #25738 in 1.3.56-18
❗ #25686
❗ #25688
🏁 #25690, should be fixed by #25724 in 1.3.56-15
🆗 #25692
❗ #25694
🆗 #25696
🏁 #25697, should be fixed by #25710 in 1.3.56-11
❗ #25698
🏁 #25705, should be fixed by #25734 in 1.3.56-17
❗ #25713
🏁 #25715, should be fixed by #25719 in 1.3.56-13
🆗 #25717
🏁 #25718, should be fixed by #25726 in 1.3.56-16
📋 #25728, should be fixed by #25741, needs review
🏁 #25737, should be fixed by #25772 in 1.3.56-19

---

The following PRs have been CP'd for this checklist:

• Offline mode: Crash after deleting Split Bill request - 25481 #25611
• [No QA] Forward secrets to called workflows #25631
• [CP Staging]Remove zero prefix from time #25665
• [CP Staging] fix: do not show link on just BlockingView #25516
• [No QA] Configure MapBox separately from node #25651
• [No QA] Configure MapBox before running pod install #25655
• [CP Staging] Polish displaying receipts in chat #25613
• fix: don't show merchant info for split bill #25684
• [CP Staging] Remove global styling in BaseHTMLEngineProvider #25691
• Fix iframe for Google Sign-In #25645
• Fix Apple Sign In token path #25710
• Make sure to use the link as a key for transaction #25682
• [CP Staging] Pass merchant back when editing money requests #25719
• Fix for frozen UI state on desktop after redirect from 3rd party sign in #25706
• Revert "Merge pull request #24544 from eh2077/21527-fix-sync-draft-and-edit-status-of-thread-first-chat" #25724
• Fix admin post only welcome message #25726
• [CP Staging] Unread messages fix: change from Etc/UTC to UTC #25772

These should be automatically added to the checklist but due to a known 🐛 are not, so I'm going to manually add them and update the version on the checklist accordingly.

[mvtglobally]

@roryabraham TR Regression is completed we are wrapping last CPs/PRs

Current PR summary
#23673 is failing #25697 & #25679
#24301 is failing #25683
#24306 is failing #25696
#24235 - Pending validation on all platforms
#24346 - passed on Web/MWeb, not able to validate on Desktop/Native. Ok to check off?
#24379 - Pending validation on all platforms
#24512 - failing #24265. repro in PROD
#24513 - failing #23813.
#24525 - Pending validation on all platforms
#24571 & #25504 - PROD QA. Ok to check off?
#24577 - Failing #24516
#24625 - failing #21210, repro in prod checking off
#24637 - Blocked due to #18375. Can you QA internally?
#24638 - Pending validation on all platforms
#24643 - failing #25717
#24640 - Pending validation on all platforms
#25158 - Pending validation on all platforms
#25399 - Failing #22640
#25426 (comment) - Ok to check off?
#25476 - failing #25441
#25506 - Failing #25674 & #25696
#25691 - failing #25767
#25706 - failing #25679
#25734 - Pending validation on all platforms
#25738 - Pending validation on all platforms

[amyevans]

I checked off #25679 after its PR was cherry-picked and I retested on staging.

[luacmartins]

Checking off #25767. The feature is still a WIP, we're aware of it and have a PR in review to fix it.

[lindboe]

We made a fix for #25697, but it looks like that isn't tracked here -- do we need to do anything to get this into staging @roryabraham?

[mountiny]

Checking #25737 off, fixed in staging

[roryabraham]

We made a fix for #25697, but it looks like that isn't tracked here -- do we need to do anything to get this into staging @roryabraham?

@lindboe there's a known 🐛 that causes cherry-picked PRs to not automatically appear on the checklist. In general you shouldn't need to do anything to have them appear.

In this case, I did manually add the fix to the checklist I believe: #25710

[luacmartins]

Checking off #25784. Not repro on main anymore, the feature is still a WIP and the bug doesn't affect App functionality.

[roryabraham]

#25649 is a valid bug but not bad enough to block deploy imo. Going to check it off.

[luacmartins]

Checking off #25686 since it was demoted to NAB.

[luacmartins]

Checking off #25694. This is the intended behavior and we are changing the default merchant name here

[mountiny]

Checking #25616 off its fixed

[roryabraham]

Checking off #25676, not reproducible

[mountiny]

checking #25476 off based on this comment #25441 (comment) tested just now

[roryabraham]

Demoted #25713, checking it off

[roryabraham]

#25718 is fixed, checking it off

[roryabraham]

#25728 is fixed, checking it off

[aldo-expensify]

#25705 is fixed, just tested it, checking it off

[roryabraham]

We are CPing #25789 to fix #25768 in 1.3.56-21

[roryabraham]

#25776 is expected behavior, checking it off

[roryabraham]

#25679 and #25697 are resolved, checking off #23673

[roryabraham]

#25683 is resolved, checking off #24301

[roryabraham]

#25696 is NAB / being fixed behind a beta. So I'm checking off #24306

[roryabraham]

For #24346, it seems like we don't have deeplinks configured for the routes in question, and it's very unlikely that a first time user will have the app installed anyways. Checking it off

[roryabraham]

#24512 - failing #24265. repro in PROD

Checking this off as NAB. @mvtglobally In the future you can feel free to check these off as long as the issue is documented.

[roryabraham]

#24513 - failing #23813.

Asked for more details in the PR: #24513 (comment)

Going to check this off as NAB, it just doesn't fix the original issue it was meant to fix it seems.

[roryabraham]

#24571 & #25504 - PROD QA. Ok to check off?

Yes, checking these off

[marcaaron]

Demoting #25779. edge case issue imo and not a common flow people would typically be running into.

[roryabraham]

#24577 is a QA fail but not a blocker. Left a comment requesting more details in the PR

[roryabraham]

#24643 was associated with two issues:

• [$250] Web - Console error shows up when creating room and opening room chat #25717
• [HOLD for payment 2023-09-04] Room - Missing text in 'You missed the party in' message when 'Admin only' room is deleted #25718

But both are demoted / resolved so I'm going to check off #24643

[marcaaron]

We can check off #25768 after the CP from @dangrous. But we now have #25797 to look at 😄

[roryabraham]

#25399 is a QA fail but not a deploy blocker, checking it off

[roryabraham]

Checking off #25506 as a dupe of #24306

[roryabraham]

As @marcaaron mentioned, #25789 caused another deploy blocker, but we're going to resolve it separately so I'm checking #25789 off

[roryabraham]

Demoting #25787

[roryabraham]

Demoting #25803 and checking it off

[roryabraham]

#25673 is not reproducible and ultimately a somewhat minor bug that doesn't affect usability. Demoting it and checking it off

[marcaaron]

Internal QA on #24637 ✅

[roryabraham]

#25797 is passing on staging now ✅ , checking it off along with #25799

[roryabraham]

#25688 is passing on staging now ✅, checking it off along with #25806

[roryabraham]