Fix currency handling - always handle backend amounts as if they are in cents #24175

aldo-expensify · 2023-08-04T23:19:11Z

Details

The backend ALWAYS stores "cents" for transactions and reports, it doesn't matter if the currency has 0, 1, 2 or 10 decimals.

The frontend at some point started sending something different when we started diving the "frontend amount" by a number depending on the number of decimals of the currency:

0 decimals currency -> divide by 0
1 decimals currency -> divide by 10
2 decimals currency -> divide by 100
3 decimals currency -> divide by 1000

This is wrong, they always should be multiplied and divided by 100 to convert.

The library used in the backend and the library used in the frontend (Intl) format the RSD currency with 0 decimals. A client needed decimals, so we updated the backend to display RSD with two decimals.
Now, we have to force the frontend to also do the same so we don't get bug reports because of inconsistent behaviour.

PayPal: The URL for paying with paypal is generated correctly for any currency now.

When we split a bill, we need to consider the number of decimals of a currency so we don't produce amounts that are incompatible with the number of decimals of the currency. After splitting, it returns back to the format of "cents" that we use for storing amounts.

Fixed Issues

$ #23235
$ https://github.com/Expensify/Expensify/issues/300539
$ #19792
$ #24510

PROPOSAL:

Tests

Request money, verify decimals

Create money requests in currencies that have decimals and currencies without decimals, for example:
- BHD: 3 decimals, the third decimal will be truncated because we can't store it in the database, but it still should display with 3 decimal places after the . (the third decimal will always be a 0)
- JPY: 0 decimals
- VND: 0 decimals
- USD: 2 decimals
- RSD: 2 decimals (special case, should be tested)
Verify that the LHN preview looks correctly formatted and inside the chats too. You should verify that the offline optimistic data is also correct.

Verify paypal payment URL

Add Paypal as a payment method
Create a workspace
In your workspace expense chat, request money in USD (may require tweaking beta permissions to be able to do this)
Try to pay with paypal
Verify that the URL and the Paypal page shows the right amount in USD
Go to the workspace settings
Change the workspace's currency to JPY
In your workspace expense chat, request money in JPY (may require tweaking beta permissions to be able to do this)
Try to pay with paypal
Verify that the URL and the Paypal page shows the right amount in JPY

Verify split bill amounts

Start a bill split from the green + button in the top left corner
Choose 10 JPY
Add 3 other accounts to the split (your account is the 4th account)
Verify that the split is 3 JPY, 3 JPY, 3 JPY and 1 JPY for you (the account making the split)
Do another split with other 3 accounts, but choose 10 USD as the amount
Verify that each part is 2.5 USD

Verify that no errors appear in the JS console

Offline tests

Same as the "online", just check that the currencies amounts are correctly formatted.

QA Steps

Create money requests in currencies that have decimals and currencies without decimals, for example:
- BHD: 3 decimals, the third decimal will be truncated because we can't store it in the database, but it still should display with 3 decimal places after the . (the third decimal will always be a 0)
- JPY: 0 decimals
- VND: 0 decimals
- USD: 2 decimals
- RSD: 2 decimals (special case, should be tested)
Verify that the LHN preview looks correctly formatted and inside the chats too. You should verify that the offline optimistic data is also correct.

Verify paypal payment URL

Add Paypal as a payment method
Create a workspace
In your workspace expense chat, request money in USD (may require tweaking beta permissions to be able to do this)
Try to pay with paypal
Verify that the URL and the Paypal page shows the right amount in USD
Go to the workspace settings
Change the workspace's currency to JPY
In your workspace expense chat, request money in JPY (may require tweaking beta permissions to be able to do this)
Try to pay with paypal
Verify that the URL and the Paypal page shows the right amount in JPY

Verify split bill amounts

Start a bill split from the green + button in the top left corner
Choose 10 JPY
Add 3 other accounts to the split (your account is the 4th account)
Verify that the split is 3 JPY, 3 JPY, 3 JPY and 1 JPY for you (the account making the split)
Do another split with other 3 accounts, but choose 10 USD as the amount
Verify that each part is 2.5 USD

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-04.at.5.16.05.PM.mov

Screen.Recording.2023-08-04.at.5.17.36.PM.mov

Screen.Recording.2023-08-04.at.5.56.17.PM.mov

Paypal:

Screen.Recording.2023-08-04.at.6.14.12.PM.mov

Split bill:

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-08-04.at.5.44.28.PM.mov

Desktop

Screen.Recording.2023-08-04.at.5.23.57.PM.mov

iOS

Screen.Recording.2023-08-04.at.5.39.51.PM.mov

Android

melvin-bot · 2023-08-04T23:44:37Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-08-04T23:45:34Z

@thesahindia @MariaHCD One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2023-08-04T23:45:48Z

Reassigned review to @sobitneupane since they are the C+ here: #23235

aldo-expensify · 2023-08-05T00:46:27Z

My Android dev environment is not working at the moment, so I wasn't able to take videos and test. I don't think this is platform dependent at all.

aimane-chnaif · 2023-08-05T00:50:18Z

My Android dev environment is not working at the moment

@aldo-expensify are you facing the same issue as https://expensify.slack.com/archives/C01GTK53T8Q/p1691020867484089 or another one?

aldo-expensify · 2023-08-05T01:21:03Z

src/libs/CurrencyUtils.js

+
+        // We are forcindg the number of decimals because we overridden the default number of decimals in the backend for RSD
+        // See: https://github.com/Expensify/PHP-Libs/pull/834
+        minimumFractionDigits: currency === 'RSD' ? getCurrencyDecimals(currency) : undefined,


The library used in the backend and the library used in the frontend (Intl) format the RSD currency with 0 decimals. A client needed decimals, so we updated the backend to display RSD with two decimals.
Now, we have to force the frontend to also do the same so we don't get bug reports because of inconsistent behaviour.

I ONLY enabled this for RSD because otherwise the formatting will be inconsistent between backend and frontend for currencies with more than 2 decimals.

aldo-expensify · 2023-08-05T01:21:32Z

tests/unit/currencyList.json

@@ -622,7 +622,6 @@
    "RSD": {
        "symbol": "РСД",
        "name": "Serbian Dinar",
-        "decimals": 0,


See this: https://github.com/Expensify/App/pull/24175/files#r1284934337

aldo-expensify · 2023-08-05T01:25:06Z

Hmm, I brought back an issue that happens when splitting JPY (or other currencies with less decimals):

The splitted amounts don't add up to the total.

I'll make this a draft meanwhile I fix that again.

aldo-expensify · 2023-08-15T18:24:47Z

Split bill amount doesn't add up to total. In the following screenshot, all the splits sums to $10.11 (expected: $10.12) which is not the case in staging.

Good catch, it seems to be due to precision errors for decimal numbers operations:

I'll fix it and add a test

aldo-expensify · 2023-08-15T18:50:36Z

@aldo-expensify RSD in LHN doesn't have decimals

Seems like this is backend problem. I can see the payload of the RequestMoney request including the decimals (1012), but the response has removed them.

Payload:

Response:

The front end optimistic data seems to be doing it well:

Please ignore this problem when reviewing, I'll take care of it in a follow up PR

aldo-expensify · 2023-08-15T18:51:39Z

@sobitneupane thanks for the thorough review, you can continue the rest:

10.12 USD splitting incorrectly: Fixed ✅
10.12 RSD showing as 10 RSD in the LHN: backend bug, I'll fix it in a follow up, I don't want to hold this PR on that because it keeps running into conflicts.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2023-08-16T09:28:48Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/CurrencyUtils.js

Co-authored-by: Maria D'Costa <maria@expensify.com>

aldo-expensify · 2023-08-16T17:35:46Z

Fixed the comment with the suggested changes

OSBotify · 2023-08-16T18:15:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:20:28Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:27:01Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:10:02Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rayane-djouah · 2024-07-24T15:40:53Z

FYI, this PR didn't catch that the BE only supports up to two decimal places and users can't enter more than two decimals in the amount field in the app. There's a mismatch because although users can't put in more than two decimals, the third decimal shows as zero on the IOU confirmation page and elsewhere in the app for currencies (like BHD) that use more than 2 decimals. We fixed it by setting maximumFractionDigits to 2 in NumberFormatOptions, so now any currency with more than 2 decimals will only show two in the UI. more details here: #43945 (comment)

Fix currency handling

b77293a

aldo-expensify mentioned this pull request Aug 4, 2023

Optimistically generate transactions in existing IOU flows #17718

Merged

56 tasks

aldo-expensify self-assigned this Aug 4, 2023

Stop passing currency

cf1f0d0

aldo-expensify mentioned this pull request Aug 4, 2023

fix amount based on currency #22281

Merged

57 tasks

aldo-expensify added 2 commits August 4, 2023 16:39

Fix offline behaviour

1921074

Remove unused stuff

538524b

aldo-expensify marked this pull request as ready for review August 4, 2023 23:44

aldo-expensify requested a review from a team as a code owner August 4, 2023 23:44

melvin-bot bot requested review from thesahindia and removed request for a team August 4, 2023 23:44

aldo-expensify mentioned this pull request Aug 4, 2023

[HOLD for payment 2023-08-28] [$1000] IOU - LAK currency is not displayed correctly inside the badge #23235

Closed

6 tasks

aldo-expensify requested review from sobitneupane and a team and removed request for thesahindia August 4, 2023 23:45

melvin-bot bot requested review from MariaHCD and removed request for a team August 4, 2023 23:45

melvin-bot bot requested a review from thesahindia August 4, 2023 23:45

aldo-expensify removed the request for review from thesahindia August 5, 2023 00:18

aldo-expensify added 3 commits August 4, 2023 17:52

RSD has 2 decimals now

5a9d343

More tests / make RSD consistent with backend

f72fe23

Fix paypal payment url

dfbc548

aldo-expensify commented Aug 5, 2023

View reviewed changes

aldo-expensify added 2 commits August 15, 2023 11:32

Avoid precision errors and add test

8c7770d

Merge branch 'main' of github.com:Expensify/App into aldo_fix-decimals

bb6695e

Style

3d6f57a

aldo-expensify requested a review from sobitneupane August 15, 2023 18:59

sobitneupane approved these changes Aug 16, 2023

View reviewed changes

melvin-bot bot requested a review from Gonals August 16, 2023 09:28

MariaHCD previously approved these changes Aug 16, 2023

View reviewed changes

src/libs/CurrencyUtils.js Outdated Show resolved Hide resolved

aldo-expensify dismissed MariaHCD’s stale review via 1d465e2 August 16, 2023 17:35

Fix comment

1d465e2

Co-authored-by: Maria D'Costa <maria@expensify.com>

aldo-expensify requested a review from MariaHCD August 16, 2023 17:35

MariaHCD approved these changes Aug 16, 2023

View reviewed changes

MariaHCD merged commit ae6dd7e into main Aug 16, 2023

MariaHCD deleted the aldo_fix-decimals branch August 16, 2023 18:10

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

c3024 mentioned this pull request Aug 17, 2023

[HOLD for payment 2023-08-28] Web -Changed the request to ETB NaN" is shown when When saving with out chaging the amount #25390

Closed

6 tasks

This was referenced Aug 17, 2023

[HOLD for payment 2023-08-28] Web - Request money - Unable to change currency for request money #25386

Closed

Chat - Can't find profile message for pay with paypal #25394

Closed

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [HOLD for payment 2023-07-20] [$1000] IOU - Amount shows different in the LHN for VND currency #19792

Closed

6 tasks

rayane-djouah mentioned this pull request Jul 24, 2024

[C+ Checklist Needs Completion] [$250] IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page #43945

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix currency handling - always handle backend amounts as if they are in cents #24175

Fix currency handling - always handle backend amounts as if they are in cents #24175

aldo-expensify commented Aug 4, 2023 •

edited

Loading

melvin-bot bot commented Aug 4, 2023

melvin-bot bot commented Aug 4, 2023

aldo-expensify commented Aug 4, 2023

aldo-expensify commented Aug 5, 2023

aimane-chnaif commented Aug 5, 2023

aldo-expensify Aug 5, 2023 •

edited

Loading

aldo-expensify Aug 5, 2023

aldo-expensify commented Aug 5, 2023

aldo-expensify commented Aug 15, 2023

aldo-expensify commented Aug 15, 2023

aldo-expensify commented Aug 15, 2023 •

edited

Loading

sobitneupane left a comment

melvin-bot bot commented Aug 16, 2023

aldo-expensify commented Aug 16, 2023

OSBotify commented Aug 16, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

rayane-djouah commented Jul 24, 2024

Fix currency handling - always handle backend amounts as if they are in cents #24175

Fix currency handling - always handle backend amounts as if they are in cents #24175

Conversation

aldo-expensify commented Aug 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 4, 2023

melvin-bot bot commented Aug 4, 2023

aldo-expensify commented Aug 4, 2023

aldo-expensify commented Aug 5, 2023

aimane-chnaif commented Aug 5, 2023

aldo-expensify Aug 5, 2023 • edited Loading

Choose a reason for hiding this comment

aldo-expensify Aug 5, 2023

Choose a reason for hiding this comment

aldo-expensify commented Aug 5, 2023

aldo-expensify commented Aug 15, 2023

aldo-expensify commented Aug 15, 2023

aldo-expensify commented Aug 15, 2023 • edited Loading

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

melvin-bot bot commented Aug 16, 2023

aldo-expensify commented Aug 16, 2023

OSBotify commented Aug 16, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

rayane-djouah commented Jul 24, 2024

aldo-expensify commented Aug 4, 2023 •

edited

Loading

aldo-expensify Aug 5, 2023 •

edited

Loading

aldo-expensify commented Aug 15, 2023 •

edited

Loading