Web - Receipt page tries load when an attachment is present

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB
2. Click on request money
3. Enter amount and click next
4. Select new account
5. Open the request that you have sent
6. Set a description
7. Upload an image
8. Open the image
9. Click on previous arrow
10. Click on Download

Expected Result:

The receipt image should not load with the attachment image

Actual Result:

The receipt image tries to load and when you hit download button it redirects to 404 page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-18

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Receipt.mp4

Recording.1301.mp4

Expensify/Expensify Issue URL:

Issue reported by: @jo-ui

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692782659149089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01533b81d3403a95b1
• Upwork Job ID: 1694767523202289664
• Last Price Increase: 2023-08-24

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[StevenKKC]

It seems like intended.

App/src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js

Lines 52 to 62 in 8d70ff5

	const transaction = TransactionUtils.getTransaction(transactionID);
	if (TransactionUtils.hasReceipt(transaction)) {
	const {image} = ReceiptUtils.getThumbnailAndImageURIs(transaction.receipt.source, transaction.filename);
	attachments.unshift({
	source: tryResolveUrlFromApiRoot(image),
	isAuthTokenRequired: true,
	file: {name: transaction.filename},
	isReceipt: true,
	});
	return;
	}

[thienlnam]

cc @mountiny / @luacmartins Do you know if this is intended?

[luacmartins]

This is not intended. There was no receipt attached in this case. Why is TransactionUtils.hasReceipt(transaction) returning true?

[luacmartins]

FWIW I can't reproduce this issue on the latest main anymore. Given that I can't repro on main, this feature is still a WIP and this doesn't really break any functionality I say we demote this from a blocker.

[luacmartins]

@thienlnam I'll take this over as part of wave4

[StevenKKC]

EditMoneyRequest API returns receipt field.

[luacmartins]

That doesn't seem to be the case anymore in our dev API. I think this has been fixed. I'll keep the issue open until we can confirm though

[jo-ui]

@luacmartins This issue is still reproducible on the latest main (v1.3.56-20).

[jo-ui]

Receipt.mp4

[luacmartins]

@jo-ui yes, I'm referring to main on our API, not App.

[mountiny]

@luacmartins this should be fixed now

[mountiny]

@jo-ui could you confirm on the latest main

[jo-ui]

@mountiny on the latest main(v1.3.57-0) receipt image appears and then disappears after editing the merchant on mweb but not on web, is this a new issue or it can be fixed with this #25784 issue

[jo-ui]

20230824_085655_edited.mp4

[jo-ui]

@mountiny the above issue is also reproducible on web

2023-08-24.19-39-02.mp4

[luacmartins]

That's weird, I can reproduce on staging, but not on dev. It seems that EditMoneyRequest is returning data it shouldn't, so this is a backend issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01533b81d3403a95b1

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

[jo-ui]

@mountiny fix is live now and can't reproduce this anymore.

[melvin-bot]

@Ollyws, @luacmartins, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@Ollyws, @luacmartins, @adelekennedy Still overdue 6 days?! Let's take care of this!

[luacmartins]

No updates. Focused on other wave 4 issues.

[jo-ui]

@adelekennedy This issue has been 13 days since the PR was merged to production

[adelekennedy]

@luacmartins @mountiny what's the deal for payments here - just the reporting bonus?

[luacmartins]

Yes, just reporting bonus. The fix and reviews were all internal.

[jo-ui]

@adelekennedy Should I apply for the upwork job above for the reporting bonus?

[jo-ui]

@adelekennedy any updates?

[adelekennedy]

@jo-ui yes please!

[adelekennedy]

Payouts due:

Issue Reporter: $250 @jo-ui

Upwork job is here.

[jo-ui]

@adelekennedy can you please send me an offer it is saying " The job is private"

[jo-ui]

@adelekennedy any updates?

[adelekennedy]

whoops - this link @jo-ui

[jo-ui]

@adelekennedy I've applied for the job

[adelekennedy]

paid!

[melvin-bot]

@Ollyws, @luacmartins, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Seems like everyone is paid out and we're good to close. Thanks everyone!