Deploy Checklist: New Expensify 2023-08-24

[OSBotify]

Release Version: 1.3.57-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• refactor: SelectionList multiple selection #22622
• Extract emojis from paste text #23153
• fix keyboard flashing while clicking "Add attachment" #23994
• [UI]-Dropdown Button #24034
• [No QA] Onyx type core data #24054
• migrate native AttachmentPicker to functional component #24364
• Fix: Edit composer moves focus to main composer after press LHN menu item #24481
• fix: popover without overlay changes #24515
• Create SaaStr Demo flow #24535
• Disable Drag & Drop by default #24536
• fix: sync draft and edit status of thread first chat #24544
• [No QA] Allow distance requests to be viewed #24556
• Remove policy expense chat beta #24579
• [No QA] Add details for distance requests in MoneyRequestView #24589
• Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624
• Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630
• Display single waypoint #25161
• [NoQA] Optimistically update receipt state to OPEN when the request is edited #25385
• Add Download Banner to mWeb #25418
• Display Route #25434
• Category MenuItem and CategoryPicker component #25470
• [No QA] Fix require cycle from subscribeToReportCommentPushNotifications #25544
• #25561: apply flex1 to MenuItems titleStyle in MoneyRequestConfirmationList #25593
• Fix "Copy URL to clipboard" not working by long tap #25599
• Remove navigating to assignee page from task header action button #25609
• App allows '÷×' symbols in legal name even though error states that 'Name can only include letters' #25615
• add show link back home on profile page #25642
• Implement backTo param for ProfilePage navigation #25658
• fix: hide the edit modal if request can not be edited #25666
• Show the delete option on transaction thread correctly #25669
• Create Card-Rev-Share-for-Approved-Partners.md #25677
• Edit merchant field of money requests #25702
• fix: allow decimal values without integer in reimbursement amount #25723
• Block emoji reaction on report actions of report with errors #25729
• [No QA][TS migration] Migrate 'NAVIGATORS.js' constant to TypeScript #25746
• Make the merchant field be populated #25794
• [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #25847
• show disabled cursor on checkbox and "Select All" if they are unclickable #25882
• [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921
• [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955
• [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile  #26055

Internal QA:

• [CP Stag] Remove unneeded SaaStr & SBE account consts #25827 - @Beamanator

Deploy Blockers:

• [hold for payment 2023-08-30] [$1000] Google icon on sign in page shows overflow horizontal scrolling bars #25797
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [HOLD for payment 2023-08-25] Request money - App on recipient end crashes when receiving money request #25830
• Android - Request money - App crashes when editing Amount twice #25841
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] cursor should display as disabled on select all checkbox even if only non removable members are present #25859
• [HOLD for payment 2023-09-06] [$1000] No animation for Members and Invite Members page #25860
• Request money - Visual issue appear when change Merchant name #25870
• Android - IOU Distance - Map does not zoom in to the selected location on Start point #25871
• Report - App crashed when open a conversation with a specific account #25874
• [$1000] Android - Notifications - Inconsistent appearing of avatar on notification when app is backgrounded #25875
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Workspace- While inviting members, the contact selected is not shown #25877
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Workspace - CMD+ENTER does not work when inviting new members to WS #25878
• [HOLD for payment 2023-09-06] [$1000] There is no scroll bar on members page of a workspace #25879
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Invite member - Incorrect selection of member using Tab key #25883
• [HOLD for payment 2023-10-09] Member - Green highlight on member jumps to other member when selecting member #25884
• [HOLD #301281] [$1000] Web - Missing Default Merchant Statement in Split Bill Details #25885
• Unable to delete a workspace if owner leaves a workspace chat with one of the members #25887
• [HOLD for payment 2023-09-06] [$1000] skeleton ui does not show when contact are loading #25888
• [HOLD for payment 2023-09-20] [$1000] DEV: Share code avatar differs from profile avatar #25889
• [HOLD for payment 2023-09-06] [$1000] [HOLD for payment 2023-09-04] First member remains highlighted on members page #25890
• [HOLD for payment 2023-09-21] Web - Input field not focused on click of back button from Get assistance page #25893
• Workspace - Tooltip is miising on hover in invite members page #25895
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Workspaces - Name highlights on select member on invite page #25896
• IOU - Not able to remove the merchant #25898
• Workspace - There is no separating line for members #25966
• User is unable to authenticate with magic link #25979
• [$500] [HOLD for payment 2023-09-06] Dev - Unable to select a state #25998
• [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time #26027
• [HOLD for payment 2023-09-20] Web - Profile - Pronouns Displayed Without Performing Search #26074

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[roryabraham]

The following PRs should have been [No QA], checking them off:

• [No QA] Onyx type core data #24054
• [No QA] Fix require cycle from subscribeToReportCommentPushNotifications #25544
• [No QA][TS migration] Migrate 'NAVIGATORS.js' constant to TypeScript #25746

These PRs are for ExpensifyHelp (already in production, production QA), checking them off:

• Create Card-Rev-Share-for-Approved-Partners.md #25677

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.57-0 🚀

[roryabraham]

#25860 is NAB, checking it off

[mountiny]

Checking #25830 off, fixed in staging

[roryabraham]

#25797 was fixed on staging for the last checklist, I just forgot to remove the deploy blocker label. Checking it off

[luacmartins]

Checking off #25870. It's a dupe of #25784 and not a blocker since it's a minor UI thing

[roryabraham]

#25871 is behind a beta so NAB, checking it off

[roryabraham]

#25879 is NAB, checking it off

[mvtglobally]

@roryabraham Can you check this one
#24034 (comment)

[mvtglobally]

Also, is it possible to QA #24535 internally?
We are not sure how to pull account IDs in Staging and team is stuck

[jasperhuangg]

Checking off #25890 as I don't think we need to be blocking deploy on it.

[roryabraham]

So far three PRs have been CP'd:

• [CP Stag] Remove unneeded SaaStr & SBE account consts #25827
• [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #25847
• show disabled cursor on checkbox and "Select All" if they are unclickable #25882

[roryabraham]

#25841 is fixed, checking it off

[roryabraham]

Demoting #25874, checking it off

[mvtglobally]

@roryabraham We are down to last 4% TR and few PRs
any CPs we need to validate?

Current summary
PR #22622 is failing #25883, #25884
#23994 is failing #23994. Repro in prod, checking off
#24515 issue found when testing #25582. Repro in Prod, checking off

#24535 - Can you QA internally?

#25161 blocked on Web/mWeb due to #25696. & Issue found on Native apps #25871

#25434 is failing #25696

#25669 is failing #24372. Repro in prod, checking off

[roryabraham]

@mvtglobally three CPs listed above: #25813 (comment)

[mvtglobally]

@roryabraham for some reason earlier messages didnt show till now. Got the CPs. working on those

[Beamanator]

Checking off #25827 as internal review passed 👍

[mvtglobally]

Regression is completed.

#24535 is pass on all but IOS. We are not able to test on IOS as links are not opening in the app but in mWeb. checking off

Current summary - unchecked PRs
PR #22622 is failing #25883, #25884
#25161 blocked on Web/mWeb due to #25696. & Issue found on Native apps #25871
#25434 is failing #25696
#24034 (comment)

[cristipaval]

Demoted #25884, checking it off

[luacmartins]

Checking off #25889. Demoted to NAB since it's a super small UI issue and only happens in DEV.

[roryabraham]

Using this legend:

❗ No status
🆗 Demoted
📋 Solution in progress
🏁 Solution has been merged + CP'd, needs retest
✅ Resolved

---

🏁 #25859, should be fixed by #25882 in 1.3.57-3
🆗 #25875
📋 #25877, might be fixed by #25955
📋 #25878, might be fixed by #25955
📋 #25883, might be fixed by #25955
🆗 #25885
📋 #25888 sounds like there might be a working solution, but it still needs to be implemented
❗ #25893
🆗 #25895
🆗 #25896
🆗 #25898

[roryabraham]

🆗 #25888 demoted

[mountiny]

Checking #25966 off, demoted as its a new design

[mountiny]

#25878 is fixed in staging, checking off

[mountiny]

Checking #25877 off, confirmed this is not repro in staging anymore
Checking off #25883 as that was also fixed in staging, tested well
Checking #25859 off, fixed in staging

[roryabraham]

Going to check off #22622 because all the associated regressions are fixed or otherwise resolved

[roryabraham]

Marking #24034 as a pass. Looks good

[roryabraham]

#25161 is behind a beta, checking it off

[roryabraham]

#25434 is behind a beta, checking it off

[roryabraham]

Ok, that leaves us with just two blockers:

• [HOLD for payment 2023-09-21] Web - Input field not focused on click of back button from Get assistance page #25893
• User is unable to authenticate with magic link #25979

I've self-assigned both of these, so I'm going to triage them now

[roryabraham]

Demoting #25893, checking it off.

[roryabraham]

#25979 is not reproducible on staging, checking it off

[amyevans]

Demoted #26074 and checked it off

[luacmartins]

Checking off #25998. That happened in dev only and we merged the fix - #26045

[luacmartins]

Checking off #26027. Fix merged and being CPed. I'll test once it hits staging.

[luacmartins]

Just waiting on QA for:

• [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921
• [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955

[luacmartins]

Tested #26055 in staging. It's a pass. Checking off.

[luacmartins]

Down to #25921

[mvtglobally]

Checked off #25921

[luacmartins]

Checklist is clear. Shipping it.

[luacmartins]