Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Workspace- While inviting members, the contact selected is not shown #25877

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 24, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap profile icon
  3. Tap Workspace
  4. Create new workspace
  5. Tap Members
  6. Tap members
  7. Tap Invite
  8. Scroll down and select contacts

Expected Result:

After user selected a contact, the page must automatically scrolls up and he must be shown the selected contact with green tick

Actual Result:

After user selected a contact, a jump is shown but page not scrolled up automatically to show the selected contact with green tick. The user has to scroll up and see the contacts selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.57-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6175799_workspace.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 24, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jeet-dhandha
Copy link
Contributor

This is an expected behaviour

@roryabraham
Copy link
Contributor

@jeet-dhandha I don't think it was always an expected behavior. Do you have any links to where this was discussed?

@jeet-dhandha
Copy link
Contributor

jeet-dhandha commented Aug 24, 2023

@roryabraham
Copy link
Contributor

roryabraham commented Aug 24, 2023

Yeah ... I don't think either of those show clear consensus to change expected behavior here, so I think this is a regression – not expected behavior.

@joelbettner
Copy link
Contributor

@thiagobrez will you please take a look at this and give us your thoughts.

@thiagobrez
Copy link
Contributor

@joelbettner I wasn't aware of this behavior, will work on it

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Aug 25, 2023
@mountiny
Copy link
Contributor

confirmed this is fixed in staging and not reporting bonus, closing

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Aug 28, 2023
@melvin-bot melvin-bot bot changed the title Workspace- While inviting members, the contact selected is not shown [HOLD for payment 2023-09-04] Workspace- While inviting members, the contact selected is not shown Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 30, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-09-04] Workspace- While inviting members, the contact selected is not shown [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Workspace- While inviting members, the contact selected is not shown Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@lanitochka17
Copy link
Author

Issue reproducible on Build 1.3.84-0

20231014_111044.mp4

@lanitochka17 lanitochka17 reopened this Oct 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2023
@joelbettner
Copy link
Contributor

joelbettner commented Oct 25, 2023

@lanitochka17 could you please create a new issue for this as this one has already been closed and paid for. I'm going to re-close this issue.

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants