[CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955

thiagobrez · 2023-08-25T16:11:01Z

Details

Fixes part of the regressions found in SelectionList, enumerated here: https://expensify.slack.com/archives/C01GTK53T8Q/p1692920321478729

More context:
https://expensify.slack.com/archives/C01GTK53T8Q/p1692952886670059

Fixed Issues

$ #25877
$ #25878
$ #25883
PROPOSAL:

Tests

Verify that no errors appear in the JS console

In Workspace Invite page:

When selecting an item, list should scroll to the top, where this item is now checked
When pressing CTRL + ENTER (CMD + ENTER on Mac), list should advance to next step
When pressing TAB, list items should be focused without focusing the Checkbox itself
When pressing ENTER to select an item, if the blue focus from accessibility is present, the accessibility focus will be prioritized (selected) and the application highlight will be ignored

Offline tests

QA Steps

Verify that no errors appear in the JS console

In Workspace Invite page:

When selecting an item, list should scroll to the top, where this item is now checked
When pressing CTRL + ENTER (CMD + ENTER on Mac), list should advance to next step
When pressing TAB, list items should be focused without focusing the Checkbox itself
When pressing ENTER to select an item, if the blue focus from accessibility is present, the accessibility focus will be prioritized (selected) and the application highlight will be ignored

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.web.mov

Mobile Web - Safari

ios.web.mov

Desktop

desktop.mov

iOS

ios.native.mov

Android

android.native.mov

melvin-bot · 2023-08-25T16:11:41Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-08-25T17:51:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-08-25.at.11.10.24.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-08-25.at.11.30.25.PM.mov

iOS & Android

Screen.Recording.2023-08-25.at.11.25.58.PM.mov

Santhosh-Sellavel · 2023-08-25T17:54:48Z

@thiagobrez

I noticed a weird issue while testing this one on iOS.

The contacts section header is visible and overlaps with the list

Screen.Recording.2023-08-25.at.11.20.35.PM.mov

Santhosh-Sellavel · 2023-08-25T18:05:13Z

@thiagobrez

I noticed a weird issue while testing this one on iOS.

The contacts section header is visible and overlaps with the list

Screen.Recording.2023-08-25.at.11.20.35.PM.mov

It's not caused by any changes in the PR. It's happening on the main too, and can see the same issue on the PR reviewed earlier too.

thiagobrez · 2023-08-25T18:06:12Z

Thanks @Santhosh-Sellavel . I think we could fix this in Phase 3 of the refactor, since this wasn't reported as a deploy blocker

Santhosh-Sellavel · 2023-08-25T18:02:37Z

src/hooks/useActiveElement/index.js

+
+export default function useActiveElement() {


NAB Can we have a comment for the file?

@thiagobrez Please include in the follow-up issues if the PRs gets merged

Santhosh-Sellavel

Tests Pass. LGTM!

cristipaval

Code LGTM 👍

…egressions-2 [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key (cherry picked from commit 09a07ae)

OSBotify · 2023-08-25T19:10:03Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.57-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-25T19:22:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-29T00:06:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:56:33Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:56:51Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix(selection-list): scroll to top, cmd enter, tab key

acfc614

thiagobrez requested a review from a team as a code owner August 25, 2023 16:11

melvin-bot bot requested review from jasperhuangg and removed request for a team August 25, 2023 16:11

fix(selection-list): remove logs

d25179b

thiagobrez changed the title ~~fix(selection-list): scroll to top, cmd enter, tab key~~ [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key Aug 25, 2023

cristipaval requested a review from Santhosh-Sellavel August 25, 2023 16:14

roryabraham mentioned this pull request Aug 25, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

Santhosh-Sellavel reviewed Aug 25, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Aug 25, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam August 25, 2023 18:15

cristipaval approved these changes Aug 25, 2023

View reviewed changes

cristipaval merged commit 09a07ae into Expensify:main Aug 25, 2023

OSBotify pushed a commit that referenced this pull request Aug 25, 2023

Merge pull request #25955 from thiagobrez/thiagobrez/selection-list-r…

2140c01

…egressions-2 [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key (cherry picked from commit 09a07ae)

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955

[CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955

thiagobrez commented Aug 25, 2023 •

edited

Loading

melvin-bot bot commented Aug 25, 2023

Santhosh-Sellavel commented Aug 25, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 25, 2023

Santhosh-Sellavel commented Aug 25, 2023

thiagobrez commented Aug 25, 2023

Santhosh-Sellavel Aug 25, 2023

Santhosh-Sellavel Aug 25, 2023

Santhosh-Sellavel left a comment

cristipaval left a comment

OSBotify commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

[CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955

[CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955

Conversation

thiagobrez commented Aug 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 25, 2023

Santhosh-Sellavel commented Aug 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Aug 25, 2023

Santhosh-Sellavel commented Aug 25, 2023

thiagobrez commented Aug 25, 2023

Santhosh-Sellavel Aug 25, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Aug 25, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

cristipaval left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

thiagobrez commented Aug 25, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 25, 2023 •

edited

Loading